Windows FMA - Amazon WorkSpaces

[harrisonravazzolo]

Summary by CodeRabbit

• New Features

  • Added Amazon WorkSpaces support on Windows: app listing, version entry, installer/uninstaller metadata, and a UI icon.

• Improvements

  • Relaxed input validation to allow comma (,) and ampersand (&) characters in query filters.

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.81%. Comparing base (1f934e1) to head (c32d607).

Files with missing lines	Patch %	Lines
...SoftwarePage/components/icons/AmazonWorkspaces.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #46304      +/-   ##
==========================================
- Coverage   66.81%   66.81%   -0.01%     
==========================================
  Files        2809     2810       +1     
  Lines      223584   223586       +2     
  Branches    11309    11309              
==========================================
  Hits       149382   149382              
- Misses      60647    60648       +1     
- Partials    13555    13556       +1     

Flag	Coverage Δ
backend	68.53% <ø> (-0.01%)	⬇️
frontend	56.47% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[harrisonravazzolo]

@allenhouchins looks like tests past with the change to the regex but there is a different issue failing that's not associated with this.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[allenhouchins]

@cdcme please take a look and review. Very minor change to support , in file paths.

[coderabbitai]

Actionable comments posted: 0

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 923757cb-039b-4a80-9093-482b3a3586d7

📥 Commits

Reviewing files that changed from the base of the PR and between 2041586 and c32d607.

📒 Files selected for processing (2)

• ee/maintained-apps/outputs/apps.json
• frontend/pages/SoftwarePage/components/icons/index.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• ee/maintained-apps/outputs/apps.json

---

Walkthrough

This PR integrates Amazon WorkSpaces as a new maintained Windows application in Fleet. The backend validator is updated to permit ampersand and comma characters in SQL detection queries. A complete Windows app manifest is added with detection SQL for presence and version checks, MSI installer metadata, PowerShell install/uninstall scripts, checksum and upgrade code, and the app is registered in the maintained-apps list. On the frontend, a 32×32 icon component is added and wired into the SOFTWARE_NAME_TO_ICON_MAP mapping.

Possibly related PRs

• fleetdm/fleet#46220: Touches the same SQL input sanitization/validation used for maintained-apps detection queries.
• fleetdm/fleet#42397: Adds Codex CLI-specific/override-driven exists_query detection logic that would be subject to the same SQL validation.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description provided, but the required template includes multiple critical sections for validation, security, testing, and migrations that are not addressed.	Add a comprehensive description using the provided template, including security validation details, testing confirmation, and any relevant migration or compatibility notes.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Windows FMA - Amazon WorkSpaces' accurately reflects the main change: adding Amazon WorkSpaces support for Windows FMA.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch amazon-workspaces-client-windows-fma

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}