Add WinSCP as a Windows FMA - #46311
Conversation
Add WinSCP to maintained apps: introduce winget input metadata (winscp.json) and add installer/uninstaller PowerShell scripts (winscp_install.ps1 uses Inno Setup silent flags; winscp_uninstall.ps1 locates UninstallString/QuietUninstallString from registry and runs it with silent args). Update outputs: add app entry in apps.json and add winscp/windows.json with version, installer URL, checksums and embedded script refs. Add frontend icon component and image, and register the icon in the icons index.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46311 +/- ##
==========================================
- Coverage 66.86% 66.86% -0.01%
==========================================
Files 2762 2763 +1
Lines 221030 221032 +2
Branches 10919 10919
==========================================
+ Hits 147794 147795 +1
- Misses 59835 59836 +1
Partials 13401 13401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
WalkthroughThis PR adds WinSCP support to Fleet by implementing installation and uninstallation automation, application metadata, and frontend UI components. Two PowerShell scripts handle silent installation via Inno Setup flags and registry-based uninstallation with multiple command-format parsing. A winget input manifest defines the x86 MSI installer configuration and script paths. Output definitions include version-specific metadata, detection SQL queries, installer download URL, checksum validation, and embedded script contents. A new React icon component and icon-map entry provide UI support on the Software page. Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add WinSCP to maintained apps: introduce winget input metadata (winscp.json) and add installer/uninstaller PowerShell scripts (winscp_install.ps1 uses Inno Setup silent flags; winscp_uninstall.ps1 locates UninstallString/QuietUninstallString from registry and runs it with silent args). Update outputs: add app entry in apps.json and add winscp/windows.json with version, installer URL, checksums and embedded script refs. Add frontend icon component and image, and register the icon in the icons index.
Summary by CodeRabbit