Add several macOS FMAs - #47064
Conversation
Add macOS (darwin) support for BlueJ, Burp Suite CE, LastPass, and RStudio. Added homebrew input metadata (ee/maintained-apps/inputs/homebrew/*.json), new darwin output manifests including versions, installer URLs, sha256 and install/uninstall script refs (ee/maintained-apps/outputs/*/darwin.json), and updated ee/maintained-apps/outputs/apps.json to include darwin platform entries for each app. This enables packaging and automated install/uninstall handling for these apps on macOS.
Delete darwin-specific RStudio metadata and outputs: removed ee/maintained-apps/inputs/homebrew/rstudio.json and ee/maintained-apps/outputs/rstudio/darwin.json, and removed the RStudio (darwin) entry from ee/maintained-apps/outputs/apps.json. This drops the macOS installer/version refs and associated install/uninstall scripts; the RStudio Windows entry remains.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughThis PR adds macOS (darwin) platform support for three applications—BlueJ, Burp Suite Community Edition, and LastPass—to the maintained-apps catalog. The changes include three new Homebrew metadata input files, three new darwin platform entries in the central apps.json catalog, and three app-specific darwin manifests with embedded bash scripts for installation and uninstall operations. Each manifest defines a version, SQL presence/patch detection queries, installer URLs, checksums, and bash scripts that handle DMG mounting, app placement in /Applications, backup of existing installs, and conditional app lifecycle management (quit/relaunch) for active GUI sessions. Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds three new macOS Fleet-maintained apps (FMAs)—BlueJ, Burp Suite Community Edition, and LastPass—by introducing new Homebrew input manifests, generating corresponding macOS output manifests (including install/uninstall scripts), and registering the apps in the global apps.json catalog.
Changes:
- Added new Homebrew input manifests for BlueJ, Burp Suite Community Edition, and LastPass on macOS.
- Added new macOS output manifests for those apps with version/queries/installer metadata and embedded install/uninstall scripts.
- Updated the maintained-apps catalog (
outputs/apps.json) to include the new macOS entries.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ee/maintained-apps/outputs/lastpass/darwin.json | Adds the macOS output manifest for LastPass, including queries and install/uninstall scripts. |
| ee/maintained-apps/outputs/burp-suite/darwin.json | Adds the macOS output manifest for Burp Suite Community Edition, including queries and install/uninstall scripts. |
| ee/maintained-apps/outputs/bluej/darwin.json | Adds the macOS output manifest for BlueJ, including queries and install/uninstall scripts. |
| ee/maintained-apps/outputs/apps.json | Registers the new macOS app entries in the maintained apps catalog. |
| ee/maintained-apps/inputs/homebrew/lastpass.json | Adds the Homebrew input definition for LastPass (macOS). |
| ee/maintained-apps/inputs/homebrew/burp-suite.json | Adds the Homebrew input definition for Burp Suite Community Edition (macOS). |
| ee/maintained-apps/inputs/homebrew/bluej.json | Adds the Homebrew input definition for BlueJ (macOS). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request adds support for three new macOS applications—BlueJ, Burp Suite Community Edition, and LastPass—to the maintained apps system. For each app, it introduces input definitions, output metadata, and versioned install/uninstall scripts, enabling automated management and inventory tracking for these apps on macOS.
New macOS app support:
Added BlueJ:
bluej.json) and output metadata (bluej/darwin.json) with version, installer URL, and install/uninstall scripts for BlueJ on macOS. [1] [2]apps.jsonto include BlueJ for thedarwinplatform with a description.Added Burp Suite Community Edition:
burp-suite.json) and output metadata (burp-suite/darwin.json) with version, installer URL, and install/uninstall scripts for Burp Suite Community Edition on macOS. [1] [2]apps.jsonto include Burp Suite Community Edition for thedarwinplatform with a description.Added LastPass:
lastpass.json) and output metadata (lastpass/darwin.json) with version, installer URL, and install/uninstall scripts for LastPass on macOS. [1] [2]apps.jsonto include LastPass for thedarwinplatform with a description.Summary by CodeRabbit