Add XCreds as a macOS FMA - #45404
Conversation
Register XCreds as a maintained app: add Homebrew cask (Casks/xcreds.rb) and API/input JSON, add app metadata (ee/maintained-apps/inputs/homebrew/xcreds.json), and include outputs (apps.json and outputs/xcreds/darwin.json) with installer/uninstall scripts and checks. Also add frontend icon component and asset (XCreds.tsx, app-icon-xcreds-60x60@2x.png) and wire the icon into the icons index mapping.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45404 +/- ##
==========================================
- Coverage 66.72% 66.72% -0.01%
==========================================
Files 2732 2733 +1
Lines 218549 218551 +2
Branches 10681 10681
==========================================
+ Hits 145836 145837 +1
- Misses 59500 59501 +1
Partials 13213 13213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
Adds XCreds (Twocanoes) as a Fleet Maintained App for macOS, registering it in the maintained apps catalog with installer/uninstall scripts, a Homebrew custom-tap cask + generated API JSON, and a frontend icon.
Changes:
- New maintained-app metadata + outputs (apps.json, outputs/xcreds/darwin.json) and inputs (homebrew/xcreds.json, custom-tap cask + api JSON).
- New frontend icon component XCreds.tsx and registration in icons/index.ts.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/XCreds.tsx | New SVG/PNG icon component for XCreds. |
| frontend/pages/SoftwarePage/components/icons/index.ts | Wires XCreds into name→icon map. |
| ee/maintained-apps/outputs/xcreds/darwin.json | Generated install/uninstall scripts and version metadata. |
| ee/maintained-apps/outputs/apps.json | Adds XCreds entry to global apps list. |
| ee/maintained-apps/inputs/homebrew/xcreds.json | Source manifest for FMA generator. |
| ee/maintained-apps/inputs/homebrew/custom-tap/Casks/xcreds.rb | Homebrew cask source. |
| ee/maintained-apps/inputs/homebrew/custom-tap/api/xcreds.json | Generated API JSON for the custom-tap cask. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
WalkthroughThis PR adds XCreds, a macOS application that synchronizes IdP passwords with macOS login credentials, to the Fleet managed apps system. The change includes three primary components: a Homebrew cask configuration that packages the application with version detection, download URL construction, and uninstall/cleanup procedures; a managed app registry entry with macOS-specific installation and uninstallation scripts that handle app lifecycle, launchd service management, and user preference cleanup; and a frontend SVG icon component integrated into the software page's icon lookup system. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Register XCreds as a maintained app: add Homebrew cask (Casks/xcreds.rb) and API/input JSON, add app metadata (ee/maintained-apps/inputs/homebrew/xcreds.json), and include outputs (apps.json and outputs/xcreds/darwin.json) with installer/uninstall scripts and checks. Also add frontend icon component and asset (XCreds.tsx, app-icon-xcreds-60x60@2x.png) and wire the icon into the icons index mapping.
Summary by CodeRabbit