Skip to content

Add XCreds as a macOS FMA - #45404

Merged
allenhouchins merged 1 commit into
mainfrom
allenhouchis-xcreds-fma
May 15, 2026
Merged

Add XCreds as a macOS FMA#45404
allenhouchins merged 1 commit into
mainfrom
allenhouchis-xcreds-fma

Conversation

@allenhouchins

@allenhouchins allenhouchins commented May 13, 2026

Copy link
Copy Markdown
Member

Register XCreds as a maintained app: add Homebrew cask (Casks/xcreds.rb) and API/input JSON, add app metadata (ee/maintained-apps/inputs/homebrew/xcreds.json), and include outputs (apps.json and outputs/xcreds/darwin.json) with installer/uninstall scripts and checks. Also add frontend icon component and asset (XCreds.tsx, app-icon-xcreds-60x60@2x.png) and wire the icon into the icons index mapping.

Summary by CodeRabbit

  • New Features
    • Added XCreds as a supported managed application for macOS, including installation and uninstallability capabilities.
    • Integrated XCreds application icon and metadata into the application library for improved visibility and identification.

Review Change Stack

Register XCreds as a maintained app: add Homebrew cask (Casks/xcreds.rb) and API/input JSON, add app metadata (ee/maintained-apps/inputs/homebrew/xcreds.json), and include outputs (apps.json and outputs/xcreds/darwin.json) with installer/uninstall scripts and checks. Also add frontend icon component and asset (XCreds.tsx, app-icon-xcreds-60x60@2x.png) and wire the icon into the icons index mapping.
@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.72%. Comparing base (28b8b08) to head (1a11432).
⚠️ Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
...end/pages/SoftwarePage/components/icons/XCreds.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #45404      +/-   ##
==========================================
- Coverage   66.72%   66.72%   -0.01%     
==========================================
  Files        2732     2733       +1     
  Lines      218549   218551       +2     
  Branches    10681    10681              
==========================================
+ Hits       145836   145837       +1     
- Misses      59500    59501       +1     
  Partials    13213    13213              
Flag Coverage Δ
frontend 55.50% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins marked this pull request as ready for review May 15, 2026 15:33
@allenhouchins
allenhouchins requested a review from a team as a code owner May 15, 2026 15:33
Copilot AI review requested due to automatic review settings May 15, 2026 15:33
@fleet-release
fleet-release requested a review from eashaw May 15, 2026 15:33

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins
allenhouchins merged commit 8c9f56f into main May 15, 2026
30 of 31 checks passed
@allenhouchins
allenhouchins deleted the allenhouchis-xcreds-fma branch May 15, 2026 15:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds XCreds (Twocanoes) as a Fleet Maintained App for macOS, registering it in the maintained apps catalog with installer/uninstall scripts, a Homebrew custom-tap cask + generated API JSON, and a frontend icon.

Changes:

  • New maintained-app metadata + outputs (apps.json, outputs/xcreds/darwin.json) and inputs (homebrew/xcreds.json, custom-tap cask + api JSON).
  • New frontend icon component XCreds.tsx and registration in icons/index.ts.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/pages/SoftwarePage/components/icons/XCreds.tsx New SVG/PNG icon component for XCreds.
frontend/pages/SoftwarePage/components/icons/index.ts Wires XCreds into name→icon map.
ee/maintained-apps/outputs/xcreds/darwin.json Generated install/uninstall scripts and version metadata.
ee/maintained-apps/outputs/apps.json Adds XCreds entry to global apps list.
ee/maintained-apps/inputs/homebrew/xcreds.json Source manifest for FMA generator.
ee/maintained-apps/inputs/homebrew/custom-tap/Casks/xcreds.rb Homebrew cask source.
ee/maintained-apps/inputs/homebrew/custom-tap/api/xcreds.json Generated API JSON for the custom-tap cask.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9d2751c5-2b48-4000-a226-7f3e0b05c6a5

📥 Commits

Reviewing files that changed from the base of the PR and between 28b8b08 and 1a11432.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-xcreds-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (7)
  • ee/maintained-apps/inputs/homebrew/custom-tap/Casks/xcreds.rb
  • ee/maintained-apps/inputs/homebrew/custom-tap/api/xcreds.json
  • ee/maintained-apps/inputs/homebrew/xcreds.json
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/xcreds/darwin.json
  • frontend/pages/SoftwarePage/components/icons/XCreds.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR adds XCreds, a macOS application that synchronizes IdP passwords with macOS login credentials, to the Fleet managed apps system. The change includes three primary components: a Homebrew cask configuration that packages the application with version detection, download URL construction, and uninstall/cleanup procedures; a managed app registry entry with macOS-specific installation and uninstallation scripts that handle app lifecycle, launchd service management, and user preference cleanup; and a frontend SVG icon component integrated into the software page's icon lookup system.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchis-xcreds-fma

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants