Skip to content

Add TortoiseGit as a Windows FMA - #46208

Merged
allenhouchins merged 1 commit into
mainfrom
allenhouchins-add-tortoisegit-windows-fma
May 26, 2026
Merged

Add TortoiseGit as a Windows FMA#46208
allenhouchins merged 1 commit into
mainfrom
allenhouchins-add-tortoisegit-windows-fma

Conversation

@allenhouchins

@allenhouchins allenhouchins commented May 26, 2026

Copy link
Copy Markdown
Member

Register TortoiseGit as a maintained app: add winget input (ee/maintained-apps/inputs/winget/tortoisegit.json), add app metadata to outputs/apps.json, and create a platform-specific output with version, installer URL, sha256, install/uninstall PowerShell scripts, and MSI upgrade code (ee/maintained-apps/outputs/tortoisegit/windows.json). Also add a frontend icon component and asset (frontend/pages/SoftwarePage/components/icons/Tortoisegit.tsx and website/assets/images/app-icon-tortoisegit-60x60@2x.png) and wire it into the icons index mapping.

Summary by CodeRabbit

  • New Features
    • Added TortoiseGit as a new Windows application with version 2.18.0.1 support, including installation and uninstallation capabilities.
    • Integrated TortoiseGit icon into the application UI for easy identification.

Review Change Stack

Register TortoiseGit as a maintained app: add winget input (ee/maintained-apps/inputs/winget/tortoisegit.json), add app metadata to outputs/apps.json, and create a platform-specific output with version, installer URL, sha256, install/uninstall PowerShell scripts, and MSI upgrade code (ee/maintained-apps/outputs/tortoisegit/windows.json). Also add a frontend icon component and asset (frontend/pages/SoftwarePage/components/icons/Tortoisegit.tsx and website/assets/images/app-icon-tortoisegit-60x60@2x.png) and wire it into the icons index mapping.
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.83%. Comparing base (590bf18) to head (dca3859).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ages/SoftwarePage/components/icons/Tortoisegit.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #46208      +/-   ##
==========================================
- Coverage   66.83%   66.83%   -0.01%     
==========================================
  Files        2755     2756       +1     
  Lines      220198   220200       +2     
  Branches    10916    11044     +128     
==========================================
+ Hits       147170   147171       +1     
  Misses      59734    59734              
- Partials    13294    13295       +1     
Flag Coverage Δ
frontend 55.79% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins marked this pull request as ready for review May 26, 2026 18:27
@allenhouchins
allenhouchins requested a review from a team as a code owner May 26, 2026 18:27
Copilot AI review requested due to automatic review settings May 26, 2026 18:27
@fleet-release
fleet-release requested a review from eashaw May 26, 2026 18:27

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins
allenhouchins merged commit d8a0bfc into main May 26, 2026
28 of 30 checks passed
@allenhouchins
allenhouchins deleted the allenhouchins-add-tortoisegit-windows-fma branch May 26, 2026 18:29
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 137872c0-fed8-4c7e-81a5-b12c3e7e0227

📥 Commits

Reviewing files that changed from the base of the PR and between 590bf18 and dca3859.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-tortoisegit-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (5)
  • ee/maintained-apps/inputs/winget/tortoisegit.json
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/tortoisegit/windows.json
  • frontend/pages/SoftwarePage/components/icons/Tortoisegit.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR adds TortoiseGit (a Git client for Windows) to Fleet's maintained applications catalog. The changes include: a new winget metadata input JSON defining TortoiseGit's package and installer characteristics; a corresponding entry in the app registry (apps.json); a Windows application definition (windows.json) with MSI installation and uninstallation scripts; and a React icon component for the software page UI with its registration in the icon map.

Possibly related PRs

  • fleetdm/fleet#45404: Follows the same pattern of adding a new React SVG icon component and extending SOFTWARE_NAME_TO_ICON_MAP in the icons index to register that icon for an app name key.
  • fleetdm/fleet#45883: Adds a new app to Fleet's catalog and UI by introducing a new icon component, updating the SOFTWARE_NAME_TO_ICON_MAP, and adding corresponding app metadata entries.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-add-tortoisegit-windows-fma

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants