FMA - VSCodium for Windows and macOS

[harrisonravazzolo]

Summary by CodeRabbit

• New Features
  • Added VSCodium support on macOS and Windows with full install and uninstall flows (including silent/automated installs).
  • Published VSCodium package metadata for both platforms (v1.121.03429).
  • Added a VSCodium icon to the app interface for improved visual identification.

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.88%. Comparing base (8ef2590) to head (3710160).
⚠️ Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
...d/pages/SoftwarePage/components/icons/VsCodium.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #46426    +/-   ##
========================================
  Coverage   66.88%   66.88%            
========================================
  Files        2791     2795     +4     
  Lines      222293   222321    +28     
  Branches    11469    11345   -124     
========================================
+ Hits       148682   148706    +24     
- Misses      60161    60166     +5     
+ Partials    13450    13449     -1     

Flag	Coverage Δ
frontend	56.33% <50.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e1bf841a-3203-4c34-9bfd-d66ec5bf0386

📥 Commits

Reviewing files that changed from the base of the PR and between 57e23ec and 3710160.

📒 Files selected for processing (1)

• ee/maintained-apps/outputs/apps.json

---

Walkthrough

Adds VSCodium to maintained apps: Homebrew input for macOS and Winget input for Windows (with PowerShell install/uninstall scripts), compiled platform outputs for macOS and Windows targeting version 1.121.03429 (with embedded install/uninstall scripts), updates the apps registry, and adds a frontend VsCodium icon and mapping.

Possibly related PRs

• fleetdm/fleet#46250: Also updates the icons index and apps registry by adding a maintained-app entry.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description provided. The template requires multiple sections including related issue, checklist items, testing details, and platform-specific verifications.	Add a comprehensive PR description following the repository template, including related issue reference, relevant checklist items, testing confirmation, and platform compatibility verification.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding VSCodium support for Windows and macOS platforms in the Fleet Managed Apps system.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch win-fma-vscodium

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

ee/maintained-apps/outputs/vscodium/windows.json (1)

6-7: <!-- [scratchpad_start]
[task review_file_1/1 review_method_1/1]
[observations]

• ee/maintained-apps/outputs/vscodium/windows.json (lines 6-7): exists/patched gate on name = 'VSCodium' AND publisher = 'VSCodium'.
• ee/maintained-apps/inputs/winget/scripts/vscodium_uninstall.ps1: detects uninstall entry by DisplayName -eq "VSCodium" only; no Publisher check.
• web_search results indicate VSCodium System installer snapshots show uninstall key Publisher value as VSCodium.
  [analysis]
• Main concern (“publisher != 'VSCodium'”) is not supported for current system installer: evidence indicates Publisher is indeed VSCodium.
• Residual fragility remains: if Publisher ever differs on some installs, Fleet detection/patching would miss while uninstall would still find by DisplayName.
  [pending]
• None.
  [actions]
• Rewrite review comment to reflect that publisher predicate matches current observed metadata, while keeping the robustness/alignment suggestion.
  [done]
  [ scratchpad_end ] -->
  VSCodium publisher predicate matches current installer uninstall metadata; consider only making detection more robust.

The VSCodium uninstall Publisher value is observed as VSCodium in HKLM uninstall key snapshots, so publisher = 'VSCodium' in ee/maintained-apps/outputs/vscodium/windows.json should align with the system installer.

However, the uninstall script (ee/maintained-apps/inputs/winget/scripts/vscodium_uninstall.ps1) matches only DisplayName -eq "VSCodium" and ignores Publisher; if Publisher ever differs on a host, Fleet detection/patching would skip while uninstall would still work. Consider broadening the detection predicate (e.g., dropping publisher = 'VSCodium' or aligning it with the uninstall filter) for resilience.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/vscodium/windows.json` around lines 6 - 7, The
JSON detection uses a publisher predicate ("exists" and "patched" queries in
ee/maintained-apps/outputs/vscodium/windows.json) but the uninstall script
(ee/maintained-apps/inputs/winget/scripts/vscodium_uninstall.ps1) only checks
DisplayName -eq "VSCodium"; update the detection queries to match the uninstall
filter (remove or relax the "publisher = 'VSCodium'" condition in the "exists"
and "patched" queries) or otherwise align both sides (modify the uninstall
script to also check Publisher), so detection and uninstall logic are consistent
and resilient if Publisher varies.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/apps.json`:
- Line 2396: The VSCodium "description" string contains a grammar typo ("a
releases"); update the "description" field value for the VSCodium entries (the
JSON key "description") to a correct sentence such as "VSCodium is a release of
VS Code without Microsoft branding, telemetry, or licensing." and apply the same
change to the other identical entry noted in the file so both occurrences are
fixed.

---

Nitpick comments:
In `@ee/maintained-apps/outputs/vscodium/windows.json`:
- Around line 6-7: The JSON detection uses a publisher predicate ("exists" and
"patched" queries in ee/maintained-apps/outputs/vscodium/windows.json) but the
uninstall script
(ee/maintained-apps/inputs/winget/scripts/vscodium_uninstall.ps1) only checks
DisplayName -eq "VSCodium"; update the detection queries to match the uninstall
filter (remove or relax the "publisher = 'VSCodium'" condition in the "exists"
and "patched" queries) or otherwise align both sides (modify the uninstall
script to also check Publisher), so detection and uninstall logic are consistent
and resilient if Publisher varies.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0501525f-ec3d-455e-ac3c-16ff66813c90

📥 Commits

Reviewing files that changed from the base of the PR and between 8ef2590 and 57e23ec.

⛔ Files ignored due to path filters (1)

• website/assets/images/app-icon-vscodium-60x60@2x.png is excluded by !**/*.png

📒 Files selected for processing (9)

• ee/maintained-apps/inputs/homebrew/vscodium.json
• ee/maintained-apps/inputs/winget/scripts/vscodium_install.ps1
• ee/maintained-apps/inputs/winget/scripts/vscodium_uninstall.ps1
• ee/maintained-apps/inputs/winget/vscodium.json
• ee/maintained-apps/outputs/apps.json
• ee/maintained-apps/outputs/vscodium/darwin.json
• ee/maintained-apps/outputs/vscodium/windows.json
• frontend/pages/SoftwarePage/components/icons/VsCodium.tsx
• frontend/pages/SoftwarePage/components/icons/index.ts