[devswha]

Change

scripts/ui-regression.ts could fail with every check passing. On #824 the first CI attempt ended with

451 |     await route.fulfill({ response, json: body });
error: fulfill: Route is already handled!

after the check that owns that route had printed PASS; a rerun of the same commit passed.

The handlers in question await route.fetch() before they answer, and the app polls /api/machines on its own, so a call can be in flight whenever a check ends. page.unroute does not wait for it. When the route taken away is the page's last one, Playwright drops the page's interceptor and continues the request on the server side; the handler's own fulfill then finds the route handled. The rejection travels through Playwright's event listener, outside every assertion, and Bun exits 1.

scripts/drained-route.ts adds routeDrained(page, url, handler): it registers the route and returns an unroute that first waits for the calls in flight (15 s deadline), then removes that handler. It is used at:

• ui-regression.ts: the held stale poll, the BG status check, and the plan check on the desktop page and on the phone (its context is closed right after).
• tab-menu-regression.ts: the pending-selection check, which unrouted first and waited for its handlers afterwards.

Not used, on purpose: unrouteAll({ behavior: "wait" }) has the same race between two calls in flight (playwright-core 1.63) and removes unrelated routes; "ignoreErrors" and a .catch(() => {}) would hide a handler's real failure. A handler that throws still fails the unroute here.

Left alone: tab-menu-regression.ts:292 and terminal-copy-regression.ts:176 only race in a failure's cleanup, and five scripts close a context with a fetched route registered (a different error, if any). #806 moves the ui-regression.ts sites into ui-regression-palette.ts; it needs this carried over when it is rebased.

Validation

• Reproduction (throwaway script, local Chrome): two requests in flight, then page.unroute → fulfill: Route is already handled! twice as unhandled rejections; the same with routeDrained → both fulfilled, no rejection; a handler that throws → the unroute rejects with that error.
• TMPDIR=/tmp CHROME_PATH=<lockfile Chromium> bun run check run --build bun scripts/ui-regression.ts: exit 0, 115 PASS lines, on an isolated herdr (this includes checkTabMenu).
• bun run typecheck: passed.
• The diagnosis and the fix were reviewed read-only against playwright-core's source (Route.removeHandler continuing the request, _startHandling's assertion).

The original failure is rare (one of the last 26 failed CI runs), so a passing run does not prove its absence; the reproduction is what shows the race gone.

Release

Test scripts only; no app, contract or runtime change.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: b113252a-2dfe-44a8-9688-4c51cc81bcf0

---

📥 Commits

Reviewing files that changed from the base of the PR and between 3291eb4 and b802bb4.

---

📒 Files selected for processing (3)

• scripts/drained-route.ts
• scripts/tab-menu-regression.ts
• scripts/ui-regression.ts

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}