Repository navigation
docs(guide): Settings → Phone & devices, and Portal keeps its name - #743
Conversation
Follow-ups from the review of devswha#229: - Name the Settings entry the way the app labels it, Phone & devices, in the Portal section and in the devices.json paragraph. - Say that Portal's first run saves the name in the identity file, so the random --name in the command does not give a new address on each start.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to No actionable merge risk is identified in the supplied guide updates. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review details
Pre-merge checks |
|
devswha
left a comment
There was a problem hiding this comment.
Thanks! I checked each claim against the code, and they are all correct:
- Settings → Phone & devices → Pair a device:
Phone & devicesis the page's label (src/components/SettingsDialog.tsx,PAGEStitle), and the Pair a device button lives on that page (DevicesPanel.tsx). - devices.json paragraph: with a damaged registry,
/api/devicesanswers 503device_store_unavailablewith the full message for the owner (server/devices.ts), and the Devices panel on that page shows it as an alert. So "Settings → Phone & devices and the server log explain the error" holds. - Portal keeps its name: in v2.6.1,
identity.LoadOrCreate(portal/identity/client_identity.go) parses an existing identity file as-is, without looking at--name, andcmd/portal-tunnel/tunnel/runtime.gouses that identity. A new random--nameon a later start therefore changes nothing, as the added sentence says.
Non-blocking, for a follow-up rather than this PR: besides AccessGate.tsx, which you already noted, the server's own 503 text for non-owner callers in server/devices.ts still says "Settings → Devices".
Merge upstream/main (0.4.6, devswha#728, devswha#743-devswha#780) into next
## Change Release 0.4.7, from main at 80ca9bb (47 PRs since v0.4.6). - `package.json` and `herdr-plugin.toml`: 0.4.7. - CHANGELOG: `[Unreleased]` becomes `[0.4.7] - 2026-10-12`, with the compare links. - #513's entry moves out of the 0.4.0 section, where its branch's merge left it, and gets its credit; it says the pace is a setting, off by default (#834). - A Maintenance section covers the PRs that had no entry: #743, #756, #767, #795, #805, #810, #813, #821, #826, #831. - The note under the Hermes entry that asked for a runtime bump at release now says what a remote PC needs. - `release-summaries.json`: 0.4.7 in en/ko/ja/zh/tr (6 new, 6 improved, 5 fixed). The Turkish lines are not checked by a native speaker. - `REMOTE_BUNDLE_VERSION` 25 -> 26. Since v0.4.5's runtime the bridge gained Hermes transcripts (#604), conversation pushes (#689) and Grok/Antigravity activity (#816), so `remote-v26` is published before the app release. Not in this release: #606. ## Validation - `bun scripts/release-notes.ts 0.4.7` renders the summaries and the full changelog (235 lines). - `bun run typecheck` and `bun run build`: pass. - `TMPDIR=/tmp bun run test:unit`: one failure, `server/voice.test.ts` ("audio.webm" vs "clip.webm"), which fails the same way on unmodified `main` on this Mac (Bun 1.4.0); CI runs Bun 1.4.2. - Every PR merged since v0.4.6 was checked against the changelog section: all 47 are linked. ## Release After this merges and its CI on `main` passes: push `remote-v26`, wait for its release, then run the Release workflow with `0.4.7`.
Change
The two non-blocking notes from the last review of #229, in
docs/guide.md:SettingsDialog.tsx) and the rest of the guide. Thedevices.jsonparagraph had the same old "Settings → Devices", so it is updated too.--namein the command therefore does not give a new address on each start (LoadOrCreate,portal/identity/client_identity.goin Portal v2.6.1).The sign-in screen's own text (
AccessGate.tsx) still says "Settings → Devices". That is a UI string with ko/ja/zh translations, so I left it for a separate change.Docs only; no CHANGELOG entry, since app users do not notice it.
Validation
docs/guide.md; "Phone & devices" is the label insrc/components/SettingsDialog.tsx.LoadOrCreate: an existing identity file is parsed as it is, and its stored name is used. I did not restart a tunnel to see it live.