Skip to content

docs(guide): Samsung Internet's forced dark mode, and how to turn it off - #459

Merged
devswha merged 1 commit into
mainfrom
docs/samsung-internet-dark-mode
Oct 5, 2026
Merged

devswha merged 1 commit into
mainfrom
docs/samsung-internet-dark-mode

Conversation

@devswha

@devswha devswha commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Change

#451에서 @Yoonwoo-Ha 님이 알려 주신 내용을 가이드의 FAQ에 한 항목으로 넣습니다.

Samsung Internet에는 모든 페이지를 강제로 어둡게 다시 칠하는 기능이 있습니다. 이 앱처럼 자체 라이트/다크 테마를 가진 페이지도 예외가 아니어서, 라이트 테마가 어둡게 보이고 다크 테마는 한 번 더 어두워집니다. 비슷한 색이 뭉개지고 요금제 미터의 막대가 비어 보입니다. 앱의 버그가 아니고, 브라우저 설정 웹 콘텐츠에 어두운 화면 모드 강제 적용을 끄면 해결됩니다.

FAQ의 "An agent is missing from the chat…" 항목 다음에 넣었습니다. 설정 이름은 영어와 한국어를 함께 적었습니다.

코드 변경은 없습니다. 문서만 바뀌어서 CHANGELOG에는 적지 않았습니다.

Validation

  • 이 PC에는 Galaxy 기기가 없어 직접 재현하지 못했습니다. 증상, 원인, 해결 방법은 #451의 보고(Galaxy Tab S7+, Samsung Internet)와 거기 링크된 Samsung 문서를 따랐습니다.
  • "Chrome에서 열면 된다"는 부분도 보고자의 설명을 옮긴 것이고 직접 확인하지 않았습니다.

Closes #451

🤖 Generated with Claude Code

Reported by @Yoonwoo-Ha in #451: the browser repaints the app's own themes, so Light looks
dark and Dark is darkened twice. The FAQ names the setting to turn off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5a9d46a9-7bb9-4c28-921f-4bbc48b34c16
📥 Commits

Reviewing files that changed from the base of the PR and between a2b1382 and 848f1c0.

📒 Files selected for processing (1)
  • docs/guide.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Added an FAQ explaining how Samsung Internet’s forced dark mode can affect app themes and plan-meter bars, with steps to disable the setting or use Chrome.

Walkthrough

The guide adds an FAQ entry about Samsung Internet's forced dark mode. It describes theme and plan-meter display changes and suggests disabling the setting or using Chrome.

Changes

Samsung Internet FAQ

Layer / File(s) Summary
Document the forced dark mode behavior
docs/guide.md
The FAQ describes how Samsung Internet's forced dark mode can alter the app's themes and plan-meter bars. It suggests disabling Force dark mode for web content or using Chrome.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: nahwan-kim

Merge Risk: ⚪ Minimal · up to 848f1

No material merge blocker is evident. The FAQ reflects the reported Samsung Internet issue; the Chrome suggestion has not been independently verified.

Architecture Summary

Architecture risk: 🔵 Low · up to 848f1

The change affects 1 system.

Changed systems: docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/guide.md: Added an FAQ entry describing the display effects of Samsung Internet’s forced dark mode and the suggested settings change or Chrome alternative.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change: an FAQ entry about Samsung Internet’s forced dark mode and how to disable it.
Description check ✅ Passed The description explains the problem and expected behavior, identifies the setting that resolves it, and reports the validation limits and evidence. It covers both required sections in the template.
Linked Issues check ✅ Passed Issue #451 asks for a FAQ entry explaining Samsung Internet’s forced dark mode and its fix. The change adds that entry after the missing-agent FAQ item. It describes the light- and dark-theme symptoms…
Out of Scope Changes check ✅ Passed The only change adds documentation for issue #451’s reported Samsung Internet behavior. The diff shows no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@devswha
devswha merged commit 4555859 into main Oct 5, 2026
4 checks passed
@devswha
devswha deleted the docs/samsung-internet-dark-mode branch October 5, 2026 06:38
devswha added a commit that referenced this pull request Oct 5, 2026
Bumps package.json and herdr-plugin.toml to 0.3.50 and moves the
Unreleased notes under [0.3.50] - 2026-10-06, with the compare link.
Adds the PR link and credit the #471 entry was missing; every other
entry already carries them. Raises the remote PC bundle to 17: #470
changes the prompt answer route on the bridge, so a remote PC on bundle
16 keeps the old behaviour until its bridge is updated. Push the
`remote-v17` tag and let the bundle workflow publish before running
release.yml.

Known limits carried into the notes: Japanese and Chinese text uses the
device's fonts beside Pretendard; #469 stays open for what #470 does not
cover (answers after the first committing key, identical twin prompts,
screens no reader knows).

Carries #422 #423 #424 #425 #426 #435 #437 #439 #446 #447 #448 #452 #454
#455 #456 #457 #458 #459 #460 #461 #462 #463 #465 #466 #467 #468 #471
#473 #474 #475

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Samsung Internet's forced dark mode repaints the app's themes (Galaxy Tab S7+)

1 participant