Repository navigation
refactor(manifest)!: name manifest builder constructor explicitly - #2314
Merged
zeroshade merged 6 commits intoOct 26, 2026
Conversation
fallintoplace
marked this pull request as ready for review
October 24, 2026 11:34
Rename NewManifestFile to NewManifestBuilder to match the returned type and other public builder constructors. Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
fallintoplace
force-pushed
the
refactor/manifest-builder-constructor-upstream-20261024
branch
from
October 25, 2026 11:05
55c3104 to
afb7316
Compare
…am-20261024 Restore the NewManifestBuilder compatibility note from 39f9e4d dropped by the release-notes sync.
…am-20261024 Take main's releases.md; the compatibility note for this change lands in a follow-up release-notes PR so the pre-v1 renames can merge in parallel.
zeroshade
approved these changes
Oct 26, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Straightforward rename: the function returns a *ManifestBuilder, and every in-repo caller is updated with no NewManifestFile references left. I pushed a merge of main (3452cbc); go vet ./... (including -tags integration) and the root and ./table/... tests pass. The compatibility note for this change (dropped by the "sync release notes with main" commit) will land in a single follow-up release-notes PR covering this batch of pre-v1 renames, so these can merge in parallel without releases.md conflicts. LGTM.
zeroshade
added a commit
to fallintoplace/iceberg-go
that referenced
this pull request
Oct 26, 2026
Resolve the test overlaps with the renames already on main (apache#2308, apache#2314, apache#2317, apache#2319): each conflict hunk keeps this PR's sequence-number names with main's other renames applied.
This was referenced Oct 26, 2026
zeroshade
added a commit
to zeroshade/iceberg-go
that referenced
this pull request
Oct 28, 2026
…g changes Add release notes for the rename batch (apache#2308, apache#2314, apache#2315, apache#2316, apache#2317, apache#2319, apache#2322, apache#2323) and for apache#2067, apache#2290, apache#2294, apache#2307, apache#2310 and apache#2313. Remove stray blank lines inside the compatibility-notes list.
9 of 23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
NewManifestFiletoNewManifestBuilder.Why
ManifestBuilder.Implementation
Refs #2062.