Repository navigation
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
9d42bce to
a70c1fb
Compare
…261024 Restore the SnapshotAsOf compatibility note from a70c1fb dropped by the release-notes sync.
…261024 Take main's releases.md; the compatibility note for this change lands in a follow-up release-notes PR so the pre-v1 renames can merge in parallel.
zeroshade
left a comment
There was a problem hiding this comment.
An as-of lookup should include the requested timestamp, and Java's SnapshotUtil.nullableSnapshotIdAsOfTime does the same. The only non-test caller already passed true, and WithSnapshotAsOf and inspect were already inclusive, so behavior doesn't change. Strict-before stays available through SnapshotLogEntryAsOf, and TestSnapshotLogEntryAsOf still covers it, so dropping the SnapshotAsOf(..., false) tests loses no coverage. I pushed a merge of main (94a6fbe); go vet ./... (including -tags integration) and the table and CLI tests pass. The compatibility note for this change (dropped by the "sync release notes with main" commit) will land in a single follow-up release-notes PR covering this batch of pre-v1 renames, so these can merge in parallel without releases.md conflicts. LGTM.
What
inclusiveargument fromTable.SnapshotAsOf.Why
Implementation
Refs #2062.