Repository navigation
refactor(view,udf)!: make NewMetadataBuilder infallible - #2316
Merged
zeroshade merged 6 commits intoOct 26, 2026
Conversation
fallintoplace
marked this pull request as ready for review
October 24, 2026 11:34
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
fallintoplace
force-pushed
the
refactor/view-udf-infallible-metadata-builders-upstream-20261024
branch
from
October 25, 2026 11:05
431046a to
7770288
Compare
…rs-upstream-20261024 Restore the compatibility note from ecbb345 dropped by the release-notes sync.
…rs-upstream-20261024 Take main's releases.md; the compatibility note for this change lands in a follow-up release-notes PR so the pre-v1 renames can merge in parallel.
zeroshade
approved these changes
Oct 26, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Neither constructor could fail, so dropping the error result is right, and the dead if err != nil branches in view/metadata.go and view/view.go go with it. I pushed a merge of main (8d0dbf9); go vet ./... (including -tags integration) and the view, udf and catalog tests pass. The compatibility note for this change (dropped by the "sync release notes with main" commit) will land in a single follow-up release-notes PR covering this batch of pre-v1 renames, so these can merge in parallel without releases.md conflicts. LGTM.
zeroshade
added a commit
to fallintoplace/iceberg-go
that referenced
this pull request
Oct 26, 2026
Keep both releases.md notes, and use the infallible udf.NewMetadataBuilder from apache#2316 in the new validation test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
NewMetadataBuilderfunctions return a builder directly.Why
Implementation
Refs #2062.