Move BashOperator template field logic from __init__ to execute - #70429
Closed
Kunal8954 wants to merge 19 commits into
Closed
Move BashOperator template field logic from __init__ to execute#70429Kunal8954 wants to merge 19 commits into
Kunal8954 wants to merge 19 commits into
Conversation
Kunal8954
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
July 25, 2026 07:13
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-3-test
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Author
|
I've opened a PR for BashOperator: #70429 |
…ions (apache#70376) * Remove no-op ServerResponseError re-raise blocks in airflowctl operations Every operation wrapped its request in a try/except that caught ServerResponseError only to re-raise it unchanged. The error is already raised by the client's raise_on_4xx_5xx response hook, so these wrappers added no behavior and only obscured the request logic. Dropping them leaves the propagation semantics identical while making each operation a plain request/parse. * Update airflow-ctl/src/airflowctl/api/operations.py Co-authored-by: Henry Chen <henryhenry0512@gmail.com> * Update airflow-ctl/src/airflowctl/api/operations.py Co-authored-by: Henry Chen <henryhenry0512@gmail.com> * Update airflow-ctl/src/airflowctl/api/operations.py Co-authored-by: Henry Chen <henryhenry0512@gmail.com> --------- Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
…e-field validation in PapermillOperator (apache#70435)
* add queue paarmeter to list-workers * refactor
The add-worker-queues, remove-worker-queues, set-worker-concurrency,
update-maintenance-comments, and remove-worker subcommands raised bare
`SystemExit` after catching a TypeError from the model layer, which
yields exit status 0. Shell scripts wrapping these commands treated
failures as success and continued as if the queue, concurrency,
maintenance-comment, or worker-removal change had been applied.
Pass the exception message to SystemExit so the process exits with
status 1 and writes the failure to stderr, matching the file's own
convention for validation-error paths (see the explicit
`raise SystemExit("Error: ...")` calls in the same subcommands) and the
`raise SystemExit(str(e))` pattern already used elsewhere in the edge3
CLI. The model layer already logs the error before raising, so the
redundant logger.error call in the three subcommands that had one is
removed.
…pache#67685) The TODO asked to drop a # type: ignore once tenacity issue apache#428 is resolved, but the ignore itself was already removed in apache#53294 (Cleanup type ignores) while the accompanying comment was left behind. The comment now points at an ignore that no longer exists, so remove it.
Add SQLBulkLoadOperator to bulk load tab-delimited files into SQL tables using the underlying hook's native bulk loading implementation. The operator supports optional pre- and post-load SQL statements for common setup and cleanup tasks. Includes unit tests, documentation, and an example DAG.
Kunal8954
requested review from
dheerajturaga,
henry3260,
kaxil,
o-nikolas,
shahar1 and
shubhamraj-git
as code owners
July 27, 2026 00:00
Member
|
#70437 is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #70296
Summary
Moves the template-field-dependent logic in
BashOperator.__init__(determining whetherbash_commandis an inline command or a script file) intoexecute(), since template fields are only rendered after__init__runs. Previously this check ran on the un-rendered Jinja expression.Changes
self._is_inline_cmdcomputation from__init__is_inline_cmdcomputation insideexecute(), using the already-renderedself.bash_commandBashOperatorentry fromvalidate_operators_init_exemptions.txt