Skip to content

Fix template-field validation in PapermillOperator - #70435

Merged
shahar1 merged 1 commit into
apache:mainfrom
bramhanandlingala:fix/70296-3
Jul 26, 2026
Merged

Fix template-field validation in PapermillOperator#70435
shahar1 merged 1 commit into
apache:mainfrom
bramhanandlingala:fix/70296-3

Conversation

@bramhanandlingala

@bramhanandlingala bramhanandlingala commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Fixes the papermill provider's entry from the #70296 exemption-list burn-down: PapermillOperator.

input_nb and output_nb are template fields, but were validated in __init__ — before Jinja templating runs, so the check ran against the raw un-rendered value.

  • Moved validation from __init__ to execute(), after templating occurs.
  • __init__ now only does plain assignments.
  • Removed PapermillOperator from the exemption list.
  • Updated existing test + added a new test covering the fixed behavior.

Related to #70296

Gen-AI disclosure: I used a generative AI tool to help identify the root
cause, write tests, and draft the PR description. I reviewed, tested, and
verified all changes locally before submitting.

Was generative AI tooling used to co-author this PR?
  • Yes — Claude

Generated-by: Claude following the guidelines

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahar1
shahar1 dismissed their stale review July 26, 2026 05:45

Concerns addressed

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@shahar1 shahar1 changed the title Fix template-field validation timing in PapermillOperator Fix template-field validation in PapermillOperator Jul 26, 2026
@shahar1
shahar1 merged commit dbe4627 into apache:main Jul 26, 2026
79 checks passed
Kunal8954 pushed a commit to Kunal8954/airflow that referenced this pull request Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants