Remove stale type-ignore TODO in HTTP hook run_with_advanced_retry - #67685
Merged
potiuk merged 2 commits intoJul 26, 2026
Conversation
The TODO asked to drop a # type: ignore once tenacity issue apache#428 is resolved, but the ignore itself was already removed in apache#53294 (Cleanup type ignores) while the accompanying comment was left behind. The comment now points at an ignore that no longer exists, so remove it.
Contributor
Author
|
Hi @potiuk @amoghrajesh, could you take a look at this PR when you have a moment? It's a small cleanup removing a stale type-ignore TODO in the HTTP hook. Thanks! |
potiuk
marked this pull request as draft
July 2, 2026 18:45
potiuk
marked this pull request as ready for review
July 2, 2026 22:15
potiuk
approved these changes
Jul 26, 2026
Kunal8954
pushed a commit
to Kunal8954/airflow
that referenced
this pull request
Jul 27, 2026
…pache#67685) The TODO asked to drop a # type: ignore once tenacity issue apache#428 is resolved, but the ignore itself was already removed in apache#53294 (Cleanup type ignores) while the accompanying comment was left behind. The comment now points at an ignore that no longer exists, so remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpHook.run_with_advanced_retrycarried a TODO asking to remove a# type: ignoreonce tenacity#428 is resolved:However, the
# type: ignoreitself was already removed in #53294 (Cleanup type ignores) — but that PR left the accompanying TODO comment behind. The comment now points at an ignore that no longer exists, so it is pure leftover noise. This PR removes the stale comment.No functional or type-checking change: the
# type: ignorehas been absent since #53294 and mypy passes onmainwithout it.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.