Skip to content

Remove stale type-ignore TODO in HTTP hook run_with_advanced_retry - #67685

Merged
potiuk merged 2 commits into
apache:mainfrom
ed-kyu:fix/remove-stale-tenacity-type-ignore-todo
Jul 26, 2026
Merged

Remove stale type-ignore TODO in HTTP hook run_with_advanced_retry#67685
potiuk merged 2 commits into
apache:mainfrom
ed-kyu:fix/remove-stale-tenacity-type-ignore-todo

Conversation

@ed-kyu

@ed-kyu ed-kyu commented May 29, 2026

Copy link
Copy Markdown
Contributor

HttpHook.run_with_advanced_retry carried a TODO asking to remove a # type: ignore once tenacity#428 is resolved:

# TODO: remove ignore type when https://github.com/jd/tenacity/issues/428 is resolved
return self._retry_obj(self.run, *args, **kwargs)  # type: ignore

However, the # type: ignore itself was already removed in #53294 (Cleanup type ignores) — but that PR left the accompanying TODO comment behind. The comment now points at an ignore that no longer exists, so it is pure leftover noise. This PR removes the stale comment.
No functional or type-checking change: the # type: ignore has been absent since #53294 and mypy passes on main without it.


Was generative AI tooling used to co-author this PR?
  • Yes

Generated-by: Claude Code (Opus 4.8) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

The TODO asked to drop a # type: ignore once tenacity issue apache#428 is
resolved, but the ignore itself was already removed in apache#53294 (Cleanup
type ignores) while the accompanying comment was left behind. The
comment now points at an ignore that no longer exists, so remove it.
@ed-kyu

ed-kyu commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Hi @potiuk @amoghrajesh, could you take a look at this PR when you have a moment? It's a small cleanup removing a stale type-ignore TODO in the HTTP hook. Thanks!

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jun 1, 2026
@potiuk
potiuk marked this pull request as draft July 2, 2026 18:45
@potiuk
potiuk marked this pull request as ready for review July 2, 2026 22:15
@potiuk
potiuk merged commit 018977e into apache:main Jul 26, 2026
171 checks passed
Kunal8954 pushed a commit to Kunal8954/airflow that referenced this pull request Jul 27, 2026
…pache#67685)

The TODO asked to drop a # type: ignore once tenacity issue apache#428 is
resolved, but the ignore itself was already removed in apache#53294 (Cleanup
type ignores) while the accompanying comment was left behind. The
comment now points at an ignore that no longer exists, so remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:http ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants