Skip to content

Use Quote blocks for statement patterns and remove text quote mark styles - #232

Merged
juanfra merged 5 commits into
WordPress:trunkfrom
AshishJii:fix/quote-issue
Nov 17, 2026
Merged

juanfra merged 5 commits into
WordPress:trunkfrom
AshishJii:fix/quote-issue

Conversation

@AshishJii

Copy link
Copy Markdown
Contributor

Description

Fixes #213

  • Removes "Quote Mark" and "Quote Mark on Color" block style variations from Paragraph/Heading blocks.
  • Replaces their usage in text-statement.php, text-statement-wide.php and page-blog-home.php with semantic core/quote blocks.

Screenshots

Screenshot 2026-11-11 at 10 10 03 PM

Testing Instructions

  1. Add New Post and insert a Paragraph/Heading block. Check the block settings sidebar and confirm Quote Mark and Quote Mark on Color are gone.
  2. Insert Text Statement, Text Statement Wide patterns. Save and view post on front end. Inspect the statements to confirm they render as semantic <blockquote> elements.

Use of AI Tools

AI assistance: Yes
Tool(s): Antigravity
Model(s): Gemini 3.8 Flash
Used for: Analyzing issue #213, drafting implementation plan, writing pattern markup, and drafting PR documentation; reviewed and verified manually.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: AshishJii <ashishjii@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: henriqueiamarino <iamarinoh@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions github-actions Bot added documentation Improvements or additions to documentation [Type] Tooling Issues or PRs related to tooling [Area] Global Styles Issues or PRs that touch theme.json or the base stylesheet. [Area] Patterns Issues or PRs that touch the theme's block patterns. First-time Contributor Pull request opened by a first-time contributor to the repository labels Nov 11, 2026
@github-actions

Copy link
Copy Markdown

👋 Thanks for your first pull request, @AshishJii! We'll take a look soon.

Comment thread style.css Outdated
* The Text Statement quote sits on an inverted card, where the default
* Border-colored mark disappears. Match its text without changing other quotes.
*/
.wp-block-quote.ipsum-quote-on-color::before {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we need this it's better to make it a block style instead so users can edit it. In fact, the whole quotation css should belong in a block style too, so people can remove it using the editor, but that probably belongs on a different PR

@github-actions github-actions Bot removed the [Area] Global Styles Issues or PRs that touch theme.json or the base stylesheet. label Nov 17, 2026
@juanfra

juanfra commented Nov 17, 2026

Copy link
Copy Markdown
Member

Thanks @AshishJii! And sorry for the takeover. To get this in before the RC 1 string freeze, I pushed an update following where #213 landed:

  • The three patterns now quote "Write the sentence first. The page can wait." with the cite "From the essays".
  • The on-color mark is a registered Quote block style, Plain on Color, instead of the ipsum-quote-on-color class, so style.css is unchanged.
  • Merged trunk, which resolves the conflict.

@henriqueiamarino, a few things I'd like you to check. First, there are no curly quotes around the line, since the ❝ mark is already there, and the gap above the cite is now spacing|30 because if not the text would be touching the one above.

The other thing is the name of the block style. Are you ok with the name, or do you want something different?

@MaggieCabrera @t-hamano it'd be important if we could try to squeeze this one in, so that we get the string changes before the sync with RC1 WordPress/wordpress-develop#15948

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Block Styles page in the demo content says "Here is every style Ipsum offers", but the new Plain on Color style isn't listed in the Quotes section yet. Could we add an example of it there, like the removed Quote Mark on Color one?

That said, this file isn't subject to localization, so it's fine to handle this in a follow-up.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Aki! Added

* Slug: ipsum/text-statement
* Categories: text
* Viewport width: 1280
* Description: A one-line statement on an inverted card. It has the opening quotation mark on top, centered, and room for a single link.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and room for a single link.

Note that <a href="#">essays</a> was removed in this PR, so this pattern no longer contains a link. Also, the Group block wrapping the Quote block still has a link color style applied, which currently has no effect.

I think we should consider one of the following:

  1. Leave it as is, to prepare for users inserting a link in the future. Without this style, a link might not be visible on this background. The description still holds, since there's "room" for a link.
  2. Apply a link to some of the text, as in trunk. For example, "essays" in the citation. Since this changes a translatable string, we need to decide before the RC1 sync.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! I went with option 2

@henriqueiamarino henriqueiamarino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @juanfra, and thanks @AshishJii for getting this started. Both look right to me: no curly quotes, since the ❝ already does that job, and the spacing | 30 gap above the cite. “Plain on Color” works for me as a name, since it sits next to Plain the same way the old Quote Mark on Color did. Good to go from my side before the RC 1 sync.

@juanfra
juanfra merged commit d26734e into WordPress:trunk Nov 17, 2026
9 of 11 checks passed
@juanfra

juanfra commented Nov 17, 2026

Copy link
Copy Markdown
Member

Thanks everyone!

@t-hamano

Copy link
Copy Markdown
Contributor

From a code perspective, this looks good to me. Since the string freeze is close, this isn't a blocker, but it's worth noting that the layout of the wide pattern changes slightly.

trunk This PR
trunk-logged-in pr-977f1dd-logged-in

The browser's default 40px margin is applied to both sides of the Quote block, which is visible on the left. This is because the Group block wrapping the Quote block uses layout: default, so WordPress layout styles don't adjust its horizontal margins.

If this isn't intentional, we should fix it in a follow-up. Previous default themes take slightly different approaches to resetting the browser's default margin on the Quote block, but they should be a useful reference:

Theme Resets left/right margin How
Twenty Twenty-Two Yes add_theme_support( 'wp-block-styles' ) loads core's quote/theme.scss, which sets margin: 0 0 1.75em 0
Twenty Twenty-Three No core/quote in theme.json only sets padding
Twenty Twenty-Four No core/quote in theme.json only sets padding and custom CSS
Twenty Twenty-Five Yes Explicitly sets left: 0 and right: 0 in styles.blocks.core/quote.spacing.margin in theme.json

MaggieCabrera added a commit to MaggieCabrera/wordpress-develop that referenced this pull request Nov 17, 2026
…mark styles.

The Text Statement, Text Statement Wide and Page Blog Home patterns drew a quotation mark over an ordinary paragraph, so what looked like a quote wasn't marked up as one. They now use real Quote blocks, citing a line from the persona's essays instead of a first-person introduction. The Quote Mark styles for Paragraph and Heading are removed, and a new Plain on Color style for the Quote block keeps the mark visible on dark cards.

Synced from WordPress/ipsum#232.

See #66678.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juanfra

juanfra commented Nov 17, 2026

Copy link
Copy Markdown
Member

@henriqueiamarino can you please take a look at what @t-hamano shared?

wporg-sync pushed a commit to WordPress/wordpress-develop that referenced this pull request Nov 17, 2026
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch.

A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e

- Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216)
- Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203)
- Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200)
- Improve design guide defaults and schema descriptions (WordPress/ipsum#193)
- Make the short post date format translatable (WordPress/ipsum#224)
- Fix Details block markers being announced by screen readers (WordPress/ipsum#230)
- Remove the physical left alignment from the page patterns (WordPress/ipsum#226)
- Indent the navigation submenus on the inline start (WordPress/ipsum#225)
- Fix accessible names for overlay navigation (WordPress/ipsum#228)
- Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214)
- Use a logical margin for the comment form checkbox (WordPress/ipsum#231)
- Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145)
- Fix accessible name of overlay search form (WordPress/ipsum#239)
- Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238)
- Keep the post date on one line when categories wrap (WordPress/ipsum#205)
- Remove repeated button styles from theme.json (WordPress/ipsum#235)
- Remove unused values from theme.json (WordPress/ipsum#237)
- Make the credit line URL translatable (WordPress/ipsum#240)
- Use single border radius values in theme.json (WordPress/ipsum#236)
- Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245)
- Use the Site Title in Footer Centered (WordPress/ipsum#244)
- Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247)
- Treat "Written by" as a label before the author name (WordPress/ipsum#246)
- Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232)
  

This commit also includes changes that only exist in core:

- Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles.
- `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`.
- A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match".

Developed in: #15948

Follow-up to r65366.

Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi.
Fixes #66678. See #66352.

git-svn-id: https://develop.svn.wordpress.org/trunk@65549 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Nov 17, 2026
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch.

A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e

- Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216)
- Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203)
- Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200)
- Improve design guide defaults and schema descriptions (WordPress/ipsum#193)
- Make the short post date format translatable (WordPress/ipsum#224)
- Fix Details block markers being announced by screen readers (WordPress/ipsum#230)
- Remove the physical left alignment from the page patterns (WordPress/ipsum#226)
- Indent the navigation submenus on the inline start (WordPress/ipsum#225)
- Fix accessible names for overlay navigation (WordPress/ipsum#228)
- Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214)
- Use a logical margin for the comment form checkbox (WordPress/ipsum#231)
- Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145)
- Fix accessible name of overlay search form (WordPress/ipsum#239)
- Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238)
- Keep the post date on one line when categories wrap (WordPress/ipsum#205)
- Remove repeated button styles from theme.json (WordPress/ipsum#235)
- Remove unused values from theme.json (WordPress/ipsum#237)
- Make the credit line URL translatable (WordPress/ipsum#240)
- Use single border radius values in theme.json (WordPress/ipsum#236)
- Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245)
- Use the Site Title in Footer Centered (WordPress/ipsum#244)
- Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247)
- Treat "Written by" as a label before the author name (WordPress/ipsum#246)
- Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232)
  

This commit also includes changes that only exist in core:

- Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles.
- `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`.
- A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match".

Developed in: WordPress/wordpress-develop#15948

Follow-up to r65366.

Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi.
Fixes #66678. See #66352.
Built from https://develop.svn.wordpress.org/trunk@65549


git-svn-id: http://core.svn.wordpress.org/trunk@64622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@AshishJii

AshishJii commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi @juanfra, @MaggieCabrera! I’m new to contributing to WordPress, so I may be missing something. I noticed my PR #232 was included in this Core sync commit, but I don’t see my name in the Props line. Could you let me know if I’m missing a step, or advise how I can make sure I’m credited? Thanks.

@Mamaduka

Copy link
Copy Markdown
Member

Sorry, that was my mistake.

@MaggieCabrera, @juanfra, let's adjust the list for the next sync to include @AshishJii.

cc @peterwilsoncc

@juanfra

juanfra commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Thank you! FWIW, I believe the credits for Ipsum would be accounted for in the overall count before release. That means that you should be credited for the work on this PR @AshishJii

arshidkv12 pushed a commit to arshidkv12/wordpress-develop that referenced this pull request Nov 21, 2026
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch.

A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e

- Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216)
- Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203)
- Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200)
- Improve design guide defaults and schema descriptions (WordPress/ipsum#193)
- Make the short post date format translatable (WordPress/ipsum#224)
- Fix Details block markers being announced by screen readers (WordPress/ipsum#230)
- Remove the physical left alignment from the page patterns (WordPress/ipsum#226)
- Indent the navigation submenus on the inline start (WordPress/ipsum#225)
- Fix accessible names for overlay navigation (WordPress/ipsum#228)
- Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214)
- Use a logical margin for the comment form checkbox (WordPress/ipsum#231)
- Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145)
- Fix accessible name of overlay search form (WordPress/ipsum#239)
- Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238)
- Keep the post date on one line when categories wrap (WordPress/ipsum#205)
- Remove repeated button styles from theme.json (WordPress/ipsum#235)
- Remove unused values from theme.json (WordPress/ipsum#237)
- Make the credit line URL translatable (WordPress/ipsum#240)
- Use single border radius values in theme.json (WordPress/ipsum#236)
- Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245)
- Use the Site Title in Footer Centered (WordPress/ipsum#244)
- Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247)
- Treat "Written by" as a label before the author name (WordPress/ipsum#246)
- Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232)
  

This commit also includes changes that only exist in core:

- Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles.
- `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`.
- A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match".

Developed in: WordPress#15948

Follow-up to r65366.

Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi.
Fixes #66678. See #66352.

git-svn-id: https://develop.svn.wordpress.org/trunk@65549 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Patterns Issues or PRs that touch the theme's block patterns. documentation Improvements or additions to documentation First-time Contributor Pull request opened by a first-time contributor to the repository [Type] Tooling Issues or PRs related to tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quote Mark block styles on Paragraph and Heading blocks may be confusing

6 participants