Repository navigation
Use Quote blocks for statement patterns and remove text quote mark styles - #232
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
|
👋 Thanks for your first pull request, @AshishJii! We'll take a look soon. |
| * The Text Statement quote sits on an inverted card, where the default | ||
| * Border-colored mark disappears. Match its text without changing other quotes. | ||
| */ | ||
| .wp-block-quote.ipsum-quote-on-color::before { |
There was a problem hiding this comment.
I think if we need this it's better to make it a block style instead so users can edit it. In fact, the whole quotation css should belong in a block style too, so people can remove it using the editor, but that probably belongs on a different PR
# Conflicts: # style.min.css
|
Thanks @AshishJii! And sorry for the takeover. To get this in before the RC 1 string freeze, I pushed an update following where #213 landed:
@henriqueiamarino, a few things I'd like you to check. First, there are no curly quotes around the line, since the ❝ mark is already there, and the gap above the cite is now The other thing is the name of the block style. Are you ok with the name, or do you want something different? @MaggieCabrera @t-hamano it'd be important if we could try to squeeze this one in, so that we get the string changes before the sync with RC1 WordPress/wordpress-develop#15948 |
There was a problem hiding this comment.
The Block Styles page in the demo content says "Here is every style Ipsum offers", but the new Plain on Color style isn't listed in the Quotes section yet. Could we add an example of it there, like the removed Quote Mark on Color one?
That said, this file isn't subject to localization, so it's fine to handle this in a follow-up.
| * Slug: ipsum/text-statement | ||
| * Categories: text | ||
| * Viewport width: 1280 | ||
| * Description: A one-line statement on an inverted card. It has the opening quotation mark on top, centered, and room for a single link. |
There was a problem hiding this comment.
and room for a single link.
Note that <a href="#">essays</a> was removed in this PR, so this pattern no longer contains a link. Also, the Group block wrapping the Quote block still has a link color style applied, which currently has no effect.
I think we should consider one of the following:
- Leave it as is, to prepare for users inserting a link in the future. Without this style, a link might not be visible on this background. The description still holds, since there's "room" for a link.
- Apply a link to some of the text, as in trunk. For example, "essays" in the citation. Since this changes a translatable string, we need to decide before the RC1 sync.
There was a problem hiding this comment.
Good catch, thanks! I went with option 2
henriqueiamarino
left a comment
There was a problem hiding this comment.
Thanks, @juanfra, and thanks @AshishJii for getting this started. Both look right to me: no curly quotes, since the ❝ already does that job, and the spacing | 30 gap above the cite. “Plain on Color” works for me as a name, since it sits next to Plain the same way the old Quote Mark on Color did. Good to go from my side before the RC 1 sync.
|
Thanks everyone! |
…mark styles. The Text Statement, Text Statement Wide and Page Blog Home patterns drew a quotation mark over an ordinary paragraph, so what looked like a quote wasn't marked up as one. They now use real Quote blocks, citing a line from the persona's essays instead of a first-person introduction. The Quote Mark styles for Paragraph and Heading are removed, and a new Plain on Color style for the Quote block keeps the mark visible on dark cards. Synced from WordPress/ipsum#232. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@henriqueiamarino can you please take a look at what @t-hamano shared? |
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch. A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e - Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216) - Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203) - Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200) - Improve design guide defaults and schema descriptions (WordPress/ipsum#193) - Make the short post date format translatable (WordPress/ipsum#224) - Fix Details block markers being announced by screen readers (WordPress/ipsum#230) - Remove the physical left alignment from the page patterns (WordPress/ipsum#226) - Indent the navigation submenus on the inline start (WordPress/ipsum#225) - Fix accessible names for overlay navigation (WordPress/ipsum#228) - Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214) - Use a logical margin for the comment form checkbox (WordPress/ipsum#231) - Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145) - Fix accessible name of overlay search form (WordPress/ipsum#239) - Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238) - Keep the post date on one line when categories wrap (WordPress/ipsum#205) - Remove repeated button styles from theme.json (WordPress/ipsum#235) - Remove unused values from theme.json (WordPress/ipsum#237) - Make the credit line URL translatable (WordPress/ipsum#240) - Use single border radius values in theme.json (WordPress/ipsum#236) - Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245) - Use the Site Title in Footer Centered (WordPress/ipsum#244) - Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247) - Treat "Written by" as a label before the author name (WordPress/ipsum#246) - Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232) This commit also includes changes that only exist in core: - Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles. - `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`. - A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match". Developed in: #15948 Follow-up to r65366. Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi. Fixes #66678. See #66352. git-svn-id: https://develop.svn.wordpress.org/trunk@65549 602fd350-edb4-49c9-b593-d223f7449a82
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch. A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e - Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216) - Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203) - Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200) - Improve design guide defaults and schema descriptions (WordPress/ipsum#193) - Make the short post date format translatable (WordPress/ipsum#224) - Fix Details block markers being announced by screen readers (WordPress/ipsum#230) - Remove the physical left alignment from the page patterns (WordPress/ipsum#226) - Indent the navigation submenus on the inline start (WordPress/ipsum#225) - Fix accessible names for overlay navigation (WordPress/ipsum#228) - Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214) - Use a logical margin for the comment form checkbox (WordPress/ipsum#231) - Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145) - Fix accessible name of overlay search form (WordPress/ipsum#239) - Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238) - Keep the post date on one line when categories wrap (WordPress/ipsum#205) - Remove repeated button styles from theme.json (WordPress/ipsum#235) - Remove unused values from theme.json (WordPress/ipsum#237) - Make the credit line URL translatable (WordPress/ipsum#240) - Use single border radius values in theme.json (WordPress/ipsum#236) - Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245) - Use the Site Title in Footer Centered (WordPress/ipsum#244) - Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247) - Treat "Written by" as a label before the author name (WordPress/ipsum#246) - Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232) This commit also includes changes that only exist in core: - Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles. - `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`. - A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match". Developed in: WordPress/wordpress-develop#15948 Follow-up to r65366. Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi. Fixes #66678. See #66352. Built from https://develop.svn.wordpress.org/trunk@65549 git-svn-id: http://core.svn.wordpress.org/trunk@64622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
Hi @juanfra, @MaggieCabrera! I’m new to contributing to WordPress, so I may be missing something. I noticed my PR #232 was included in this Core sync commit, but I don’t see my name in the Props line. Could you let me know if I’m missing a step, or advise how I can make sure I’m credited? Thanks. |
|
Sorry, that was my mistake. @MaggieCabrera, @juanfra, let's adjust the list for the next sync to include @AshishJii. |
|
Thank you! FWIW, I believe the credits for Ipsum would be accounted for in the overall count before release. That means that you should be credited for the work on this PR @AshishJii |
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch. A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e - Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216) - Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203) - Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200) - Improve design guide defaults and schema descriptions (WordPress/ipsum#193) - Make the short post date format translatable (WordPress/ipsum#224) - Fix Details block markers being announced by screen readers (WordPress/ipsum#230) - Remove the physical left alignment from the page patterns (WordPress/ipsum#226) - Indent the navigation submenus on the inline start (WordPress/ipsum#225) - Fix accessible names for overlay navigation (WordPress/ipsum#228) - Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214) - Use a logical margin for the comment form checkbox (WordPress/ipsum#231) - Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145) - Fix accessible name of overlay search form (WordPress/ipsum#239) - Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238) - Keep the post date on one line when categories wrap (WordPress/ipsum#205) - Remove repeated button styles from theme.json (WordPress/ipsum#235) - Remove unused values from theme.json (WordPress/ipsum#237) - Make the credit line URL translatable (WordPress/ipsum#240) - Use single border radius values in theme.json (WordPress/ipsum#236) - Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245) - Use the Site Title in Footer Centered (WordPress/ipsum#244) - Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247) - Treat "Written by" as a label before the author name (WordPress/ipsum#246) - Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232) This commit also includes changes that only exist in core: - Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles. - `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`. - A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match". Developed in: WordPress#15948 Follow-up to r65366. Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi. Fixes #66678. See #66352. git-svn-id: https://develop.svn.wordpress.org/trunk@65549 602fd350-edb4-49c9-b593-d223f7449a82


Description
Fixes #213
text-statement.php,text-statement-wide.phpandpage-blog-home.phpwith semanticcore/quoteblocks.Screenshots
Testing Instructions
<blockquote>elements.Use of AI Tools
AI assistance: Yes
Tool(s): Antigravity
Model(s): Gemini 3.8 Flash
Used for: Analyzing issue #213, drafting implementation plan, writing pattern markup, and drafting PR documentation; reviewed and verified manually.