Repository navigation
Fix horizontal scroll caused by long unbroken words in comments - #200
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
juanfra
left a comment
There was a problem hiding this comment.
Thanks for working on this! The fix works
I'm wondering, in the quest of reducing the amount of CSS, what if we fix it with the wrapper instead. The "Comment template wrapper" is a vertical flexi with justifyContent: left, so the comment grows with the content. As a plain group (like TT5), the existing break-word on body should be enough and only the author would need anywhere.
That makes all comments 100% width, though. If @henriqueiamarino feels short comments should fit their content, this PR is the way to go as it is.
|
Thanks @juanfra - went with the wrapper approach. The Comment Template Wrapper is now a plain group (like TT5), and Trade-off noted: short comments are full width now. Happy to revisit if @henriqueiamarino prefers them sized to content. |
|
Yes, the wrapper approach is the right call, thanks for reshaping it. Comments in Ipsum carry no card or background, so a short comment sized to its content renders exactly the same as a full-width one. Plain group plus anywhere on the author name only is the leaner fix, and dropping the |
A comment or comment author name with a long string and no spaces made the whole page scroll sideways. Comment content and author names now use `overflow-wrap: anywhere`, so they wrap inside the comment box. Synced from WordPress/ipsum#200. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch. A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e - Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216) - Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203) - Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200) - Improve design guide defaults and schema descriptions (WordPress/ipsum#193) - Make the short post date format translatable (WordPress/ipsum#224) - Fix Details block markers being announced by screen readers (WordPress/ipsum#230) - Remove the physical left alignment from the page patterns (WordPress/ipsum#226) - Indent the navigation submenus on the inline start (WordPress/ipsum#225) - Fix accessible names for overlay navigation (WordPress/ipsum#228) - Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214) - Use a logical margin for the comment form checkbox (WordPress/ipsum#231) - Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145) - Fix accessible name of overlay search form (WordPress/ipsum#239) - Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238) - Keep the post date on one line when categories wrap (WordPress/ipsum#205) - Remove repeated button styles from theme.json (WordPress/ipsum#235) - Remove unused values from theme.json (WordPress/ipsum#237) - Make the credit line URL translatable (WordPress/ipsum#240) - Use single border radius values in theme.json (WordPress/ipsum#236) - Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245) - Use the Site Title in Footer Centered (WordPress/ipsum#244) - Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247) - Treat "Written by" as a label before the author name (WordPress/ipsum#246) - Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232) This commit also includes changes that only exist in core: - Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles. - `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`. - A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match". Developed in: #15948 Follow-up to r65366. Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi. Fixes #66678. See #66352. git-svn-id: https://develop.svn.wordpress.org/trunk@65549 602fd350-edb4-49c9-b593-d223f7449a82
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch. A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e - Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216) - Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203) - Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200) - Improve design guide defaults and schema descriptions (WordPress/ipsum#193) - Make the short post date format translatable (WordPress/ipsum#224) - Fix Details block markers being announced by screen readers (WordPress/ipsum#230) - Remove the physical left alignment from the page patterns (WordPress/ipsum#226) - Indent the navigation submenus on the inline start (WordPress/ipsum#225) - Fix accessible names for overlay navigation (WordPress/ipsum#228) - Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214) - Use a logical margin for the comment form checkbox (WordPress/ipsum#231) - Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145) - Fix accessible name of overlay search form (WordPress/ipsum#239) - Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238) - Keep the post date on one line when categories wrap (WordPress/ipsum#205) - Remove repeated button styles from theme.json (WordPress/ipsum#235) - Remove unused values from theme.json (WordPress/ipsum#237) - Make the credit line URL translatable (WordPress/ipsum#240) - Use single border radius values in theme.json (WordPress/ipsum#236) - Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245) - Use the Site Title in Footer Centered (WordPress/ipsum#244) - Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247) - Treat "Written by" as a label before the author name (WordPress/ipsum#246) - Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232) This commit also includes changes that only exist in core: - Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles. - `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`. - A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match". Developed in: WordPress/wordpress-develop#15948 Follow-up to r65366. Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi. Fixes #66678. See #66352. Built from https://develop.svn.wordpress.org/trunk@65549 git-svn-id: http://core.svn.wordpress.org/trunk@64622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch. A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e - Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216) - Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203) - Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200) - Improve design guide defaults and schema descriptions (WordPress/ipsum#193) - Make the short post date format translatable (WordPress/ipsum#224) - Fix Details block markers being announced by screen readers (WordPress/ipsum#230) - Remove the physical left alignment from the page patterns (WordPress/ipsum#226) - Indent the navigation submenus on the inline start (WordPress/ipsum#225) - Fix accessible names for overlay navigation (WordPress/ipsum#228) - Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214) - Use a logical margin for the comment form checkbox (WordPress/ipsum#231) - Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145) - Fix accessible name of overlay search form (WordPress/ipsum#239) - Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238) - Keep the post date on one line when categories wrap (WordPress/ipsum#205) - Remove repeated button styles from theme.json (WordPress/ipsum#235) - Remove unused values from theme.json (WordPress/ipsum#237) - Make the credit line URL translatable (WordPress/ipsum#240) - Use single border radius values in theme.json (WordPress/ipsum#236) - Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245) - Use the Site Title in Footer Centered (WordPress/ipsum#244) - Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247) - Treat "Written by" as a label before the author name (WordPress/ipsum#246) - Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232) This commit also includes changes that only exist in core: - Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles. - `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`. - A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match". Developed in: WordPress#15948 Follow-up to r65366. Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi. Fixes #66678. See #66352. git-svn-id: https://develop.svn.wordpress.org/trunk@65549 602fd350-edb4-49c9-b593-d223f7449a82

Description
Fixes #199
A comment or comment author name containing a long string with no spaces makes the whole page scroll horizontally.
bodyalready hasoverflow-wrap: break-word, but that value doesn't reduce an element's minimum width, so inside the flex layout of the comments pattern the comment box grows to fit the string.This adds
overflow-wrap: anywhereto.wp-block-comment-contentand.wp-block-comment-author-name. Unlikebreak-word,anywherecounts toward min-content width, so the box stays inside the viewport.Screenshots
Testing Instructions
Averyverylongunbrokencommentwordrepeated 8 times.Use of AI Tools