Repository navigation
Use single border radius values in theme.json - #236
Merged
Merged
Conversation
Avatar, Comment Content, Image, Post Author Name, Post Featured Image and Site Title listed the same radius for all four corners. Use the single value instead. Nothing changes visually.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
MaggieCabrera
approved these changes
Nov 16, 2026
MaggieCabrera
added a commit
to MaggieCabrera/wordpress-develop
that referenced
this pull request
Nov 16, 2026
Where all four corners had the same radius, theme.json now uses one value. Nothing changes visually, and Styles shows the radius as one linked value. Synced from WordPress/ipsum#236. See #66678. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wporg-sync
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Nov 17, 2026
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch. A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e - Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216) - Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203) - Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200) - Improve design guide defaults and schema descriptions (WordPress/ipsum#193) - Make the short post date format translatable (WordPress/ipsum#224) - Fix Details block markers being announced by screen readers (WordPress/ipsum#230) - Remove the physical left alignment from the page patterns (WordPress/ipsum#226) - Indent the navigation submenus on the inline start (WordPress/ipsum#225) - Fix accessible names for overlay navigation (WordPress/ipsum#228) - Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214) - Use a logical margin for the comment form checkbox (WordPress/ipsum#231) - Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145) - Fix accessible name of overlay search form (WordPress/ipsum#239) - Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238) - Keep the post date on one line when categories wrap (WordPress/ipsum#205) - Remove repeated button styles from theme.json (WordPress/ipsum#235) - Remove unused values from theme.json (WordPress/ipsum#237) - Make the credit line URL translatable (WordPress/ipsum#240) - Use single border radius values in theme.json (WordPress/ipsum#236) - Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245) - Use the Site Title in Footer Centered (WordPress/ipsum#244) - Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247) - Treat "Written by" as a label before the author name (WordPress/ipsum#246) - Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232) This commit also includes changes that only exist in core: - Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles. - `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`. - A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match". Developed in: #15948 Follow-up to r65366. Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi. Fixes #66678. See #66352. git-svn-id: https://develop.svn.wordpress.org/trunk@65549 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Nov 17, 2026
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch. A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e - Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216) - Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203) - Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200) - Improve design guide defaults and schema descriptions (WordPress/ipsum#193) - Make the short post date format translatable (WordPress/ipsum#224) - Fix Details block markers being announced by screen readers (WordPress/ipsum#230) - Remove the physical left alignment from the page patterns (WordPress/ipsum#226) - Indent the navigation submenus on the inline start (WordPress/ipsum#225) - Fix accessible names for overlay navigation (WordPress/ipsum#228) - Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214) - Use a logical margin for the comment form checkbox (WordPress/ipsum#231) - Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145) - Fix accessible name of overlay search form (WordPress/ipsum#239) - Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238) - Keep the post date on one line when categories wrap (WordPress/ipsum#205) - Remove repeated button styles from theme.json (WordPress/ipsum#235) - Remove unused values from theme.json (WordPress/ipsum#237) - Make the credit line URL translatable (WordPress/ipsum#240) - Use single border radius values in theme.json (WordPress/ipsum#236) - Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245) - Use the Site Title in Footer Centered (WordPress/ipsum#244) - Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247) - Treat "Written by" as a label before the author name (WordPress/ipsum#246) - Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232) This commit also includes changes that only exist in core: - Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles. - `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`. - A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match". Developed in: WordPress/wordpress-develop#15948 Follow-up to r65366. Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi. Fixes #66678. See #66352. Built from https://develop.svn.wordpress.org/trunk@65549 git-svn-id: http://core.svn.wordpress.org/trunk@64622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
arshidkv12
pushed a commit
to arshidkv12/wordpress-develop
that referenced
this pull request
Nov 21, 2026
This updates Ipsum from `bc2e5af700e28980f251d97f58cf80c72ee50a13` to `d26734ecc1ba178d9c120178ce9d2c48825fc108` on its `trunk` branch. A full list of changes included in this commit can be found on GitHub: WordPress/ipsum@bc2e5af...d26734e - Address the review notes from the 7.2 Beta 5 core commit (WordPress/ipsum#216) - Fix Pullquote custom line height not applying on the front end (WordPress/ipsum#203) - Fix horizontal scroll caused by long unbroken words in comments (WordPress/ipsum#200) - Improve design guide defaults and schema descriptions (WordPress/ipsum#193) - Make the short post date format translatable (WordPress/ipsum#224) - Fix Details block markers being announced by screen readers (WordPress/ipsum#230) - Remove the physical left alignment from the page patterns (WordPress/ipsum#226) - Indent the navigation submenus on the inline start (WordPress/ipsum#225) - Fix accessible names for overlay navigation (WordPress/ipsum#228) - Split AGENTS.md so it holds for any copy of the theme (WordPress/ipsum#214) - Use a logical margin for the comment form checkbox (WordPress/ipsum#231) - Keep keyboard focus visible and clear of the sticky header (WordPress/ipsum#145) - Fix accessible name of overlay search form (WordPress/ipsum#239) - Show a message when the blog and Archive Full have no posts (WordPress/ipsum#238) - Keep the post date on one line when categories wrap (WordPress/ipsum#205) - Remove repeated button styles from theme.json (WordPress/ipsum#235) - Remove unused values from theme.json (WordPress/ipsum#237) - Make the credit line URL translatable (WordPress/ipsum#240) - Use single border radius values in theme.json (WordPress/ipsum#236) - Escape the short post date format instead of ignoring PHPCS (WordPress/ipsum#245) - Use the Site Title in Footer Centered (WordPress/ipsum#244) - Keep AGENTS.md about the theme, not the GitHub repository (WordPress/ipsum#247) - Treat "Written by" as a label before the author name (WordPress/ipsum#246) - Use Quote blocks for statement patterns and remove text quote mark styles (WordPress/ipsum#232) This commit also includes changes that only exist in core: - Tests for the `ipsum/get-design-guide` ability are added in `tests/phpunit/tests/theme/ipsumGetDesignGuideAbility.php`, because Ipsum's repository has no PHPUnit setup. On multisite, the tests save global styles as a super admin, since only super admins can save unfiltered global styles. - `contributing.txt` says Ipsum is developed on GitHub until its 1.0 release, with contributions going through Trac after that. It also drops the note about `style.css` being used when it is newer than `style.min.css`. - A test message in `ipsumDesignGuide.php` says "do not match" instead of "to not match". Developed in: WordPress#15948 Follow-up to r65366. Props onemaggie, juanfra, shailu25, iamarinoh, 369work, gziolo, wildworks, suryakantupadhyay, khushalsains, ravipatel, meahadi. Fixes #66678. See #66352. git-svn-id: https://develop.svn.wordpress.org/trunk@65549 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Where all four corners had the same radius,
theme.jsonlisted each one. This uses the single value instead, for example"radius": "10px", on Avatar, Comment Content, Image, Post Author Name, Post Featured Image and Site Title. The output isborder-radiusinstead of four longhands, so nothing changes visually, and Styles › Blocks shows the radius as one linked value.The button's radius is handled in #235. Padding keeps its four sides, because the theme.json schema only accepts an object for
spacing.padding.Testing Instructions
Add a page with the blocks listed above. Comments need at least one comment on the page, and the Query Loop a post with a featured image.
Block markup
Compare with trunk on the front end and in the editor. The corners are unchanged: 10px on the avatar, comment content and featured image, 5px on the image, 4px on the site title and 2px on the author name.
In the Site Editor, open Styles › Blocks › Image. Radius shows one linked 5px value.
I checked this on WordPress 7.2-beta3 with Gutenberg 24.3.1, on a page with every block these changes touch: Site Title, Avatar, Post Author Name, Images (plain, Rounded style, custom radius, custom border), Post Featured Images in a Query Loop, a comment with its avatar and content, bulleted and numbered lists nested in each other and one with its own color and padding, two Calendars, paragraphs in all seven font families with bold and italic, and theme patterns that use them (header, about, gallery, kind words, bio, alternating text, two archives, footer). I compared the computed corners, borders, padding, list indents, list markers, calendar colors, fonts and the loaded font faces with trunk, on the front end and in the post editor, with the default style and each of the seven color and five typography variations. All 26 runs match. I also compared the generated global styles and
@font-facerules, where only the radius longhands change.npm run lint:themepasses.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Making the change, comparing output against trunk, and drafting this description.