Repository navigation
Closed
Labels
Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.json[Feature] Design ToolsTools that impact the appearance of blocks both to expand the number of tools and improve the experiTools that impact the appearance of blocks both to expand the number of tools and improve the experi[Type] OverviewComprehensive, high level view of an area of focus often with multiple tracking issuesComprehensive, high level view of an area of focus often with multiple tracking issues
Description
This is an overview of the concrete tasks needed to proceed with the project scope of #9534 (see also #19611). It operates on three levels, or style origins: local blocks, theme defaults, and global modifications.
First 🌊
Goal: prototype a system that connects the three style origins and demonstrates how it works for a few top-level blocks.
Infrastructure
Ensure at all times the editor reflects the front faithfully.
- Create the concept of implicit style attributes to control the appearance of the block. Common Block Functionality #15450 Introduce a support key for support global style colors in blocks #21021
- Centralize style mappings Centralize style mappings declaration #25051
- Migrate existing attributes (
font-size,color) and introduce missing properties (line-height,family). Consolidate the style attributes of blocks #22700- font-size: paragraph (Make font size an implicit attribute of the block #21153), heading (Add font size control for heading block #21431)
- line-height: paragraph (Paragraph: Add LineHeightControl + Attribute #20775), heading (Heading: Add line height support #21215)
- color: paragraph (Update the paragraph block to use the colors support key #21037), heading (Update the heading block to use the colors hook #21039)
- set colors individually block.json: set color property individually #24927
- weight Add font weight picking mechanism #24978
- family Enabling global styles to handle custom font declarations #23204
- Evolve a
theme.jsonspecification for controlling the editor and the style attributes of different origins. Document experimental theme.json #22518 Block editor: Controlling the Block Editor #20588 - Merge the different style origins (block, theme, user). Consolidate overall Global Styles mechanics in the server #20047 Manage CSS for Global Styles #20290
- Generate front-end styles using the new system. Add: Global styles css variables generation mechanism #19883
- Generate editor styles using the new system. Open up theme.json processing #22520
Interface
These are the different tools that interact with appearance values.
- Expose global styles tool in
edit-site. This should be a straightforward rendering of a sidebar in the site editor displaying the global values and palette. Add global styles sidebar at edit site screen #24250 - Allow users to modify some style attributes in the global styles panel. Global styles interface with styling for v1 #20367
- colors: link colors (link, hover / focus, active) Global styles: link color setting #21032
- typography: font families, font size, line height. Global styles: base font and scale #21030 Global styles: heading and text font families #21028 Global styles: add text styles to blocks #20773
- reset modifications to theme defaults. Global styles: resetting #20868
- Develop interface components to operate with new attributes. Prior art in font sizes and color panel. Global styles interface with styling for v1 #20367
- line-height to Paragraph and Heading inspectors. Explore adding line height to paragraph and heading blocks #20339
Second 🌊
Goal: develop all necessary sub-systems.
Infrastructure
- Stabilize:
- (one pr remaining to merge) Client: review there's no duplication and improve the way metadata is structured.
- Server-client metadata: do not send data we already have Reduce the amount of data Global Styles sends to the client #26802
- Server: consolidate theme.json entity Reduce the amount of data Global Styles sends to the client #26802
- Server: consolidate theme.json processor Update mechanism that resolves Global Styles data #27237
-
Prepare a core patch for 5.7 (closed)Global Styles in WordPress 5.7 #27506
- theme.json
- Consolidate dynamic selectors (selectors for blocks that represent multiple HTML elements, such as heading or list). Try new syntax for dynamic selectors #24423 Add: Mechanism to detect if a block instance matches a global styles selector #26945
-
Control design tools visibility (superseded)Controlling design tools visibility #27295 - Make settings & styles top-level keys Updates to experimental-theme.json #28163
- Split
globalselector intodefaultsandrootUpdate theme.json: split global block selector into root and defaults #28533
/24165.
- Style properties
- font-style Block Support: Add font style and weight options with combined UI #26444 Block Support: Separate opt in for font style and weight options #26844
- font-weight Block Support: Add font style and weight options with combined UI #26444 Block Support: Separate opt in for font style and weight options #26844
- text-decoration Block Support: Add text decoration block support using CSS variables #26059
- text-transform Block Support: Add text transform block support using CSS variables #26060
- Padding (global UI + theme.json) Global Styles: update metadata and add support for padding #27099 Add padding control to the Global Styles sidebar #27154
- border-radius Block Support: Add border radius support #25791
- Presets
- Make them translatable via theme.json Extract translatable strings from theme.json files wp-cli/i18n-command#224 Global Styles: Use context when translating entries in theme.json #28246
- Allow creating presets in contexts other than
global. Automatically generate required preset classes #25768 - Allow creating user-defined color palettes. Update: Restrict edition of theme colors by users. #27250
- Allow presets to use other preset variables Preset controls need the preset CSS variables in scope #26511
Interface
- Make editor controls reflect styles, whether they come from theme or user. Add color reference mechanism #21490 Add link color component #22722 Global Styles Color Palette editor default to theme/core pallete. #26783 Update: Use theme and core styles as defaults on the global styles #26786
- Reset to theme defaults Global Styles: Add button to reset color palette #26975
Third 🌊
Goal: merge the non UI parts of global styles in WordPress 5.8.
block.json / block supports:
- Next iteration of block supports mechanism #28913 Add support for skip serialization to all properties. Core blocks can be migrated iteratively.
- Support for border properties #29616
border-width,border-style,border-color - Add a layout config to the group and theme.json and make alignments declarative #29335 Alignments
- Link Color: substitute the CSS Custom Property by the mechanism used in layout and duotone #31488 link color: make it work like layout or duotone. Link color doesn't work for author role #25151 Will also fix link color for author roles.
theme.json:
- Changes to theme.json #29891 Changes to theme.json
- Versioning theme.json from the theme, implemented as part of Update shape of theme.json #30541
- Default Colors, Theme Colors, and Custom Colors #29568 colors: allow having defaults, theme, and custom
- Custom controls, block supports, and theme.json #29778 Theme authors should be able to use any styles in theme.json independently from the block.json support.
- Make theme.json cross-platform (web & mobile) #24165 Mobile: confirm there are not blockers to make theme.json cross-platform (web & mobile).
- FSE: theme data for Global Styles and Templates #30191 Use
wp_themetaxonomy instead of post_name to associate user styles with particular themes.
Internationalization:
- Themes: Translate custom templates in theme.json #29828 theme.json: customTemplates.
- block supports: allow changing UI control labels Color controls: take labels from block supports #29155 (discarded, instead we rephrased the labels to be more adequate for different contexts) Inspector Controls: Rephrase, polish, and make consistent color labels. #30075
Docs:
- Update theme.json docs to make clear what's part of WordPress 5.8 and what's part of the plugin. Update
theme.jsondocs for WordPress 5.8 #33131 - Update theme support docs to state that link color is now stable and part of Wordpress core, using
theme.json. Theexperimental-link-colortheme support will be deprecated and removed when the plugin requires WordPress 5.8 as the minimum version. Update documentation for link color in WordPress 5.8 #33162 - Update docs for block supports, including a note about
__experimentalSkipSerialization.
Extensibility:
- Add extensibility hooks to global styles infrastructure #27504 Hooking into the lifecycle of GS: stabilize API and define what sort of hooks do we need.
- How to filter block_editor_settings & global styles settings #30082 Block editor settings & global styles settings.
Bug fixes
- Disable/Enable custom colors, gradients, and font sizes Fix: Logic to enable custom colors, gradients, and font sizes. #32200
- Empty color palette should disable the feature Fix: Allow themes to disable the color and gradients palette. #32225 Enqueue core and theme colors by using separate structures per origin. #32358
-
settings.colorno longer have the theme colors Theme's color palette no longer returned via Block Editor settings #32027 Enqueue core and theme colors by using separate structures per origin. #32358 - Block presets generate incorrect styles Theme.json: Incorrect selectors are used when color palettes are added to blocks #31660
Fourth 🌊
Follow-ups to WordPress 5.8 release.
Block supports:
theme.json:
- Allow disabling
textandbackgroundcolor viatheme.json#34414 - theme.json v2: track changes #34349
- Improve the way we handle custom units and how we interact with themes config. #33470
- Add a setting to opt-out of block templates using theme.json #33500
- Allow filtering the alignment options of blocks via
theme.json#34317 - Disable the wide width control if the theme does not provide a
layout.wideWidthvalue #34507
Stylesheet:
Performance:
- Make the global stylesheet available for all themes #34328
- Only ship default presets once:
- Theme.json: Block specific CSS is printed even if a block is not used on the current page #31642
- Use Global Styles or
theme.jsonto style individual blocks #33977 - Track changes in the size of the global stylesheet #34329
Interface
Backlog
The things listed here don't need to be necessarily implemented, but should be considered.
block.json: nothing planned
- Spacer Block: Allow themes to define a default value theme.json #27614 Potential use case to add height (spacer and cover, which has a custom one at the moment).
theme.json
- Explore block style variations as packages of style attributes #33232 See also the use case for margin
- Versioning theme.json data from the user Handle an evolving theme.json shape (consider add versioning). #27230 (comment)
- Consider a standardized way to modify hover/focus/active states for blocks Consider a standardized way to modify hover/focus/active states for blocks #27075
- Allow all block-editor theme support options to be defined via theme.json Allow all Gutenberg theme support options to be defined in theme.json #26901
- Consider allowing themes to enqueue stylesheets in theme.json Consider allowing themes to enqueue stylesheets in theme.json #26902
- How to express nested content
- Use a flat structure of selectors
core/group core/paragraph. Updates to experimental-theme.json #28163 - We could have separate files for template parts (in addition to the theme.json for the site or main "document", see Global Styles: composable styles for different contexts #27233
- We could create CSS vars for container blocks Global Styles: Add CSS vars for root level settings #29714 (comment)
- Use a flat structure of selectors
- Do we need to support dynamic values that change depending on other values? Example for colors theme.json: change text colors depending on background #24166
- Consolidate block attributes, block supports, and theme.json shape Block API: explore aligning block attributes, block supports, and theme.json shape #22887
- Schema and type validation Add type validation and/or theme.json schema #26955
- Allow CSS properties that we don't manage? Global Styles: Should we Allow CSS properties that we don't manage at the moment? #27231
- Responsive styles/media queries (styles depending on window size). Responsive Global Styles #20244
- Define if global attributes (base
font,color, pagebackground) can be conceptualized as attributes of a root Site block. [Explore] Site Block #16998 Related: consider global site width and padding Explore adding site width and padding to global styles #20771
Expand to more style properties:
- text alignment Provide a way to remove/modify text alignment for core blocks #24616
heightSeparator: Add means to control height #28409marginCustom Margin/Padding to column block #25988widthAdd width to setting and styles #31037- Free-form custom CSS area. Consider whether this should be per-block as in Add Custom CSS support to the Group block #25413 or global to all of them?
- API for loading font families. This should be inherently extensible and likely unopinionated. Maybe explore an API like
wp_register_font_family. - Justified text Allow making text flushed left or justified #27300
Extensibility:
- Support for child themes FSE: support for child themes #25612
- Export
theme.jsonconfigs (including user preferences) as part of exporting templates & template parts Exporting Block Themes and Styles #27941 Site Editor: Export global style settings #27528 - UI extensibility: allow 3rd parties to hook into it, etc.
Interface:
- Global styles sidebar: labels for panels in the global styles sidebar (the subtitle of the "headings" panel, for example, "Headings (h1)", is taken from the
__experimentalSelectorof the heading block). How is this in the new UI? - Integrate new component system Component System: Continue Integration #28399 https://status.g2-components.com/
- Do not show-sidebar if the theme doesn't have theme.json support Do not show the Global Styles sidebar in edit site if theme doesn't support theme.json #27394
- Custom controls for the Global Styles sidebar. Custom controls, block supports, and theme.json #29778
- Themes can control the visibility of UI controls. Relates to sidebars Sidebar Controls & Component System #27331 and the old proposal to control visibility Controlling design tools visibility #27295 If something is disabled via theme.json it should be disabled for both the global styles and the block sidebar.
- Blue dot on block panels that have modifications Blue dot on block panels that have modifications #27474
- Flow for editing the specific styles of a specific block type Flow for editing the styles of a specific block type #27393
- Advanced panels of blocks should show which Global Styles are affecting it Advanced panels of blocks should show which Global Styles are affecting it #27475
- Exploring beyond a sidebar for exposing styling tools Exploring beyond a sidebar for exposing styling tools #20212
- Explore combining all style-related attributes of a block into a "Style" tab in the inspector separate from "Settings".
- Explore a way to lift local modifications on blocks to global (apply certain modifications to all paragraphs or to all blocks that consume an attribute).
- Explore if it's needed to show locally on blocks when they are inheriting from a global or theme setting.
- Allow granular saving options Site Editor: Offer more granular information in multi-entity saving flow #29388
Iterate on design tools:
- Add background editing tools to Cover. Background Editor for Cover block #20193
- Add spacing control to Gallery. Add a way to control spacing between gallery images #20705
- Establish background tools components hooked to the relevant attributes. Make "Background Tools" an easy API and add to Group / Columns #16479
- Look at how to absorb units for font-size How to absorb font size units #25137 Add relative units for font size option #23323
Misc:
- Try using transient attributes on global styles entity Try using transient attributes on global styles entity #25138
- Dark mode: editor Improve editor UI on dark backgrounds #28200 authors Discussion:
prefers-color-schememedia-query #24368 - Do not create revisions for the CPT used by global styles Do not create revisions for the GlobalStyles CustomPostType #30132
Reacted by Nick Cernis, Tammie Lister, Q, Phil Johnston, Miguel Fonseca, Kjell Reigstad, Ballio Chan, Sören Wünsch, Greg Ziółkowski, Rich Tabor and 12 more
Metadata
Metadata
Assignees
Labels
Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.jsonAnything related to the broader Global Styles efforts, including Styles Engine and theme.json[Feature] Design ToolsTools that impact the appearance of blocks both to expand the number of tools and improve the experiTools that impact the appearance of blocks both to expand the number of tools and improve the experi[Type] OverviewComprehensive, high level view of an area of focus often with multiple tracking issuesComprehensive, high level view of an area of focus often with multiple tracking issues

Activity
jorgefilipecosta commentedon May 7, 2020
Sharing some thoughts on the current status for infrastructure/ my interpretation of some infrastructure tasks:
It seems the style attribute we are using for colors introduced in #21021 addressed this part we are also using it for lineHeight with success and without the need to register new attributes.
It seems this is about making sure styles are regenerated when the structure that holds global style changes. For example, #20530 accomplishes this by compiling the styles on GlobalStylesProvider.
We can achieve this by adding a styles structure to theme.json:
We may also achieve the "Custom User Styles" part of #7551 by just allowing the user to save the current block style attributes as a customization of the theme.json structure.
kjellr commentedon Oct 9, 2020
At this week's Block-based Themes meeting, the group discussed some of the upcoming design tools in this ticket, and whether they should be opt-in or opt-out for themes. Here are our notes:
theme.json, it seems ok to have all new design tools be opt-out.add_theme_support()for them.More details in the meeting notes.
jorgefilipecosta commentedon Nov 23, 2020
With the first beta version of WordPress 5.7 not very far away I'm sharing this summary after some discussion with @nosolosw specifying what are the tasks we think should be part of v1 and/or that may be part of v1.
What we will do next?
These are the tasks we will work on and plan to have ready soon. Are the most prioritary tasks.
Versioning. Handle an evolving theme.json shape (consider add versioning). #27230
Child theme support. FSE: support for child themes #25612
(In progress) Padding support on global styles. Add padding control to the Global Styles sidebar #27154
(In progress) Refactor our code and merge it into the core. A PR that started the refactoring Extract theme json processor #26803.
(In progress) Improve the way client-side metadata is structured, make sure it matches server metadata shape, and try to avoid metadata duplication. Try using transient attributes on global styles entity #25138
Update KSES to accept our link color styles. Link color doesn't work for author role #25151 Revive: Fix link color for roles without unfiltered_html capabilities #25411
(In progress) Expose a structure in the core that wp-cli can use to know what theme.json strings are translatable. Extract translatable strings from theme.json files wp-cli/i18n-command#224
Discuss mobile support #24165 and have some double-checking if the current theme.json functionality can work well on mobile.
What we can do next?
Tasks we can work on, it would be nice to have but are not a must and are lower priority may or may not be part of v1.
Things for the future
Not part of a first version. Things we may consider in the future.
Nested styles for semantic contexts. For example, apply a specific base font size for things inside a sidebar. Global Styles: composable styles for different contexts #27233
Allow CSS properties that we don't manage at the moment. E.g: apply a specific CSS property like textShadow. Global Styles: Should we Allow CSS properties that we don't manage at the moment? #27231
Related tasks but that initially will not use theme.json/global styles mechanisms.
Look into the alignment issues FSE: Provide a way for Gutenberg to provide alignment styles for the front end. #26633
Responsive styles/media queries (styles depending on window size). Responsive Global Styles #20244
What decisions do we need to do?
What’s next on the UI/UX side?
The first beta of WordPress 5.7 goes out in January, so we need to have a v1 for the UI ready sometime before the first beta.
Typography tools are going to be g2 based (or at least some parts like font size control). So we need to merge (at least parts of) g2 in order to have the typography tools ready.
Extensibility mechanism for 3rd party
It seems the global styles although functional does not provide a good experience, panels inside panels, a gigantic list of panels (one per each block). What is the plan for the other parts of UI? What are the things we should improve on the UI of these other parts to make them ready for the first version?
Navigation between all the different blocks that we can apply global styles to and between the global context.
Color options (text, background, and link).
Color palette editor.
cc: @nosolosw, @shaunandrews, @jasmussen, @ItsJonQ, @mcsf, @youknowriad
youknowriad commentedon Nov 24, 2020
Thanks for the summary @jorgefilipecosta here's the questions/feedback I have:
Shooting for consistency between client and server consistency is not always good thing. It's better to think of client packages as their own unit in isolation. Sometimes the config that the server has does make sense in the context of a package, sometimes it doesn't. Semantics > consistency. Just something to keep in mind while designing the APIs of the client.
this is also something I've been thinking of, It's not clear whether I'll have the time to look deeper into it but keep me on the loop. My idea is to first make InnerBlocks provide an API to define the alignments and output the CSS for it without relying on themes to provide that CSS. Once we have that, adding support for this into theme.json is easy.
Same here, I wonder if we should start at the block level IMO and see what makes sense as a "style" attribute, and what make sense as UI and expand to theme.json
I still feel this is the missing piece in terms of features.
I see the current "global" config as a way to define a config for all blocks but not as a way to define what UI is available in the global styles panel.
aristath commentedon Nov 24, 2020
Thank you @jorgefilipecosta, that comment offers a great overview and sums up pretty nicely where we're going. ❤️
Are all items in separate issues already? The comment will be lost in all the noise, so should we create issues for any items on that list (or maybe just tag existing issues properly so they're easier to find)?
francescamarano commentedon Nov 24, 2020
I second @aristath comment. It would also be great to see them in the FSE project so it's easy to track things visually. And make liberal use of tags, so people can work on priorities. Thanks!
jorgefilipecosta commentedon Nov 24, 2020
Hi @youknowriad,
Regarding alignment issues and responsive styles, I agree with you. These things should be solved at the block level without touching global style mechanics, at least initially. I moved them to a new section, called "Related tasks but that initially will not use theme.json/global styles mechanisms.".
Currently, the global config is a way to define what UI is available at the global styles panel. The other blocks inherit it if they don't have a specific config for them.
Basically, before global styles, one could not have control if a feature is enabled or disabled in a specific block. Our API changed that. With our new API, one can also specify if things in a particular block (or even in blocks with specific attributes) are available or not and overwrite what was defined globally. Our API just added block-level controls, but we don't have things like selectors that select multiple blocks, etc., ways to disable inheritance, etc. Themes always need to select each block individually.
We don't the concept of "main color". The user can edit, text color, background color, and link color, at the global level and at the level of blocks that support these colors. One can't enable text color but disable background color. All the colors are either enabled or disabled.
Besides that, the user can change the color presets, and if there is a color like "primary" used in multiple places, the user changing the preset will change the color in multiple places. It is not possible to say only this preset is editable. Do you think we should change some of these in the first version?
The current API does not offer a way to select all the blocks. Achieving this would require to enable line-height at the global level, and then explicitly disable it for all the block contexts. I guess it could be done using a PHP filter that loops through all the selectors and injects the setting to disable line-height keeping it enabled for the global context, which is not ideal.
I see two options to achieve:
None of these options seem good. Do you have a different idea in mind?
There is a tradeoff between supporting more use cases and making theme.json structure and the engine implementing these rules more complex. I think in a declarative approach, there will always be things that will not be possible to achieve and we should draw a line. I guess we need to decide between what we allow and what we don't allow, and make any required engine updates as soon as possible.
Do you think there is a simple theme.json change we can make that would allow the use cases you referred? Are there other use cases besides the ones you already referred that you think should be possible?
Thank you a lot for looking into this and sharing your insights/questions!
jorgefilipecosta commentedon Nov 24, 2020
Hi @aristath, @francescamarano,
Thank you for your comments! To make things easier to navigate, I updated the comment linking to the issues/PR's and also added more prioritary issues to the Full Site Editing board.
youknowriad commentedon Nov 24, 2020
And I'm saying it shouldn't be the case, we should have two distinct things (both in theme.json):
(maybe a "global"l key and a "UI" or "*" and "global" or something like that)
These things should be different. Once they are, the use-cases I shared will be solved.
When I was referring to "main" color, for me this was just a custom CSS variable editable on the global styles UI and that you can use as a value of of the palette colors or not, you can also just use it to style some blocks in theme.json directly. (provide default values)
cliffordp commentedon Nov 24, 2020
Just chiming in to say https://wordpress.org/plugins/kt-tinymce-color-grid/ is an excellent plugin that works for Classic, Block, and Customizer. It adds CSS variables with the name you choose for each color (e.g. brand-main, brand-secondary, brand-accent, sheepish-white, creamy-gray, deep taupe), and it has import/export functionality.
I hope it can inspire.
jorgefilipecosta commentedon Nov 25, 2020
Hi @youknowriad, thank you for clarifying your thoughts.
I guess we can accomplish these requirements in two possible ways:
Two selectors a "" selector that is inherited by every context (including the global one). Equivalent to our current "global". A global context that just affects the global panel and is not inherited. There is no explicit inheritance of styles so styles would still be defined on "global". "" Selector would just support settings which is the only place where we are inhering things right now.
Keeping everything as it is, but add a new special settings only context called "global-panel". This panel just affects global context settings without any inheritance. On the global context, if this context contains settings it overwrites what was defined in global.
Do you think these solutions are acceptable? Do you have any preferences? Also cc: @nosolosw, in case you have some thoughts.
Well, one can edit presets, they are variables. One can have a preset called the main color. Editing that preset would be equivalent to edit a variable used all around the site.
But besides the color presets, and, the link color (which is also a CSS variable), there are no plans as part of Global Styles V1 to have a mechanism that allows someone to expose a UI in the global styles panel that allows controlling the value of a CSS variable. Do you think need to have for V1 something that allows controlling custom CSS variables (besides color presets and link color)?
jorgefilipecosta commentedon Nov 25, 2020
Hi @cliffordp,
Thank you for bringing this plugin to our attention. It has considerable usage, which means users really want the power of changing color palettes and things like that, so it reinforces that we are working on something relevant.
It is also a good test case to make sure what we are doing is back-compatible and does not breaks plugins. E.g: that plugin should still work and the colors users apply with it should still be applied on global styles (unless the user then changes the colors on global styles).
10 remaining items
oandregal commentedon Mar 24, 2021
This week in global styles:
Ongoing/Next tasks necessary for MVP:
And more:
oandregal commentedon Mar 24, 2021
Just added #30191 to the list as well (under the theme.json group).
oandregal commentedon Mar 31, 2021
This week's status report: ongoing work for the major tasks necessary for the MVP.
oandregal commentedon Apr 7, 2021
This week's status report:
Shipped
Block Supports: added a
gutenberg_block_has_supporthelper function and support for padding in dynamic blocks 30322, border for search block Search Block: Add border radius support using skip serialization feature #30227Fixes: title in the save panel of the site editor 30521, fix for themes without theme.json support but with experimental link color support 30452
Ongoing
Block supports:
Theme.json
oandregal commentedon Apr 14, 2021
This week in global styles:
Landed
Parts of theme.json with elements Changes to theme.json #29891
theme.json#30604block supports
Ongoing
theme.json with elements Changes to theme.json #29891
bugfixes Global Styles: clean cached data when switching themes #30830
block supports: add new style properties: border-color, border-styles, border-width Block Supports: Add border color, style and width support #30124
oandregal commentedon Apr 21, 2021
This week in global styles:
Landed
theme.json with elements #29891
Block Supports & theme.json properties:
Bugfixes, code quality
Ongoing
theme.json with elements #29891
Block Supports:
Bugfixes:
safecss_filter_attr()#30888Priorities
The priority continues to be shipping #29891 as soon as possible to unblock related work.
#28913 is a good issue to look at if you can lend a hand (help with reviews, migrate more blocks, more properties, etc).
oandregal commentedon Apr 28, 2021
Weekly status report for core-editor meeting.
Shipped this week
theme.json
block.json / block supports
Internationalization
KSES
safecss_filter_attr()#30888Site editor:
Ongoing
theme.json
block.json / block supports
New style properties
Misc
Priorities
The priority continues to be shipping #29891 as soon as possible to unblock related work.
#28913 is a good issue to look at if you can lend a hand (help with reviews, migrate more blocks, more properties, etc).
oandregal commentedon May 5, 2021
Status report for core-editor meeting.
Shipped this week:
block.json / block supports:
theme.json
bodyselector instead of:rootUpdate: Target global styles to the body element instead of :root #31302Extensibility:
block_editor_settings_allfilter Plugin: Call deprecated hooks only when new filters not present #31027Site editor:
Ongoing:
block.json / block supports:
theme.json
Priorities
After having landed #29891 via #30541 the priority is to tie up the loose ends before preparing the core patch for 5.8.
Worth highlighting is that there're two new issues to switching away from CSS Custom Properties for link #31488 and font-family #31489 (see rationale in each issue).
oandregal commentedon May 12, 2021
This week report for core-editor.
Shipped this week
block supports
useEditorFeaturetouseSettingRename and stabilize useEditorFeature as useSetting #31587theme.json
experimental-theme.jsontotheme.jsonRename experimental-theme.json to theme.json and add a fallback for backwards-compatibility #29981get_merged_dataAPI so it requires less knowledge from the consumer #31552 Chore: remove unused code #31666 Chore: Remove declarations so API has coherence #31596 Chore: Remove: Declarations parameter from compute_style_properties #31573site editor:
Ongoing
block supports:
theme.json
Priorities
Start the merge process for theme.json APIs.
oandregal commentedon May 19, 2021
Status report (core-editor):
This week's focus was on getting things ready for Gutenberg 10.7 (landed most of the things we needed, there are a couple in flight) and start the merge process in core (got an initial PR for this).
Shipped this week
block supports:
settings:
Ongoing
block supports:
theme.json
core merge
__experimentalFeaturesdata for the block editor wordpress-develop#1262Priorities
Merge process for theme.json APIS in core.
oandregal commentedon May 26, 2021
Status Report (core-editor meeting).
Global Styles and Global Settings have been ported to WordPress core and will be part of the WordPress 5.8 release. The focus now is on polishing and fixing bugs as we find them. The issue description & tasks have been triaged and there're two new sections: "bugfixes" and "docs" with tasks to be worked on in the upcoming weeks.
Now that the 1.0 version of this feature has been shipped and we need to revisit focuses, I thought it'd be a good time to pause these reports while we figure out the next steps. Anything relevant should still be posted here but on an on-demand basis not weekly.
Supported settings & styles that landed core
There's a task above to update this in the docs but wanted to share what we have now.
theme.jsonsupport.color.custom,color.customGradient,typography.customFontSize,typography.dropCap. Settings that are disabled by default arespacing.customMargin,spacing.customPadding,typography.lineHeight. Units can be filtered.add_theme_support('experimental-link-color'). It seems that we can keep it in the plugin and remove it when the minimum WordPress version is 5.8.Shipped this week
Port to core:
Block Supports:
theme.json
Misc:
theme.jsonexamples copy-pasteable #32040oandregal commentedon Dec 21, 2021
We're shipping a first version of the GS interface in 5.9, so it looks like this issue could be closed. Both for having a sense of progress but also because the activity has already moved to other smaller and more focused issues (designer tools, site editor improvements, framework changes, etc).
oandregal commentedon Dec 21, 2021
I've created #37550 to track some gaps we still have from the original vision of styles at the framework level.
mtias commentedon Dec 21, 2021
Really wonderful work and progress here!