Repository navigation
Margin Support: Fix custom units - #31776
Merged
Merged
Conversation
|
Size Change: +57 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
May 13, 2021
glendaviesnz
approved these changes
May 13, 2021
glendaviesnz
left a comment
Contributor
There was a problem hiding this comment.
This worked as advertised for me. With patch applied I was able to switch units on the margin control, and selected units were applied in the frontend
75 of 82 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This introduces the same fix for custom units as for padding support. Prior to this change it was not possible to select non-pixel units in the margin block support box control.
How has this been tested?
Manually.
Screenshots
Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).