Repository navigation
Spacing support: Add server-side support for margins - #31808
Merged
aaronrobertshaw merged 1 commit intoMay 17, 2021
Merged
aaronrobertshaw merged 1 commit into
aaronrobertshaw merged 1 commit into
Conversation
7 tasks
carolinan
approved these changes
May 14, 2021
carolinan
left a comment
Contributor
There was a problem hiding this comment.
The example theme.json code above also need to include "customMargin": true,.
With that and the PR, the margin that is not reset by the layout setting works well on the font.
apeatling
self-requested a review
May 14, 2021 21:04
aaronrobertshaw
self-requested a review
May 17, 2021 06:52
aaronrobertshaw
approved these changes
May 17, 2021
aaronrobertshaw
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this missed functionality 🙇
This tests well for me both in the editor and frontend.
The e2e test failures looked unrelated. After re-running them everything passes. I'll merge this shortly.
75 of 82 tasks
13 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the margin block support on the server-side allowing dynamic blocks to use it. The existing
padding.phpblock support file is renamed tospacingto reflect the existing block support's structure.How has this been tested?
Testing instructions
Your theme will need to opt into padding support. You can do this by updating your
theme.jsonto enable padding under the spacing control, in either your default settings or the block context for button:I used the Site Title block for testing, as it supports both margin and padding on trunk.
Test Instructions
You can verify the bug first on trunk by:
Test the PR:
**Note that if added as a top-level block, left and right margins may be overridden by the
!importantstyles from the layout block support. You should still be able to see the styles added.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).