Skip to content

Inspector Controls: Rephrase, polish, and make consistent color labels. - #30075

Merged
hypest merged 2 commits into
trunkfrom
try/fix-social-links-labels
Apr 15, 2021
Merged

hypest merged 2 commits into
trunkfrom
try/fix-social-links-labels

Conversation

@jasmussen

@jasmussen jasmussen commented Mar 22, 2021 •

Copy link
Copy Markdown
Contributor

Description

Color panel labels are a bit of a mix across panels and even across web and mobile. This PR attempts to clean it up.

Before:

Screenshot 2021-03-22 at 08 17 21

Screenshot 2021-03-22 at 08 17 29

After:

Screenshot 2021-03-22 at 08 19 45

Screenshot 2021-03-22 at 08 20 58

The motivation here is that the "settings" part of "Color settings" is reduntant information, and that we use sentence case for labels everywhere else.

Types of changes

  • Color settings → Color
  • Text Color → Text color
  • Background Color → Background color
  • Icon background color → Background color

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@jasmussen jasmussen added the [Feature] Inspector Controls The interface showing block settings and the controls available for each block label Mar 22, 2021
@jasmussen jasmussen self-assigned this Mar 22, 2021
@github-actions

github-actions Bot commented Mar 22, 2021 •

Copy link
Copy Markdown

Size Change: -6 B (0%)

Total Size: 1.41 MB

Filename Size Change
build/block-editor/index.js 127 kB -3 B (0%)
build/block-library/index.js 148 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.77 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 664 B 0 B
build/block-directory/index.js 8.63 kB 0 B
build/block-directory/style-rtl.css 1 kB 0 B
build/block-directory/style.css 1.01 kB 0 B
build/block-editor/style-rtl.css 12.4 kB 0 B
build/block-editor/style.css 12.4 kB 0 B
build/block-library/blocks/archives/editor-rtl.css 61 B 0 B
build/block-library/blocks/archives/editor.css 60 B 0 B
build/block-library/blocks/audio/editor-rtl.css 58 B 0 B
build/block-library/blocks/audio/editor.css 58 B 0 B
build/block-library/blocks/audio/style-rtl.css 112 B 0 B
build/block-library/blocks/audio/style.css 112 B 0 B
build/block-library/blocks/block/editor-rtl.css 161 B 0 B
build/block-library/blocks/block/editor.css 161 B 0 B
build/block-library/blocks/button/editor-rtl.css 475 B 0 B
build/block-library/blocks/button/editor.css 474 B 0 B
build/block-library/blocks/button/style-rtl.css 479 B 0 B
build/block-library/blocks/button/style.css 479 B 0 B
build/block-library/blocks/buttons/editor-rtl.css 315 B 0 B
build/block-library/blocks/buttons/editor.css 315 B 0 B
build/block-library/blocks/buttons/style-rtl.css 364 B 0 B
build/block-library/blocks/buttons/style.css 363 B 0 B
build/block-library/blocks/calendar/style-rtl.css 208 B 0 B
build/block-library/blocks/calendar/style.css 208 B 0 B
build/block-library/blocks/categories/editor-rtl.css 84 B 0 B
build/block-library/blocks/categories/editor.css 83 B 0 B
build/block-library/blocks/categories/style-rtl.css 79 B 0 B
build/block-library/blocks/categories/style.css 79 B 0 B
build/block-library/blocks/code/style-rtl.css 90 B 0 B
build/block-library/blocks/code/style.css 90 B 0 B
build/block-library/blocks/columns/editor-rtl.css 190 B 0 B
build/block-library/blocks/columns/editor.css 190 B 0 B
build/block-library/blocks/columns/style-rtl.css 421 B 0 B
build/block-library/blocks/columns/style.css 421 B 0 B
build/block-library/blocks/cover/editor-rtl.css 605 B 0 B
build/block-library/blocks/cover/editor.css 605 B 0 B
build/block-library/blocks/cover/style-rtl.css 1.24 kB 0 B
build/block-library/blocks/cover/style.css 1.24 kB 0 B
build/block-library/blocks/embed/editor-rtl.css 486 B 0 B
build/block-library/blocks/embed/editor.css 486 B 0 B
build/block-library/blocks/embed/style-rtl.css 401 B 0 B
build/block-library/blocks/embed/style.css 400 B 0 B
build/block-library/blocks/file/editor-rtl.css 199 B 0 B
build/block-library/blocks/file/editor.css 198 B 0 B
build/block-library/blocks/file/style-rtl.css 248 B 0 B
build/block-library/blocks/file/style.css 248 B 0 B
build/block-library/blocks/freeform/editor-rtl.css 2.46 kB 0 B
build/block-library/blocks/freeform/editor.css 2.46 kB 0 B
build/block-library/blocks/gallery/editor-rtl.css 704 B 0 B
build/block-library/blocks/gallery/editor.css 705 B 0 B
build/block-library/blocks/gallery/style-rtl.css 1.11 kB 0 B
build/block-library/blocks/gallery/style.css 1.1 kB 0 B
build/block-library/blocks/group/editor-rtl.css 160 B 0 B
build/block-library/blocks/group/editor.css 160 B 0 B
build/block-library/blocks/group/style-rtl.css 57 B 0 B
build/block-library/blocks/group/style.css 57 B 0 B
build/block-library/blocks/heading/editor-rtl.css 129 B 0 B
build/block-library/blocks/heading/editor.css 129 B 0 B
build/block-library/blocks/heading/style-rtl.css 76 B 0 B
build/block-library/blocks/heading/style.css 76 B 0 B
build/block-library/blocks/html/editor-rtl.css 281 B 0 B
build/block-library/blocks/html/editor.css 281 B 0 B
build/block-library/blocks/image/editor-rtl.css 717 B 0 B
build/block-library/blocks/image/editor.css 716 B 0 B
build/block-library/blocks/image/style-rtl.css 476 B 0 B
build/block-library/blocks/image/style.css 478 B 0 B
build/block-library/blocks/latest-comments/editor-rtl.css 159 B 0 B
build/block-library/blocks/latest-comments/editor.css 158 B 0 B
build/block-library/blocks/latest-comments/style-rtl.css 269 B 0 B
build/block-library/blocks/latest-comments/style.css 269 B 0 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B 0 B
build/block-library/blocks/latest-posts/editor.css 137 B 0 B
build/block-library/blocks/latest-posts/style-rtl.css 523 B 0 B
build/block-library/blocks/latest-posts/style.css 522 B 0 B
build/block-library/blocks/list/editor-rtl.css 65 B 0 B
build/block-library/blocks/list/editor.css 65 B 0 B
build/block-library/blocks/list/style-rtl.css 63 B 0 B
build/block-library/blocks/list/style.css 63 B 0 B
build/block-library/blocks/media-text/editor-rtl.css 191 B 0 B
build/block-library/blocks/media-text/editor.css 191 B 0 B
build/block-library/blocks/media-text/style-rtl.css 535 B 0 B
build/block-library/blocks/media-text/style.css 532 B 0 B
build/block-library/blocks/more/editor-rtl.css 434 B 0 B
build/block-library/blocks/more/editor.css 434 B 0 B
build/block-library/blocks/navigation-link/editor-rtl.css 626 B 0 B
build/block-library/blocks/navigation-link/editor.css 627 B 0 B
build/block-library/blocks/navigation-link/style-rtl.css 685 B 0 B
build/block-library/blocks/navigation-link/style.css 682 B 0 B
build/block-library/blocks/navigation/editor-rtl.css 1.11 kB 0 B
build/block-library/blocks/navigation/editor.css 1.11 kB 0 B
build/block-library/blocks/navigation/style-rtl.css 204 B 0 B
build/block-library/blocks/navigation/style.css 205 B 0 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B 0 B
build/block-library/blocks/nextpage/editor.css 395 B 0 B
build/block-library/blocks/page-list/editor-rtl.css 170 B 0 B
build/block-library/blocks/page-list/editor.css 170 B 0 B
build/block-library/blocks/page-list/style-rtl.css 537 B 0 B
build/block-library/blocks/page-list/style.css 536 B 0 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B 0 B
build/block-library/blocks/paragraph/editor.css 157 B 0 B
build/block-library/blocks/paragraph/style-rtl.css 247 B 0 B
build/block-library/blocks/paragraph/style.css 248 B 0 B
build/block-library/blocks/post-author/editor-rtl.css 209 B 0 B
build/block-library/blocks/post-author/editor.css 209 B 0 B
build/block-library/blocks/post-author/style-rtl.css 183 B 0 B
build/block-library/blocks/post-author/style.css 184 B 0 B
build/block-library/blocks/post-comments-form/style-rtl.css 250 B 0 B
build/block-library/blocks/post-comments-form/style.css 250 B 0 B
build/block-library/blocks/post-content/editor-rtl.css 139 B 0 B
build/block-library/blocks/post-content/editor.css 139 B 0 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B 0 B
build/block-library/blocks/post-excerpt/editor.css 73 B 0 B
build/block-library/blocks/post-featured-image/editor-rtl.css 338 B 0 B
build/block-library/blocks/post-featured-image/editor.css 338 B 0 B
build/block-library/blocks/post-featured-image/style-rtl.css 100 B 0 B
build/block-library/blocks/post-featured-image/style.css 100 B 0 B
build/block-library/blocks/preformatted/style-rtl.css 63 B 0 B
build/block-library/blocks/preformatted/style.css 63 B 0 B
build/block-library/blocks/pullquote/editor-rtl.css 183 B 0 B
build/block-library/blocks/pullquote/editor.css 183 B 0 B
build/block-library/blocks/pullquote/style-rtl.css 318 B 0 B
build/block-library/blocks/pullquote/style.css 318 B 0 B
build/block-library/blocks/query-loop/editor-rtl.css 90 B 0 B
build/block-library/blocks/query-loop/editor.css 89 B 0 B
build/block-library/blocks/query-loop/style-rtl.css 315 B 0 B
build/block-library/blocks/query-loop/style.css 317 B 0 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B 0 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B 0 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B 0 B
build/block-library/blocks/query-pagination/editor.css 262 B 0 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B 0 B
build/block-library/blocks/query-pagination/style.css 168 B 0 B
build/block-library/blocks/query-title/editor-rtl.css 86 B 0 B
build/block-library/blocks/query-title/editor.css 86 B 0 B
build/block-library/blocks/query/editor-rtl.css 820 B 0 B
build/block-library/blocks/query/editor.css 819 B 0 B
build/block-library/blocks/quote/editor-rtl.css 61 B 0 B
build/block-library/blocks/quote/editor.css 61 B 0 B
build/block-library/blocks/quote/style-rtl.css 169 B 0 B
build/block-library/blocks/quote/style.css 169 B 0 B
build/block-library/blocks/rss/editor-rtl.css 201 B 0 B
build/block-library/blocks/rss/editor.css 202 B 0 B
build/block-library/blocks/rss/style-rtl.css 290 B 0 B
build/block-library/blocks/rss/style.css 290 B 0 B
build/block-library/blocks/search/editor-rtl.css 165 B 0 B
build/block-library/blocks/search/editor.css 165 B 0 B
build/block-library/blocks/search/style-rtl.css 342 B 0 B
build/block-library/blocks/search/style.css 344 B 0 B
build/block-library/blocks/separator/editor-rtl.css 99 B 0 B
build/block-library/blocks/separator/editor.css 99 B 0 B
build/block-library/blocks/separator/style-rtl.css 236 B 0 B
build/block-library/blocks/separator/style.css 236 B 0 B
build/block-library/blocks/shortcode/editor-rtl.css 512 B 0 B
build/block-library/blocks/shortcode/editor.css 512 B 0 B
build/block-library/blocks/site-logo/editor-rtl.css 201 B 0 B
build/block-library/blocks/site-logo/editor.css 201 B 0 B
build/block-library/blocks/site-logo/style-rtl.css 115 B 0 B
build/block-library/blocks/site-logo/style.css 115 B 0 B
build/block-library/blocks/social-link/editor-rtl.css 164 B 0 B
build/block-library/blocks/social-link/editor.css 165 B 0 B
build/block-library/blocks/social-links/editor-rtl.css 776 B 0 B
build/block-library/blocks/social-links/editor.css 776 B 0 B
build/block-library/blocks/social-links/style-rtl.css 1.32 kB 0 B
build/block-library/blocks/social-links/style.css 1.33 kB 0 B
build/block-library/blocks/spacer/editor-rtl.css 317 B 0 B
build/block-library/blocks/spacer/editor.css 317 B 0 B
build/block-library/blocks/spacer/style-rtl.css 48 B 0 B
build/block-library/blocks/spacer/style.css 48 B 0 B
build/block-library/blocks/table/editor-rtl.css 478 B 0 B
build/block-library/blocks/table/editor.css 478 B 0 B
build/block-library/blocks/table/style-rtl.css 402 B 0 B
build/block-library/blocks/table/style.css 402 B 0 B
build/block-library/blocks/tag-cloud/editor-rtl.css 118 B 0 B
build/block-library/blocks/tag-cloud/editor.css 118 B 0 B
build/block-library/blocks/tag-cloud/style-rtl.css 94 B 0 B
build/block-library/blocks/tag-cloud/style.css 94 B 0 B
build/block-library/blocks/template-part/editor-rtl.css 552 B 0 B
build/block-library/blocks/template-part/editor.css 551 B 0 B
build/block-library/blocks/term-description/editor-rtl.css 90 B 0 B
build/block-library/blocks/term-description/editor.css 90 B 0 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B 0 B
build/block-library/blocks/text-columns/editor.css 95 B 0 B
build/block-library/blocks/text-columns/style-rtl.css 166 B 0 B
build/block-library/blocks/text-columns/style.css 166 B 0 B
build/block-library/blocks/verse/editor-rtl.css 50 B 0 B
build/block-library/blocks/verse/editor.css 50 B 0 B
build/block-library/blocks/verse/style-rtl.css 87 B 0 B
build/block-library/blocks/verse/style.css 87 B 0 B
build/block-library/blocks/video/editor-rtl.css 504 B 0 B
build/block-library/blocks/video/editor.css 503 B 0 B
build/block-library/blocks/video/style-rtl.css 187 B 0 B
build/block-library/blocks/video/style.css 187 B 0 B
build/block-library/common-rtl.css 1.1 kB 0 B
build/block-library/common.css 1.1 kB 0 B
build/block-library/editor-rtl.css 9.48 kB 0 B
build/block-library/editor.css 9.48 kB 0 B
build/block-library/style-rtl.css 8.88 kB 0 B
build/block-library/style.css 8.89 kB 0 B
build/block-library/theme-rtl.css 700 B 0 B
build/block-library/theme.css 701 B 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/blocks/index.js 48.3 kB 0 B
build/components/index.js 284 kB 0 B
build/components/style-rtl.css 16.2 kB 0 B
build/components/style.css 16.2 kB 0 B
build/compose/index.js 11.2 kB 0 B
build/core-data/index.js 16.7 kB 0 B
build/customize-widgets/index.js 5.99 kB 0 B
build/customize-widgets/style-rtl.css 378 B 0 B
build/customize-widgets/style.css 379 B 0 B
build/data-controls/index.js 830 B 0 B
build/data/index.js 8.87 kB 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 787 B 0 B
build/dom-ready/index.js 577 B 0 B
build/dom/index.js 4.99 kB 0 B
build/edit-navigation/index.js 11.9 kB 0 B
build/edit-navigation/style-rtl.css 1.31 kB 0 B
build/edit-navigation/style.css 1.31 kB 0 B
build/edit-post/index.js 307 kB 0 B
build/edit-post/style-rtl.css 7.12 kB 0 B
build/edit-post/style.css 7.11 kB 0 B
build/edit-site/index.js 27.2 kB 0 B
build/edit-site/style-rtl.css 4.56 kB 0 B
build/edit-site/style.css 4.55 kB 0 B
build/edit-widgets/index.js 20.2 kB 0 B
build/edit-widgets/style-rtl.css 3.2 kB 0 B
build/edit-widgets/style.css 3.2 kB 0 B
build/editor/editor-styles-rtl.css 347 B 0 B
build/editor/editor-styles.css 347 B 0 B
build/editor/index.js 41.9 kB 0 B
build/editor/style-rtl.css 3.9 kB 0 B
build/editor/style.css 3.9 kB 0 B
build/element/index.js 4.61 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.75 kB 0 B
build/format-library/style-rtl.css 637 B 0 B
build/format-library/style.css 639 B 0 B
build/hooks/index.js 2.28 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 4.01 kB 0 B
build/is-shallow-equal/index.js 699 B 0 B
build/keyboard-shortcuts/index.js 2.53 kB 0 B
build/keycodes/index.js 1.95 kB 0 B
build/list-reusable-blocks/index.js 3.14 kB 0 B
build/list-reusable-blocks/style-rtl.css 629 B 0 B
build/list-reusable-blocks/style.css 628 B 0 B
build/media-utils/index.js 5.34 kB 0 B
build/notices/index.js 1.85 kB 0 B
build/nux/index.js 3.41 kB 0 B
build/nux/style-rtl.css 731 B 0 B
build/nux/style.css 727 B 0 B
build/plugins/index.js 2.89 kB 0 B
build/primitives/index.js 1.42 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/react-i18n/index.js 1.46 kB 0 B
build/redux-routine/index.js 2.83 kB 0 B
build/reusable-blocks/index.js 3.78 kB 0 B
build/reusable-blocks/style-rtl.css 225 B 0 B
build/reusable-blocks/style.css 225 B 0 B
build/rich-text/index.js 13.3 kB 0 B
build/server-side-render/index.js 2.58 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 3.02 kB 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@aaronrobertshaw aaronrobertshaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Looks good although I have just one minor question regarding the change of Icon background color to Background color on the social links block.

That color control is not actually setting the social links block's background color, only the background for the icons within it. Would it be better to leave it as Icon background color as it is more accurate?

Happy to defer to you if greater consistency outweighs accurately labelling what the control affects 🙂

@jasmussen

Copy link
Copy Markdown
Contributor Author

That does actually make sense. Thanks.

@gziolo
gziolo requested a review from mtias March 22, 2021 08:29
@gziolo

gziolo commented Mar 22, 2021 •

Copy link
Copy Markdown
Member

I'm thinking about how to generalize those labels so we could have a more structured approach when injecting UI controls with supports in the block definition. The most common causes are:

  • text
  • background
  • link

There are exceptions like the Button block and Social Links block where we have quite a unique approach:

  • icon's outer part (aka icon background color) and icon's inner part (aka icon color)
  • buttons outer part (aka background color) and the text (aka text color)

I think it's a bit confusing in the Button block and it shouldn't use the name background since it's different from the background you know from the Group or Heading blocks. Should we use a consistent naming that would work for both those blocks and better express the intent like Inner color and Outer color? This way, we would be able to use 5 different types of color in supports that might cover 99% of cases. @mtias and @nosolosw, I would like to hear your thoughts as well.

@gziolo
gziolo requested a review from oandregal March 22, 2021 08:52
@jasmussen

Copy link
Copy Markdown
Contributor Author

Could we use "Item background"?

@gziolo

gziolo commented Mar 22, 2021 •

Copy link
Copy Markdown
Member

Could we use "Item background"?

Yes, item background and item foreground would work as well 👍🏻

@oandregal

Copy link
Copy Markdown
Member

👋 If the same label names in the color hook can be the same in use for all the blocks (including social links) we won't need to implement #29155 (it was created because in #28913 we wanted to migrate some blocks -including social links- to use the block support mechanism instead of the custom controls and labels).

@gziolo

gziolo commented Mar 22, 2021 •

Copy link
Copy Markdown
Member

@nosolosw, it might be as simple as extending what you can see for links in the Paragraph block:

"color": {
"link": true
},

For the Social Links block you could have:

"supports": {
    "color": {
        "foregroundItem": true,
        "backgroundItem": true
    }
}

and we would only need to extend the handling in the color hooks in the block editor package.

@jasmussen

Copy link
Copy Markdown
Contributor Author

Feel free to push any changes to this PR if that's helpful.

@jasmussen

Copy link
Copy Markdown
Contributor Author

We can also separate things out, as this PR touches a slew of other things.

@gziolo

gziolo commented Mar 22, 2021

Copy link
Copy Markdown
Member

Let's agree on the direction first, I don't know if what I propose makes sense with everything else that already exists 😄

@oandregal

Copy link
Copy Markdown
Member

@gziolo To make sure I follow, there're two things here:

  1. For the labels, we don't need to rename anything in the block supports. If we can use the same labels in the hook and in the custom controls, we don't need anything else for Next iteration of block supports mechanism #28913

  2. The other thing you seem to be hinting at is that we should also rename the names of the block supports for colors so that:

  • text => foregroundItem
  • background => backgroundItem

Is that correct? If we were to rename them, I'd think we'd want text to become color and background to be backgroundColor. The other block supports (fontSize, lineHeight, border, etc) have the same name of the CSS property they represent and I guess these should be the same. gradients represents background, thought, so I suppose it could be renamed as well although gradients is fine by me. Finaly, link is being moved out of block supports to become an element of the block as per #29891

Does this help?

@gziolo

gziolo commented Mar 24, 2021 •

Copy link
Copy Markdown
Member

@nosolosw, I don't think this is what I proposed:

This way, we would be able to use 5 different types of color in supports that might cover 99% of cases.

I think that the existing default values are here to stay as they cover 90% of cases:

  • text color
  • background color
  • link color

We could add more options, but it might be as well confusing for people using API.

For the labels, we don't need to rename anything in the block supports. If we can use the same labels in the hook and in the custom controls, we don't need anything else for #28913

Yes, as discussed in other places, we shouldn't cover labels in the theme.json or block.json.

@oandregal oandregal mentioned this pull request Mar 24, 2021
75 of 82 tasks
@oandregal

Copy link
Copy Markdown
Member

I've closed #29155 (comment) in favor of this one. Talked with Greg about this: it looks like the first step is just aligning the labels in use by the UI controls generated by the hooks and the custom labels. We won't offer the ability to have custom labels per block in the UI controls generated by the hooks at the moment.

@oandregal oandregal mentioned this pull request Mar 25, 2021
17 of 20 tasks
@jasmussen

Copy link
Copy Markdown
Contributor Author

@nosolosw Alright, I have to work on some other things at the moment, but feel free to entirely take over this branch if it's useful to you.

@jasmussen

Copy link
Copy Markdown
Contributor Author

What are next steps here?

@gziolo gziolo changed the title Try: Rephrase, polish, and make consistent color labels. Inspector Controls: Rephrase, polish, and make consistent color labels. Apr 14, 2021
@gziolo gziolo added the [Type] Copy Issues or PRs that need copy editing assistance label Apr 14, 2021

const title = isWebPlatform
? __( 'Color settings' )
: __( 'Color Settings' );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hypest, is there any reason this differs in the mobile app. Are there tests that depend on it that need to get updated?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I checked, we don't have any test that relies on this. I checked the commit that introduced this change and it doesn't look like the decision of using different values has to do beyond a naming convention. Being this said, I'd say it's safe to continue with this change 👍 .

@hypest do you agree?

@hypest hypest Apr 14, 2021 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, I agree. To be on the safe side I created this gutenberg-mobile PR to run all tests from the native mobile side of things. Edit: native mobile tests are green 👍.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @iamthomasbishop , what's your take on the use of Sentence case here? Will it be a problem for the mobile apps? See for example this diff.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to think about it is: is title-case worth extra code across the entire project?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Polish you don't even have the choice, it's a sentence case on all websites, sometimes they use uppercase for highlights 😄

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's your take on the use of Sentence case here

@hypest We're slowly moving towards sentence-casing on mobile, so we can remove the mobile-specific code here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ all systems go then! I will go ahead and merge this PR, thank you all!

@gziolo
gziolo requested a review from hypest April 14, 2021 08:31
@jasmussen

Copy link
Copy Markdown
Contributor Author

Thank you for the approval! Did the thoughts here have any impact on next steps? #30075 (comment)

@gziolo

gziolo commented Apr 14, 2021 •

Copy link
Copy Markdown
Member

Thank you for the approval! Did the thoughts here have any impact on next steps? #30075 (comment)

I think we are fine. I prefer we land with a more general approach rather than trying to account for more distinct use cases.

We need to double-check with the mobile team while they picked a different label in the mobile app before proceeding. See #30075 (comment).

@jasmussen

Copy link
Copy Markdown
Contributor Author

Cool. Feel free to press the green button when you feel it's time then, thanks!

@hypest
hypest removed their request for review April 14, 2021 11:51
@lukewalczak
lukewalczak removed their request for review April 14, 2021 13:17
@hypest
hypest merged commit 4abfc1e into trunk Apr 15, 2021
@hypest
hypest deleted the try/fix-social-links-labels branch April 15, 2021 09:06
@github-actions github-actions Bot added this to the Gutenberg 10.5 milestone Apr 15, 2021
@hypest hypest mentioned this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Inspector Controls The interface showing block settings and the controls available for each block [Type] Copy Issues or PRs that need copy editing assistance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants