Self-host: add DOM validate/save JIT units to compile spine (#35540) - #35559
Merged
Merged
Conversation
This was referenced Aug 27, 2026
Closed
PurHur
added a commit
that referenced
this pull request
Aug 27, 2026
…tnotes. (#35565) Remove duplicate require_once introduced when #35558/#35559 appended DOM save helpers — check-selfhost-spine-count-sync was failing on the duplicate path. Run spine-sync --footnotes-only to refresh doc footnotes and bundle test count. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five DOM JIT units from the #35540 / #35546 / #35549 AOT landings were on the
bin/vm.phpinventory (7959 files) but missing fromcompiler_lib_spine_smoke/main.php. Afterbootstrap-inventory.phpregen duringnorth-star5-verify-fast, step 2 failed at 7954/7959 with:ext/dom/DomDocumentValidateJitHelper.phpext/dom/JitDomSave.phplib/JIT/Builtin/DomDocumentValidateRuntime.phplib/JIT/Call/DomDocumentSave.phplib/JIT/Call/DomDocumentValidateMethod.phpSame class of fix as #35441 (ZipArchive NestedJIT spine sync).
Test plan
Closes #35540 (spine sync leftover; AOT lowering already merged)
Made with Cursor