Skip to content

Self-host: add DOM validate/save JIT units to compile spine (#35540) - #35559

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-35540-dom-spine-sync
Aug 27, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/issue-35540-dom-spine-sync

Conversation

@PurHur

@PurHur PurHur commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

Five DOM JIT units from the #35540 / #35546 / #35549 AOT landings were on the bin/vm.php inventory (7959 files) but missing from compiler_lib_spine_smoke/main.php. After bootstrap-inventory.php regen during north-star5-verify-fast, step 2 failed at 7954/7959 with:

  • ext/dom/DomDocumentValidateJitHelper.php
  • ext/dom/JitDomSave.php
  • lib/JIT/Builtin/DomDocumentValidateRuntime.php
  • lib/JIT/Call/DomDocumentSave.php
  • lib/JIT/Call/DomDocumentValidateMethod.php

Same class of fix as #35441 (ZipArchive NestedJIT spine sync).

Test plan

./script/docker-exec.sh -- bash -lc 'php script/check-selfhost-spine-coverage-sync.php && php script/bootstrap-spine-count.php'
# check-selfhost-spine-coverage-sync: OK (spine covers all 7959 inventory files)
# bootstrap-spine-count: 7959/7959

make north-star5-verify-fast
# north-star5-verify: OK (fast)

./script/phpunit.sh --filter 'DomDocumentValidate35540AotTest|DomDocumentSave35546AotTest'
# OK (4 tests, 23 assertions)

./script/aot-smoke.sh
# aot-smoke: 8 passed, 0 failed

Closes #35540 (spine sync leftover; AOT lowering already merged)

Made with Cursor

Five units landed for #35540/#35546/#35549 AOT fixes were on the vm.php
inventory but missing from compiler_lib_spine_smoke, blocking
north-star5-verify-fast at 7954/7959 after inventory regen.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit c1b3cc5 into master Aug 27, 2026
@PurHur
PurHur deleted the agent/issue-35540-dom-spine-sync branch August 27, 2026 19:31
PurHur added a commit that referenced this pull request Aug 27, 2026
…tnotes. (#35565)

Remove duplicate require_once introduced when #35558/#35559 appended DOM save
helpers — check-selfhost-spine-count-sync was failing on the duplicate path.
Run spine-sync --footnotes-only to refresh doc footnotes and bundle test count.

Co-authored-by: PurHur <PurHur@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AOT: DOMDocument::schemaValidate*/relaxNGValidate*/validate/xinclude/registerNodeClass return NULL — ExternalMethod stubs (ext/dom/document.c)

1 participant