Skip to content

Self-host: add ZipArchive NestedJIT units to compile spine — blocks north-star5-verify-fast (leftover #35424) #35441

Description

@PurHur

Category

Regression · Pillar 1 (Trust) · spine-coverage · leftover of #35424 / #35434

Problem

make north-star5-verify-fast fails after inventory regen:

check-selfhost-spine-coverage-sync: FAILED — 4 inventory files missing from spine:
  ext/zip/JitZipArchive.php
  ext/zip/ZipArchiveJitHelper.php
  lib/JIT/Builtin/ZipArchiveEmbedBridge.php
  lib/JIT/Call/ZipArchiveMethod.php

(ZipArchiveJitSupport.php is also on the inventory path and must be covered.)

Introduced by #35434 which added ZipArchive NestedJIT binding without spine require_once entries.

./script/aot-smoke.sh is 8/8. Helper-runtime 414/0/0 and cold-build are green.

Repro

./script/docker-exec.sh -- bash -lc 'make north-star5-verify-fast'

Done when

  • Five ZipArchive NestedJIT units are require_once'd in test/selfhost/compiler_lib_spine_smoke/main.php
  • php script/check-selfhost-spine-coverage-sync.php OK
  • make north-star5-verify-fast OK
  • ./script/aot-smoke.sh stays 8/8

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:toolingTooling / CI / docsbugSomething isn't workingimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevExrelease-blockerBlocks tagged user release

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions