Skip to content

Self-host: dedupe JitDomSave.php spine require (#1402) - #35565

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-spine-dedupe-jitdomsave
Aug 27, 2026
Merged

Self-host: dedupe JitDomSave.php spine require (#1402)#35565
PurHur merged 1 commit into
masterfrom
agent/issue-spine-dedupe-jitdomsave

Conversation

@PurHur

@PurHur PurHur commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes check-selfhost-spine-count-sync failure:

compiler_lib_spine_smoke: duplicate require_once for ext/dom/JitDomSave.php — remove the extra line

Closes #1402

Test plan

./script/aot-smoke.sh
# aot-smoke: 8 passed, 0 failed

./script/docker-exec.sh -- bash -lc 'php script/check-selfhost-spine-count-sync.php && php script/check-selfhost-spine-coverage-sync.php'
# check-selfhost-spine-count-sync: OK (spine 7959/7959 from compiler_lib_spine_smoke)
# check-selfhost-spine-coverage-sync: OK (spine covers all 7959 inventory files)

./script/spine-sync.sh --footnotes-only
# step 4: count + coverage + roadmap OK (sidecar stamp step expected red without relink — footnote-only PR)

Made with Cursor

…tnotes.

Remove duplicate require_once introduced when #35558/#35559 appended DOM save
helpers — check-selfhost-spine-count-sync was failing on the duplicate path.
Run spine-sync --footnotes-only to refresh doc footnotes and bundle test count.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit af9b3c1 into master Aug 27, 2026
1 check failed
@PurHur
PurHur deleted the agent/issue-spine-dedupe-jitdomsave branch August 27, 2026 20:48
PurHur added a commit that referenced this pull request Aug 27, 2026
)

Co-authored-by: PurHur <PurHur@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

M3: PHP_COMPILER_M3_COMPILE_DRIVER=1 link segfaults LLVM 9 during Runtime real lowering

1 participant