Self-host: sync spine for DOM save/validate AOT helpers - #35558
Merged
Merged
Conversation
…). Five inventory files added by recent DOMDocument save/validate NestedJIT landings were missing from compiler_lib_spine_smoke, breaking north-star5-verify-fast at 7954/7959. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 27, 2026
Closed
PurHur
added a commit
that referenced
this pull request
Aug 27, 2026
…tnotes. (#35565) Remove duplicate require_once introduced when #35558/#35559 appended DOM save helpers — check-selfhost-spine-count-sync was failing on the duplicate path. Run spine-sync --footnotes-only to refresh doc footnotes and bundle test count. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compiler_lib_spine_smokethat landed with AOT: DOMDocument::schemaValidate*/relaxNGValidate*/validate/xinclude/registerNodeClass return NULL — ExternalMethod stubs (ext/dom/document.c) #35540 (validate/schemaValidate NestedJIT) and AOT: DOMDocument::save returns NULL — ExternalMethod stub (leftover of #35540 / #18435) #35546/AOT: DOMDocument::saveHTMLFile writes nothing — NestedJIT stubs VmDom::saveHTMLFile (leftover of #35546 / #18268) #35549 (save/saveHTMLFile) but were never wired into the self-host spine bundle.north-star5-verify-fastfrom 7954/7959 (spine coverage sync fail) to 7959/7959.Test plan
php script/check-selfhost-spine-coverage-sync.php→ OK (spine covers all 7959 inventory files)php script/bootstrap-spine-count.php→ 7959/7959make north-star5-verify-fast→ OK (fast)./script/aot-smoke.sh→ 8 passed, 0 failedMade with Cursor