Repository navigation
Tooling: hygiene wave30 batch 2 — drop 24 stale maintainer_gap repros (#16660) - #17731
Merged
Merged
Conversation
Remove VM-green repro scripts tied to closed issues (#3312, #4517, #4942, Co-authored-by: Cursor <cursoragent@cursor.com> #5275, #8851, #9559, #10280, #11815, #11825, #13694, #13706, #16359, #16738, #16888, #17049–#17052, #17063, #17075, #17250, #17291, #17493, #17503, #17708). Extends wave30 PR #17729.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maintainer_gap_*.phprepro scripts tied to closed issues (wave30 batch 2, extends Tooling: hygiene wave30 — drop 12 green maintainer_gap repros (#16660) #17729)var_dump($x !== false)binds as(var_dump($x)) !== false(Zend/zend_compile.c) #13694, Regression: EnumCases/NoDiscard phantom on 8.2 reference — class_exists true without php-src (Zend/zend_attributes.c) #13706, Regression: ReflectionFunction::isDeprecated() true on 8.2 profile — Zend false (re-#9760, ext/reflection/php_reflection.c) #16359, Regression: array read with false key on string-keyed array returns false not NULL (re-#5275, Zend/zend_hash.c) #16738, Regression: DateMalformedPeriodException class_exists true on PHP 8.2 reference profile (ext/date/php_date.c) #16888, Regression: microtime(null) under declare(strict_types=1) — VM coerces, Zend TypeError (ext/standard/microtime.c) #17049–Regression: date_create_from_format(null, …) under declare(strict_types=1) — VM coerces, Zend TypeError (ext/date/php_date.c) #17052, Regression: file_get_contents()/readfile()/file_put_contents() null under strict_types — ValueError not TypeError (ext/standard/file.c) #17063, Regression: copy(null, …) under declare(strict_types=1) — ValueError not TypeError (ext/standard/file.c) #17075, Regression: var_export($expr !== false, true) returns NULL — false literal misread as return flag (re-#13694, lib/Compiler.php) #17250, Regression: ini_get()/ini_set() int option operand — TypeError on 8.2 reference profile when Zend coerces (re-#17268, ext/standard/ini.c) #17291, Regression: ReflectionProperty PHP 8.4 hook/lazy APIs visible on 8.2 reference profile (ext/reflection/php_reflection.c) #17493, Regression: preg_*() /u on invalid UTF-8 — match succeeds, preg_last_error() stale (ext/pcre/php_pcre.c) #17503, Regression: password_needs_rehash() nested password_hash() callee — fatal TYPE_DOUBLE typo (ext/standard/password.c) #17708Closes #16660 (partial — queue hygiene wave30)
Verification
Each deleted repro verified green on master before removal:
./script/ci-fast.sh # exit 0Made with Cursor