Regression: file_get_contents()/readfile()/file_put_contents() null under strict_types — ValueError not TypeError (ext/standard/file.c)

Problem

Under declare(strict_types=1), Zend file I/O builtins reject null filenames with TypeError. This compiler raises ValueError (Path cannot be empty) from shared path-string guards — same root cause as #17060.

Repro	Zend 8.2	VM (2026-07-07)
`declare(strict_types=1); file_get_contents(null);`	`TypeError`	`ValueError: Path cannot be empty`
`declare(strict_types=1); readfile(null);`	`TypeError`	`ValueError: Path cannot be empty`
`declare(strict_types=1); file_put_contents(null, 'x');`	`TypeError`	`ValueError: Path cannot be empty`

php-src reference

php/php-src ext/standard/file.c — php_stream_open_wrapper_ex / Z_PARAM_PATH strict null handling

PHP implementation target

ext/standard/file_get_contents.php, readfile.php, file_put_contents.php — align strict-null guard with Zend TypeError (shared fix with Regression: getimagesize()/md5_file()/sha1_file() null under strict_types — ValueError not TypeError (ext/standard/image.c, ext/standard/md5.c) #17060 in path-string coercion helper)
lib/JIT/Builtin/ file stream lowerings if they bypass PHP helpers

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php -r '\''declare(strict_types=1); try { file_get_contents(null); } catch (Throwable $e) { echo get_class($e), "\n"; }'\'''
# VM: ValueError — Zend: TypeError

Done when

All three builtins throw TypeError on null under declare(strict_types=1)
Fix shares helper with Regression: getimagesize()/md5_file()/sha1_file() null under strict_types — ValueError not TypeError (ext/standard/image.c, ext/standard/md5.c) #17060 / Regression: file_exists(null)/path builtins null filename — TypeError not false (re-#13354, ext/standard/filestat.c) #17006 path-builtin family
Compliance .phpt guards under test/compliance/cases/stdlib/
php-src-strict; no php-compiler-strict shortcut

Regression: getimagesize()/md5_file()/sha1_file() null under strict_types — ValueError not TypeError (ext/standard/image.c, ext/standard/md5.c) #17060 · Regression: file_exists(null)/path builtins null filename — TypeError not false (re-#13354, ext/standard/filestat.c) #17006 · Regression: file/path builtins null filename — TypeError not empty-string coerce (ext/standard/filestat.c, url.c) #13354

claim: PHP Runtime → PHP — starting this run.

Cleanup bot note (2026-07-07): Sibling #17060 closed via #17070 — fix pattern is VmStreamPath::coerceNonEmptyPathArgForFrame + JitStreamPath::lowerPath non-empty guard + compliance path_null_strict_typeerror*.phpt. This issue covers file_get_contents/readfile/file_put_contents path arg — same shared path guards; extend the #17070 approach to ext/standard/file.c lowering (not a duplicate of #17060).

Stdlib: file I/O null under strict_types throws TypeError (#17063) (#…

Merged via #17071.

Fix: VM execute paths now use VmStreamPath::coerceNonEmptyPathArgForFrame() (file_get_contents, readfile) and VmFilestatArg::filenameArgForFrame() (file_put_contents) so caller strict_types rejects null with TypeError before empty-path ValueError. JIT already routed through JitStringBuiltinArg::lowerPath().

Verification:

php bin/vm.php test/repro/maintainer_gap_file_io_null_strict.php
# file_get_contents=TypeError / readfile=TypeError / file_put_contents=TypeError

vendor/bin/phpunit --filter file_io_null_strict_typeerror
# OK (4 tests) — VM + JIT compliance

PHP-in-PHP only; no C runtime changes.

chore: drop 24 more stale maintainer_gap repros (wave30 batch 2, #16660…

Navigation Menu

Repository navigation

Regression: file_get_contents()/readfile()/file_put_contents() null under strict_types — ValueError not TypeError (ext/standard/file.c) #17063

Category

Problem

php-src reference

PHP implementation target

Repro

Done when

Related

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Regression: file_get_contents()/readfile()/file_put_contents() null under strict_types — ValueError not TypeError (ext/standard/file.c) #17063

Description

Category

Problem

php-src reference

PHP implementation target

Repro

Done when

Related

Activity

PurHur commented on Jul 7, 2026

PurHur commented on Jul 7, 2026

PurHur commented on Jul 7, 2026

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions