Repository navigation
Language: false array keys must coerce to 0 not LogicException (Zend/zend_hash.c) #5275
Description
Category
language
Problem
Using false as an array index must coerce to integer 0 (same as Zend). This compiler throws LogicException: Unknown index type 3 from lib/VM/HashTable.php because bool keys are not normalized before hashtable access.
Companion to #5269 (null → empty string); bool/false is a separate zend_hash coercion path.
php-src reference
- php/php-src
Zend/zend_hash.c—_zend_hash_index_add_or_update, bool→long key conversion - php/php-src
Zend/zend_operators.c— scalar-to-key handling for offsets
Repro (failure today)
<?php
$a = [1, 2];
$a[false] = 3;
var_export($a);
echo "\n";./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php -r '"'"'$a=[1,2]; $a[false]=3; var_export($a); echo "\n";'"'"'
php bin/vm.php -r '"'"'$a=[1,2]; $a[false]=3; var_export($a); echo "\n";'"'"'
'| Engine | Output |
|---|---|
| Zend PHP 8.2 | array (0 => 3, 1 => 2) |
bin/vm.php |
LogicException: Unknown index type 3 |
Also verify read path: $a = ['a' => 1]; var_export($a[false]); → NULL with warning on Zend.
Scope (this repo)
| Area | Files |
|---|---|
| VM | lib/VM/HashTable.php — normalize bool index to int 0/1 before packed/hashtable ops |
| Compiler/JIT | lib/JIT/Helper.php array offset lowering if bool keys reach native path |
| Tests | test/compliance/cases/language/array_key_false.phpt |
Implement coercion in PHP VM/JIT lowering; do not add new C branches in runtime/.
Done when
- Repro matches Zend for write and read with
falsekey -
./script/ci-fast.sh --filter array_key_falsegreen - No regression on Language: null array keys must coerce to empty string (Zend/zend_hash.c) #5269 null-key repro
Activity
PurHur commentedon Jun 3, 2026
claim: cursor-agent-lane-c — starting this run
Fix false/true array keys coercing to int 0/1 (#5275) (#5312)
PurHur commentedon Jun 3, 2026
Merged via #5312
Fix:
HashTable::normalizeIndexKeycoercesboolkeys to int 0/1;ErrorReporter::undefinedArrayKeyuses the same normalization for warning text.Verification:
$a=[1,2]; $a[false]=3→array (0 => 3, 1 => 2)$b=['a'=>1]; $b[false]→Undefined array key 0+NULLvendor/bin/phpunit test/compliance/VMTest.php --filter array_key_false— OKvendor/bin/phpunit test/compliance/VMTest.php --filter array_null_key_coerce— OK (Language: null array keys must coerce to empty string (Zend/zend_hash.c) #5269)chore: drop 24 more stale maintainer_gap repros (wave30 batch 2, #16660…