Skip to content

DevEx: make north-star1-verify presenter gate before #1044 close #1845

Description

@PurHur

Problem

North Star 1 AOT execute, serve-aot, and deploy-smoke 003 are default-on in script/ci-defaults.env (#764 ✅, #1760 ✅). Before closing #1044, presenters and PR authors still run a scattered command list (make miniwebapp-gates, phpc doctor --gates, filtered PHPUnit, optional shell smokes).

There is no single fast north-star verify target documented in README/Makefile.

Goal

Add make north-star1-verify (and ./script/north-star1-verify.sh) that runs, in order:

  1. phpc doctor --gates — print gate matrix (DevEx: phpc doctor --gates refresh after North Star 1 default-on gate flips (#1523, #1530) #1752)
  2. make miniwebapp-gates — ladder probe (stages 0–4d)
  3. ./script/ci-fast.sh --filter 'MiniWebApp' — VM/cli serve subset
  4. When LLVM ready: MINIWEBAPP_AOT_EXECUTE_GATE=1 vendor/bin/phpunit --filter MiniWebAppAotExecuteTest
  5. Optional llvm tail (skip when .llvm missing): MINIWEBAPP_WEB_SMOKE_AOT_GATE=1 ./script/examples-web-smoke.sh --miniwebapp-only --aot

Exit non-zero on first failure; print “next issue” hints from stderr (mirror miniwebapp-gates.sh).

Acceptance criteria

make north-star1-verify          # host, LLVM optional for tail
make docker-build-22
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev make north-star1-verify

Dependencies

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions