Problem
#657 ✅ landed phpc doctor --gates delegating to script/miniwebapp-gates.sh. Since then, several gates flipped default-on on master:
| Gate |
Default today |
Issue |
MINIWEBAPP_AOT_EXECUTE_GATE |
1 |
#747 ✅ |
MINIWEBAPP_SERVE_AOT_GATE |
1 |
#1524 ✅ |
MINIWEBAPP_WEB_SMOKE_AOT_GATE |
0 |
#1523 open |
DEPLOY_SMOKE_003_EXECUTE |
0 |
#1530 open |
Doctor output and examples/003-MiniWebApp/README.md gate ladder may still read like AOT HTTP/deploy stages are opt-in, confusing harness users running ./phpc doctor --gates after #1523 / #1530 land.
Goal
When #1523 and #1530 flip defaults in script/ci-defaults.env:
- Update
script/miniwebapp-gates.sh stage labels (4c2 web-smoke --aot, 4d deploy 003 execute)
- Ensure
./phpc doctor --gates reflects new defaults (no stale "set MINIWEBAPP_*=1" hints for already-on gates)
- Extend
test/unit/DoctorTest.php assertions for default-on env
Scope
Implementation hints
| Piece |
Path |
| Defaults source of truth |
script/ci-defaults.env |
| Ladder script |
script/miniwebapp-gates.sh |
| Doctor |
lib/Doctor.php, bin/phpc.php |
| Tests |
test/unit/DoctorTest.php, test/unit/CiScriptsTest.php |
Verify
./phpc doctor --gates
./script/miniwebapp-gates.sh
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev ./phpc doctor --gates
No GitHub Actions.
Acceptance criteria
Dependencies
Links
Problem
#657 ✅ landed
phpc doctor --gatesdelegating toscript/miniwebapp-gates.sh. Since then, several gates flipped default-on onmaster:MINIWEBAPP_AOT_EXECUTE_GATEMINIWEBAPP_SERVE_AOT_GATEMINIWEBAPP_WEB_SMOKE_AOT_GATEDEPLOY_SMOKE_003_EXECUTEDoctor output and
examples/003-MiniWebApp/README.mdgate ladder may still read like AOT HTTP/deploy stages are opt-in, confusing harness users running./phpc doctor --gatesafter #1523 / #1530 land.Goal
When #1523 and #1530 flip defaults in
script/ci-defaults.env:script/miniwebapp-gates.shstage labels (4c2 web-smoke--aot, 4d deploy 003 execute)./phpc doctor --gatesreflects new defaults (no stale "set MINIWEBAPP_*=1" hints for already-on gates)test/unit/DoctorTest.phpassertions for default-on envScope
lib/Doctor.php/ gates delegate — pass through env fromci-defaults.envexamples/003-MiniWebApp/README.mddocs/local-ci-matrix.mdrow sync (Docs: local-ci-matrix — MiniWebApp gate env reference (MINIWEBAPP_*) #808 pattern)Implementation hints
script/ci-defaults.envscript/miniwebapp-gates.shlib/Doctor.php,bin/phpc.phptest/unit/DoctorTest.php,test/unit/CiScriptsTest.phpVerify
./phpc doctor --gates ./script/miniwebapp-gates.sh docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev ./phpc doctor --gatesNo GitHub Actions.
Acceptance criteria
ci-defaults.envdefaults for all MiniWebApp gates./script/ci-local.sh --filter DoctorTestgreenDependencies
Links