Skip to content

DevEx: phpc doctor --gates refresh after North Star 1 default-on gate flips (#1523, #1530) #1752

Description

@PurHur

Problem

#657 ✅ landed phpc doctor --gates delegating to script/miniwebapp-gates.sh. Since then, several gates flipped default-on on master:

Gate Default today Issue
MINIWEBAPP_AOT_EXECUTE_GATE 1 #747
MINIWEBAPP_SERVE_AOT_GATE 1 #1524
MINIWEBAPP_WEB_SMOKE_AOT_GATE 0 #1523 open
DEPLOY_SMOKE_003_EXECUTE 0 #1530 open

Doctor output and examples/003-MiniWebApp/README.md gate ladder may still read like AOT HTTP/deploy stages are opt-in, confusing harness users running ./phpc doctor --gates after #1523 / #1530 land.

Goal

When #1523 and #1530 flip defaults in script/ci-defaults.env:

  1. Update script/miniwebapp-gates.sh stage labels (4c2 web-smoke --aot, 4d deploy 003 execute)
  2. Ensure ./phpc doctor --gates reflects new defaults (no stale "set MINIWEBAPP_*=1" hints for already-on gates)
  3. Extend test/unit/DoctorTest.php assertions for default-on env

Scope

Implementation hints

Piece Path
Defaults source of truth script/ci-defaults.env
Ladder script script/miniwebapp-gates.sh
Doctor lib/Doctor.php, bin/phpc.php
Tests test/unit/DoctorTest.php, test/unit/CiScriptsTest.php

Verify

./phpc doctor --gates
./script/miniwebapp-gates.sh
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev ./phpc doctor --gates

No GitHub Actions.

Acceptance criteria

  • Doctor output matches ci-defaults.env defaults for all MiniWebApp gates
  • Suggested exports only appear for gates still default-off
  • ./script/ci-local.sh --filter DoctorTest green

Dependencies

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions