Skip to content

CI: North Star 1 gate-flip bundle — #1530 done; #1523 + #1752 remain before #1044 close #1760

Description

@PurHur

Problem

North Star 1 AOT execute is green on master (#764 ✅, #1529 ✅, #1524 ✅). Two default-off env gates still hide deploy-path and shell-smoke regressions from ./script/ci-local.sh:

Gate Default Issue What it runs
MINIWEBAPP_WEB_SMOKE_AOT_GATE 0 #1523 examples-web-smoke.sh --miniwebapp-only --aot
DEPLOY_SMOKE_003_EXECUTE 0 #1530 deploy-smoke.sh --example 003 execute

#1044 DoD has 2/10 boxes open largely because of these flips. #1752 (phpc doctor --gates) should land in the same PR so contributor docs match CI defaults.

Goal

One focused PR that:

  1. Sets MINIWEBAPP_WEB_SMOKE_AOT_GATE=1 in script/ci-defaults.env (CI: Default MINIWEBAPP_WEB_SMOKE_AOT_GATE=1 — examples-web-smoke 003 --aot curls (#676 step 3) #1523)
  2. Sets DEPLOY_SMOKE_003_EXECUTE=1 in script/ci-defaults.env (CI: Default DEPLOY_SMOKE_003_EXECUTE=1 — deploy-smoke 003 execute in ci-local #1530)
  3. Updates test/unit/CiScriptsTest.php expected default strings
  4. Updates docs/local-ci-matrix.md, docs/miniwebapp-gates.md, docs/miniwebapp-aot-unskip-matrix.md
  5. Refreshes phpc doctor --gates output (DevEx: phpc doctor --gates refresh after North Star 1 default-on gate flips (#1523, #1530) #1752)
  6. Closes CI: Default MINIWEBAPP_WEB_SMOKE_AOT_GATE=1 — examples-web-smoke 003 --aot curls (#676 step 3) #1523, CI: Default DEPLOY_SMOKE_003_EXECUTE=1 — deploy-smoke 003 execute in ci-local #1530; refreshes 🌐 North Star 1: Web-capable PHP application (living tracker) #1044 checklist

Implementation hints

File Change
script/ci-defaults.env Flip both defaults to 1
script/ci-common.sh Confirm both gates run in llvm phase (already wired)
test/unit/CiScriptsTest.php Assert new default strings
bin/phpc.php (doctor --gates) Show both as default-on
docs/local-ci-matrix.md Gate table

Pre-flight (must pass before PR):

make docker-build-22
MINIWEBAPP_WEB_SMOKE_AOT_GATE=1 ./script/examples-web-smoke.sh --miniwebapp-only --aot
DEPLOY_SMOKE_003_EXECUTE=1 ./script/deploy-smoke.sh --example 003
./script/ci-local.sh   # full gate with new defaults
phpc doctor --gates

Acceptance criteria

Verification (local / Docker only)

No GitHub Actions required (#394 ✅). Use ./script/docker-ci-local.sh on harness hosts.

Dependencies

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions