You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
North Star 1 AOT execute is green on master (#764 ✅, #1529 ✅, #1524 ✅). Two default-off env gates still hide deploy-path and shell-smoke regressions from ./script/ci-local.sh:
#1044 DoD has 2/10 boxes open largely because of these flips. #1752 (phpc doctor --gates) should land in the same PR so contributor docs match CI defaults.
Confirm both gates run in llvm phase (already wired)
test/unit/CiScriptsTest.php
Assert new default strings
bin/phpc.php (doctor --gates)
Show both as default-on
docs/local-ci-matrix.md
Gate table
Pre-flight (must pass before PR):
make docker-build-22
MINIWEBAPP_WEB_SMOKE_AOT_GATE=1 ./script/examples-web-smoke.sh --miniwebapp-only --aot
DEPLOY_SMOKE_003_EXECUTE=1 ./script/deploy-smoke.sh --example 003
./script/ci-local.sh # full gate with new defaults
phpc doctor --gates
Acceptance criteria
./script/ci-local.sh fails if either smoke regresses (no opt-in env needed)
Problem
North Star 1 AOT execute is green on
master(#764 ✅, #1529 ✅, #1524 ✅). Two default-off env gates still hide deploy-path and shell-smoke regressions from./script/ci-local.sh:MINIWEBAPP_WEB_SMOKE_AOT_GATE0examples-web-smoke.sh --miniwebapp-only --aotDEPLOY_SMOKE_003_EXECUTE0deploy-smoke.sh --example 003execute#1044 DoD has 2/10 boxes open largely because of these flips. #1752 (
phpc doctor --gates) should land in the same PR so contributor docs match CI defaults.Goal
One focused PR that:
MINIWEBAPP_WEB_SMOKE_AOT_GATE=1inscript/ci-defaults.env(CI: Default MINIWEBAPP_WEB_SMOKE_AOT_GATE=1 — examples-web-smoke 003 --aot curls (#676 step 3) #1523)DEPLOY_SMOKE_003_EXECUTE=1inscript/ci-defaults.env(CI: Default DEPLOY_SMOKE_003_EXECUTE=1 — deploy-smoke 003 execute in ci-local #1530)test/unit/CiScriptsTest.phpexpected default stringsdocs/local-ci-matrix.md,docs/miniwebapp-gates.md,docs/miniwebapp-aot-unskip-matrix.mdphpc doctor --gatesoutput (DevEx: phpc doctor --gates refresh after North Star 1 default-on gate flips (#1523, #1530) #1752)Implementation hints
script/ci-defaults.env1script/ci-common.shtest/unit/CiScriptsTest.phpbin/phpc.php(doctor --gates)docs/local-ci-matrix.mdPre-flight (must pass before PR):
make docker-build-22 MINIWEBAPP_WEB_SMOKE_AOT_GATE=1 ./script/examples-web-smoke.sh --miniwebapp-only --aot DEPLOY_SMOKE_003_EXECUTE=1 ./script/deploy-smoke.sh --example 003 ./script/ci-local.sh # full gate with new defaults phpc doctor --gatesAcceptance criteria
./script/ci-local.shfails if either smoke regresses (no opt-in env needed)MINIWEBAPP_WEB_SMOKE_AOT_GATE=0,DEPLOY_SMOKE_003_EXECUTE=0Verification (local / Docker only)
No GitHub Actions required (#394 ✅). Use
./script/docker-ci-local.shon harness hosts.Dependencies
Links
--aot) + deploy execute