Regression: getimagesize()/md5_file()/sha1_file() null under strict_types — ValueError not TypeError (ext/standard/image.c, ext/standard/md5.c) #17060

Category

stdlib · strict null filename · php-src-strict

Problem

Under declare(strict_types=1), Zend rejects null path/filename operands with TypeError. This compiler raises ValueError with message Path cannot be empty (via shared path-string guards) instead of the Zend TypeError wording.

php-src reference

• php/php-src ext/standard/image.c — PHP_FUNCTION(getimagesize) filename zend_parse_parameters Z_PARAM_PATH
• php/php-src ext/standard/md5.c — php_md5_file / php_hash_file filename typing

PHP implementation target

• ext/standard/getimagesize.php, ext/standard/md5.php / hash-file helpers — use VmString::coerceStringBuiltinArg / shared path-arg guard that throws TypeError on null under strict, not ValueError for empty path
• lib/JIT/Builtin/ counterparts if JIT lowers these builtins directly

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_gap_getimagesize_null_strict.php'
# VM: fail ValueError — Zend: TypeError

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_gap_md5_file_null_strict.php'

Done when

• All three builtins throw TypeError (message matches Zend class) under declare(strict_types=1) with null operand
• Non-strict null behavior unchanged (still ValueError / empty-path handling per php-src)
• Compliance .phpt guards under test/compliance/cases/stdlib/
• php-src-strict; no php-compiler-strict shortcut