Repository navigation
Stdlib: file I/O null under strict_types throws TypeError (#17063) - #17071
Merged
Merged
Conversation
Route file_get_contents/readfile through coerceNonEmptyPathArgForFrame and file_put_contents through filenameArgForFrame so caller strict_types rejects null before empty-path ValueError, matching Zend Z_PARAM_PATH. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_get_contents()/readfile()throughVmStreamPath::coerceNonEmptyPathArgForFrame()so callerstrict_typesrejectsnullwithTypeErrorbefore empty-pathValueError.file_put_contents()throughVmFilestatArg::filenameArgForFrame()for the same strict-null guard (shared with Regression: getimagesize()/md5_file()/sha1_file() null under strict_types — ValueError not TypeError (ext/standard/image.c, ext/standard/md5.c) #17060).JitStringBuiltinArg::lowerPath()strict-null path.Closes #17063
Root cause
VM execute paths called
coerceNonEmptyPathArg()/coerceFilenameArg()without the frame-awareInternalStrictArg::rejectNullString()step, sonullcoerced to""and raisedValueError: Path cannot be emptyinstead of Zend'sTypeError.Verification
Made with Cursor