Repository navigation
Stdlib: DOMNode::contains() missing — descendant check fatal (ext/dom/node.c, PHP 8+) #14447
Description
Summary
DOMNode::contains(?DOMNode $other): bool (DOM Living Standard) reports whether $other is a descendant of the receiver. VM fatals with undefined method DOMNode::contains(); Zend PHP 8+ implements it in ext/dom.
php-src reference
ext/dom/node.c—dom_node_contains()ext/dom/node.stub.php—DOMNode::contains
PHP implementation target
ext/dom/VmDom.php— walkchildIds/ parent chain inDomRegistry- Register on
DOMNode/DOMElementinext/dom/Module.php(PHP-in-PHP; no new C runtime)
Repro (php-src-strict)
./script/docker-exec.sh -- php bin/vm.php test/repro/maintainer_gap_dom_node_contains.php| Call | Zend 8+ | VM (wrong) |
|---|---|---|
$root->contains($child) |
true |
undefined method |
Done when
-
contains()registered on DOM node classes with php-src null-other semantics -
test/repro/maintainer_gap_dom_node_contains.phpgreen on VM - PHPUnit/compliance guard; VM/JIT/AOT agree when both in scope
Activity
PurHur commentedon Jul 1, 2026
claim: PHP Compiler STD Lib — batch (issues #14420, #14447)
Add DOMNode::contains() descendant check (#14447). (#14452)
PurHur commentedon Jul 1, 2026
Merged in #14452 — VM repro
test/repro/maintainer_gap_dom_node_contains.phpgreen; DomModuleTest contains guard passes.PurHur commentedon Jul 1, 2026
claim: PHP Compiler STD Lib — batch (issues #14447, #14410)
PurHur commentedon Jul 1, 2026
Merged via #14558.
maintainer_gap_dom_node_contains.phpprintsokon VM; AOT lint green; forward-profile phantom skips.Enable DOMNode::contains() on 8.4.0-dev forward profile (#14447). (#1…
Fix DOMNode contains/getRootNode gate on 8.4.0-dev forward profile. (#…
PurHur commentedon Jul 2, 2026
Forward-profile regression fixed in #15192:
supportsDomNodeContains()now usesadvertisesBuiltinSince('8.4.0')so 8.4.0-dev registerscontainsagain. Verified:test/repro/maintainer_gap_dom_node_contains.phpok on VM.PurHur commentedon Jul 7, 2026
claim: PHP Compiler STD Lib Advanced — batch ext/dom forward registration + htmlspecialchars_decode (#14447, #14448, #14449, #15195, #16824, #2454)
Stdlib: register ext/dom Living Standard APIs on 8.4 dev line (#14447, …
PurHur commentedon Jul 7, 2026
Merged in #17081 — DOM Living Standard APIs now register on 8.4.0-dev via builtinAdvertisementVersion(); htmlspecialchars_decode ENT_COMPAT expect aligned with php-src. Verified: CompilerVersionGateTest (Dom), VMTest dom_node_* + htmlspecialchars_decode_flags, DomDocumentVMTest, maintainer_gap dom repros.