Repository navigation
Stdlib: DOMElement::toggleAttribute() — PHP 8.3 boolean attribute toggle missing (ext/dom/php_dom.c) #16824
Description
Category
stdlib · php-src-strict
Problem
PHP 8.3+ adds DOMElement::toggleAttribute(string $qualifiedName, ?bool $force = null): bool to add/remove boolean attributes. On PHP_COMPILER_PROFILE=8.4, the method is absent and calls fatal.
| Repro | Zend 8.3+ | VM (2026-07-06, profile=8.4) |
|---|---|---|
$el->toggleAttribute('hidden') on fresh <p> |
true; hasAttribute('hidden') → true |
Error: Call to undefined method DOMElement::toggleAttribute() |
second toggleAttribute('hidden') |
false; attribute removed |
(not reached) |
php-src reference
- php/php-src
ext/dom/php_dom.c—dom_element_toggle_attribute - php.net DOMElement::toggleAttribute (PHP 8.3.0+)
PHP implementation target
ext/dom/+ existing DOM element VM/JIT paths — PHP implementation; thin C ABI only if unavoidable
Repro
./script/docker-exec.sh -- bash -lc 'export PHP_COMPILER_PROFILE=8.4; php bin/vm.php test/repro/maintainer_gap_dom_element_toggle_attribute.php'Done when
-
toggleAttribute()add/remove/$forcesemantics match Zend on VM/JIT/AOT - Compliance
.phptguard undertest/compliance/cases/stdlib/ - php-src-strict; no php-compiler-strict shortcut
Activity
PurHur commentedon Jul 6, 2026
claim: cursor-agent-lane-a — starting this run
Merge origin/master and resolve DOM 8.3 gate conflicts (#16824)
Stdlib: DOMElement::toggleAttribute() — PHP 8.3 boolean attribute tog…
PurHur commentedon Jul 6, 2026
Merged via #16835
Verification
PHP implementation:
ext/dom/ElementToggleAttribute.php,VmDom::toggleAttribute()(php-srcext/dom/element.c).PurHur commentedon Jul 7, 2026
claim: PHP Compiler STD Lib Advanced — batch ext/dom forward registration + htmlspecialchars_decode (#14447, #14448, #14449, #15195, #16824, #2454)
Stdlib: register ext/dom Living Standard APIs on 8.4 dev line (#14447, …
PurHur commentedon Jul 7, 2026
Merged in #17081 — DOM Living Standard APIs now register on 8.4.0-dev via builtinAdvertisementVersion(); htmlspecialchars_decode ENT_COMPAT expect aligned with php-src. Verified: CompilerVersionGateTest (Dom), VMTest dom_node_* + htmlspecialchars_decode_flags, DomDocumentVMTest, maintainer_gap dom repros.