Repository navigation
Stdlib: ext/dom Living Standard API registration on 8.4 dev line - #17081
Merged
PurHur merged 1 commit intoJul 7, 2026
Merged
Conversation
…#14448, #14449, #15195, #16824) Use builtinAdvertisementVersion() for DOM 8.3/8.4 forward APIs so contains(), compareDocumentPosition(), getRootNode(), isEqualNode(), toggleAttribute(), and insert-adjacent/innerHTML helpers register on the 8.4.0-dev compiler without PHP_COMPILER_PROFILE. Align VM/JIT compliance gating and fix htmlspecialchars_decode ENT_COMPAT expect drift vs php-src (#2454). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contains(),compareDocumentPosition(),getRootNode(),isEqualNode(),toggleAttribute(), insert-adjacent/innerHTML helpers) on the8.4.0-devcompiler line viabuiltinAdvertisementVersion()— implementations already lived inext/dom/but were gated behindlanguageProfileVersion()where8.4.0-dev < 8.4.0..phptguards when forward APIs are enabled.htmlspecialchars_decode()ENT_COMPAT compliance expect drift vs php-src (Stdlib: htmlspecialchars_decode() VM + LLVM JIT/AOT #2454).php-src reference
ext/dom/node.c—dom_node_contains,dom_node_compare_document_position,dom_node_get_root_node,dom_node_is_equal_nodeext/dom/element.c—dom_element_toggle_attributeext/standard/html.c—php_htmlspecialchars_decodeVerification
Closes #14447
Closes #14448
Closes #14449
Closes #15195
Closes #16824
Closes #2454
Made with Cursor