Skip to content

Stdlib: DOMNode::contains() descendant check (#14447) - #14452

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-14447-dom-node-contains
Jul 1, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/issue-14447-dom-node-contains

Conversation

@PurHur

@PurHur PurHur commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Register DOMNode::contains(?DOMNode $other): bool on the DOM node class hierarchy.
  • Implement parent-chain walk in VmDom::contains() using DomRegistry state (php-src ext/dom/node.c).

Closes #14447

php-src reference

  • ext/dom/node.c — dom_node_contains()
  • ext/dom/node.stub.php — DOMNode::contains

Verification

./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_dom_node_contains.php'
# ok, exit 0

./script/docker-exec.sh -- bash -lc './vendor/bin/phpunit --filter DomModuleTest::test_dom_node_contains_descendant_check'
# OK (1 test)

Made with Cursor

Walk parentId chains in DomRegistry so contains() matches php-src ext/dom/node.c Living Standard semantics.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 5e11db8 into master Jul 1, 2026
@PurHur
PurHur deleted the agent/issue-14447-dom-node-contains branch July 1, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdlib: DOMNode::contains() missing — descendant check fatal (ext/dom/node.c, PHP 8+)

1 participant