Repository navigation
fix(desktop): keep projects list expanded when using the add-repo menu - #6000
Conversation
The add-repository dropdown lives inside the PROJECTS header row, which toggles the list's collapse on click. The dropdown content portals to body, but React synthetic events still bubble up the component tree, so selecting any menu item collapsed the projects list. Restores the stopPropagation guard that #5956 introduced and its revert (#5996) removed. Claude-Session: https://claude.ai/code/session_01SSUQYFamkYAjs5sDQC5RLS
|
Ready to review this PR? Stage has broken it down into 1 individual chapter for you:
Chapters generated by Stage for commit 10edd86 on Jul 27, 2026 9:46pm UTC. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe add-repository dropdown now stops click and keydown events from propagating to the workspace header, preventing those interactions from toggling header collapse state. ChangesWorkspace dropdown interaction
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Selecting any item in the PROJECTS header's add-repository dropdown ("Open from folder", "Clone from URL", …) collapsed the projects list. The dropdown content portals to
document.body, but React synthetic events still bubble up the component tree to the header row's click-to-collapse handler.Restores the
stopPropagationguard on the dropdown content that #5956 introduced and its revert (#5996) removed — this piece was an independent fix that got swept out with the sort feature.https://claude.ai/code/session_01SSUQYFamkYAjs5sDQC5RLS
Summary by cubic
Keep the Projects list expanded when selecting items in the add-repository menu. Stops React event bubbling by calling stopPropagation on the dropdown content’s click and keydown so the header’s collapse toggle doesn’t trigger.
Written for commit 10edd86. Summary will update on new commits.