Skip to content

style(desktop): soften automation failed red to destructive token - #6001

Open
AviPeltz wants to merge 1 commit into
mainfrom
style-automation-failed-destructive
Open

AviPeltz wants to merge 1 commit into
mainfrom
style-automation-failed-destructive

Conversation

@AviPeltz

@AviPeltz AviPeltz commented Jul 27, 2026 •

Copy link
Copy Markdown
Collaborator

Automation failed-state dots and labels used bg-red-500 / text-red-600 dark:text-red-400, which reads harsh against the dark ember theme. This switches them to the semantic destructive token (muted brick red in dark mode).

Restores the styling that #5956 introduced and its revert (#5996) removed — the last independent fragment of that PR worth keeping (alongside #6000). The actual sort/filter feature stays out pending the activity-signal rework.

https://claude.ai/code/session_01SSUQYFamkYAjs5sDQC5RLS


Open in Stage

Summary by cubic

Switches automation failure indicators to the semantic destructive color to soften the red and align with design tokens, improving readability in the dark ember theme. Updates skipped_offline and dispatch_failed dots and labels in PreviousRunsList and AutomationRow (bg-red-500 and text-red-600 dark:text-red-400 → bg-destructive / text-destructive).

Written for commit 744152d. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Style
    • Updated automation run status indicators to use the standard destructive color styling for skipped offline and dispatch-failed states.
    • Improved failure status text styling for clearer visual consistency across automation lists.

@ghost

ghost commented Jul 27, 2026 •

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 2 individual chapters for you:

Title
1 Soften status dots in PreviousRunsList
2 Standardize failure colors in AutomationRow
Open in Stage

Chapters generated by Stage for commit 744152d on Jul 27, 2026 10:15pm UTC.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Automation failure indicators in previous runs and automation rows now use the bg-destructive and text-destructive theme classes.

Changes

Automation status styling

Layer / File(s) Summary
Failure status color updates
apps/desktop/src/renderer/routes/_authenticated/_dashboard/automations/$automationId/components/PreviousRunsList/PreviousRunsList.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/automations/components/AutomationRow/AutomationRow.tsx
Failure status dots and failed status text now use destructive theme colors.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and why, but it omits the required "How I tested it" section and checklist items. Add a "How I tested it" section with commands or screenshots, and fill out the checklist items or mark any non-applicable ones.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is a clear conventional commit that matches the main change to automation failure styling.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch style-automation-failed-destructive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Failed run dots and labels used tailwind red-500/red-600, which reads
harsh against the ember theme. Use the semantic destructive token (muted
brick red in dark) instead. Restores the styling that #5956 introduced
and its revert (#5996) removed — it was independent of the sort feature.

Claude-Session: https://claude.ai/code/session_01SSUQYFamkYAjs5sDQC5RLS
@github-actions

Copy link
Copy Markdown
Contributor

This PR has had no activity for 53 days and will close in 7 days unless there is new activity. If this contribution is still important or relevant, please leave a comment to keep it open. If it closes, you are welcome to reopen it or ask a maintainer to reopen it. Thank you for contributing!

@github-actions github-actions Bot added the stale label Sep 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant