Repository navigation
revert(desktop): remove sidebar project filter and sort pending rework (#5956) - #5996
Conversation
📝 WalkthroughWalkthroughThe sidebar project sort and filter preference features are removed. Sidebar rendering now uses local project order with always-enabled drag interactions, while the header and drag overlays are simplified. Automation failed-run indicators use explicit red styling. ChangesSidebar behavior changes
Automation status colors
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant DashboardSidebar
participant SortableContext
participant useSidebarDnd
DashboardSidebar->>SortableContext: Render projectOrder
SortableContext->>useSidebarDnd: Start project drag
useSidebarDnd->>DashboardSidebar: Set activeId and snapshot flatItems
DashboardSidebar->>DashboardSidebar: Apply reordered project list
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ready to review this PR? Stage has broken it down into 7 individual chapters for you: Chapters generated by Stage for commit 397da8c on Jul 27, 2026 8:55pm UTC. |
45cbe3f to
397da8c
Compare
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
#6000) The add-repository dropdown lives inside the PROJECTS header row, which toggles the list's collapse on click. The dropdown content portals to body, but React synthetic events still bubble up the component tree, so selecting any menu item collapsed the projects list. Restores the stopPropagation guard that #5956 introduced and its revert (#5996) removed. Claude-Session: https://claude.ai/code/session_01SSUQYFamkYAjs5sDQC5RLS
Failed run dots and labels used tailwind red-500/red-600, which reads harsh against the ember theme. Use the semantic destructive token (muted brick red in dark) instead. Restores the styling that #5956 introduced and its revert (#5996) removed — it was independent of the sort feature. Claude-Session: https://claude.ai/code/session_01SSUQYFamkYAjs5sDQC5RLS
Why
Reverts #5956 (sidebar project filter + sort). Two reasons:
.getTime()on workspaceupdatedAt, but workspaces served from the Electricv2_workspacesfallback (unreachable host with no snapshot) carry ISO-string timestamps at runtime despite theDatetype — Electric's shape parser doesn't handletimestamptz. Result:TypeError: workspace.updatedAt.getTime is not a functionthrown during render, taking down the whole dashboard. Because the sort mode persists, affected users crash on every boot.v2_workspaces.updatedAtonly moves on record patches (rename, branch change) — agent messages and terminal activity never bump it, so "Last updated" doesn't reflect what users expect. The feature needs a rework on a real activity signal before re-landing.The revert unwedges crashed users immediately: the stale persisted sort preference is dropped harmlessly by the schema (verified live).
Also includes a small independent fix surfaced while testing the revert: the sidebar drag overlays (project/workspace/section) painted an opaque
bg-backgroundslab under the dragged row, which clashes with the vibrancy-driven sidebar surface. They're transparent now — sortable siblings make room during a drag, so the floating row sits over empty sidebar.Notes
testProjectFixtures.tswas touched by feat(desktop): add workspace pinning to the v2 dashboard sidebar #5963 after feat(desktop): filter and sort projects in the dashboard sidebar #5956 added it; nothing imports it post-revert, so it's deleted.fix-sidebar-sort-crashfor the rework. Recommend cherry-picking itsmergeHostWorkspacesdate normalization separately — the string-date landmine remains for any consumer trusting theDatetype.https://claude.ai/code/session_01SSUQYFamkYAjs5sDQC5RLS
Summary by cubic
Reverts the dashboard sidebar project filter and sort to stop a boot crash and restore manual project ordering. Also updates automation failure colors and keeps drag overlays transparent for the sidebar’s vibrancy.
Bug Fixes
.getTime()on stringupdatedAt; the sidebar boots reliably.sidebarProjectSortModefromv2UserPreferences; stale values are ignored safely.bg-red-500; texttext-red-600 dark:text-red-400.Refactors
Written for commit 397da8c. Summary will update on new commits.
Summary by CodeRabbit
New Features
Bug Fixes