fix(security): bound focus manifest ingestion - #494
Merged
JSONbored merged 1 commit intoJun 10, 2026
Conversation
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 519e8c1 | Commit Preview URL Branch Preview URL |
Jun 10 2026, 06:46 AM |
23 tasks
This was referenced Jun 10, 2026
JSONbored
force-pushed
the
codex/propose-fix-for-focus-manifest-vulnerability
branch
3 times, most recently
from
June 10, 2026 06:41
d869a9d to
7f2e87d
Compare
JSONbored
force-pushed
the
codex/propose-fix-for-focus-manifest-vulnerability
branch
from
June 10, 2026 06:44
7f2e87d to
519e8c1
Compare
Closed
12 tasks
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JSON.parsed untrusted remote files viaresponse.text()with no byte-size limit, allowing a repo owner or attacker to supply a very large file and cause memory/CPU exhaustion or fail background jobs.Description
MAX_FOCUS_MANIFEST_BYTES = 64 * 1024and reject content exceeding the cap before parsing inparseFocusManifestContent.response.text()infetchRepoFocusManifestFilewith areadBoundedResponseTexthelper that checksContent-Lengthand performs a bounded streaming read that cancels and returnsnullif the response grows beyond the cap.REPO_FOCUS_MANIFEST_MAX_CONCURRENT_LOADS = 4and amapWithConcurrencyLimithelper used byloadRepoFocusManifeststo avoid unbounded parallel fetch/parse amplification.Content-Length, oversized stream cancellation, and pre-parse oversized-content rejection; update tests to import the new constants/helpers.Testing
npm run typecheck(tsc --noEmit) and fixed a minor type issue; typecheck succeeded.npm test -- --run test/unit/focus-manifest-loader.test.tsandnpm test -- --run test/unit/focus-manifest.test.ts test/unit/focus-manifest-loader.test.tsand both passed.npm testand all tests passed (95 files, 1391 tests passed, 1 skipped).Codex Task