fix(api): scope app command feedback by repo access - #492
Merged
JSONbored merged 1 commit intoJun 10, 2026
Conversation
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | ed43677 | Commit Preview URL Branch Preview URL |
Jun 10 2026, 06:38 AM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This was referenced Jun 10, 2026
Merged
JSONbored
force-pushed
the
codex/propose-fix-for-feedback-endpoint-vulnerability
branch
from
June 10, 2026 06:32
fbc9a7c to
b88ddce
Compare
JSONbored
force-pushed
the
codex/propose-fix-for-feedback-endpoint-vulnerability
branch
from
June 10, 2026 06:36
b88ddce to
ed43677
Compare
JSONbored
deleted the
codex/propose-fix-for-feedback-endpoint-vulnerability
branch
June 10, 2026 06:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
getRepositoryandrequireSessionRepoAccesswhenidentity.kind === "session"in the/v1/app/commands/feedbackhandler insrc/api/routes.ts.requireAppRoleguard for control-panel roles and only enforce repo-scoped access for session identities to avoid widening static-token behavior.test/integration/api.test.tsto verify that an in-scope repo owner can submit feedback for their repository's answer while the same user is denied when using a known answer ID from an out-of-scope private repo.Testing
npx vitest run test/integration/api.test.ts --reporter verbose, and the integration file completed successfully (all tests passed).npm run typecheck(tsc --noEmit) and the typecheck completed without errors.Codex Task