fix(settings): surface missing pull_requests:read in settings preview - #508
Merged
JSONbored merged 1 commit intoJun 10, 2026
Merged
Conversation
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
ghost
added
the
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 6d2aed0 | Commit Preview URL Branch Preview URL |
Jun 10 2026, 08:11 AM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
JSONbored
changed the title
github-actions
Bot
added
the
gittensor:bug
This was referenced Jun 10, 2026
JSONbored
force-pushed
the
codex/fix-settings-preview-missing-pr-read-permission
branch
from
June 10, 2026 08:10
136d0a5 to
6d2aed0
Compare
JSONbored
changed the title
JSONbored
deleted the
codex/fix-settings-preview-missing-pr-read-permission
branch
June 10, 2026 08:12
JSONbored
added
the
gittensor:feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pull_requests: readas required but the active missing-permission logic omittedpull_requestsfrom reported missing permissions, causing previews to hide a missing PR-read permission and produce inconsistent remediation output.Description
pull_requestsinactiveMissingPermissionsso a missingpull_requestsinstallation permission is surfaced while preserving the requirement ofpull_requests: read(notpull_requests: write).test/unit/settings-preview.test.tsto assert that a missingpull_requestsis included in the previewed missing permissions, that the permissions/checklist statuses flip toneeds_attention, and thatpull_requests: writeis not reintroduced.Testing
npx vitest run test/unit/settings-preview.test.tsand the test file passed (all tests succeeded).npm run typecheckand TypeScript typechecking completed with no errors.Codex Task