Skip to content

fix(commands): redact private score projection deltas - #495

Merged
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-pr-command-vulnerability
Jun 10, 2026
Merged

fix(commands): redact private score projection deltas#495
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-pr-command-vulnerability

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Prevent accidental public disclosure of private score-preview values that can appear in agent rerun guidance phrases such as "projected score changes X -> Y" which were reachable from public GitHub mention commands.

Description

  • Update sanitizePublicComment in src/github/commands.ts to explicitly redact the full projected score changes phrase including numeric deltas via a new regex match.
  • Also add the plain phrase projected score changes to the general forbidden-phrase replacement so isolated mentions are handled.
  • Add regression coverage in test/unit/github-commands.test.ts that asserts the sanitizer removes both the phrase and numeric score deltas and that public command outputs for @gittensory preflight, @gittensory reviewability, and @gittensory packet do not leak the numeric projections.

Testing

  • Ran the targeted unit tests with npm test -- --run test/unit/github-commands.test.ts, and the test file passed (all tests succeeded).
  • Ran TypeScript typecheck with npm run typecheck, and it completed successfully with no errors.
  • Verified repository formatting/lint/diff checks (git diff --check) produced no issues.

Codex Task

@dosubot dosubot Bot added the size:XS label Jun 9, 2026
@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 9, 2026
@ghost

ghost commented Jun 9, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #495 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui ecee76b Commit Preview URL

Branch Preview URL
Jun 10 2026, 06:50 AM

@ghost ghost added the gittensory:reviewed label Jun 9, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jun 10, 2026
@JSONbored JSONbored changed the title fix: redact private score projection deltas fix(commands): redact private score projection deltas Jun 10, 2026
@JSONbored
JSONbored force-pushed the codex/propose-fix-for-pr-command-vulnerability branch from 10d0d86 to 9e1c678 Compare June 10, 2026 06:45
@JSONbored
JSONbored force-pushed the codex/propose-fix-for-pr-command-vulnerability branch from 9e1c678 to ecee76b Compare June 10, 2026 06:48
@JSONbored
JSONbored merged commit 5d5e1e2 into main Jun 10, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 10, 2026
@JSONbored
JSONbored deleted the codex/propose-fix-for-pr-command-vulnerability branch June 10, 2026 06:52
@JSONbored JSONbored added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant