fix(ci): gate type labels for trusted PRs - #490
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 17fdd0e | Commit Preview URL Branch Preview URL |
Jun 10 2026, 06:26 AM |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This was referenced Jun 10, 2026
JSONbored
force-pushed
the
codex/fix-fork-prs-self-applying-labels-issue
branch
from
June 10, 2026 06:25
5611625 to
17fdd0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pull_request_targetruns to cause privileged repository label writes based on attacker-controlled PR titles.Description
isTrustedPullRequestForLabelingwhich returns true forauthor_associationvaluesOWNER,MEMBER, orCOLLABORATOR, or when the PRhead.repo.full_nameequals thebase.repo.full_name(same-repo PRs).pull_request_targethandling ingetTypeLabelDecisionto skip with reasonuntrusted-pull-request-authorfor untrusted PRs and short-circuitshouldFetchReferencedIssuesto avoid authenticated fetches for untrusted forks.pull-requests: writepermission from.github/workflows/type-label.ymlwhile keepingissues: writefor legitimate label operations.test/unit/github-type-label.test.tscovering trusted-author labeling, skipping untrusted fork PRs, same-repository PR behavior, and avoiding issue fetches for untrusted forks.Testing
git diff --checkwhich completed without issues.npm test -- --run test/unit/github-type-label.test.tsand all tests in that file passed (30 passed).npm run typecheckwhich completed successfully.npm run actionlintas part of validation which completed (using fallback tooling) without failing the change.Codex Task