fix(auth): enforce repo-scoped access for self-dogfood registration pack - #486
Merged
JSONbored merged 1 commit intoJun 10, 2026
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 988e6da | Commit Preview URL Branch Preview URL |
Jun 10 2026, 06:12 AM |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This was referenced Jun 9, 2026
This was referenced Jun 10, 2026
Merged
JSONbored
force-pushed
the
codex/fix-authorization-flaw-in-self-dogfood-route
branch
from
June 10, 2026 06:10
57bd485 to
988e6da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/v1/app/self-dogfood/registration-packroute performed a global role check (requireAppRole) but did not verify that a browser session actually had access to the configured self-dogfood repository, allowing maintainers of unrelated repos to view a private report.Description
RepositoryRecordinside the app route and callrequireSessionRepoAccessforsessionidentities before returning the pack.requireAppRolecheck and only adding a repo-scoped access check for browser sessions.seedInstalledRepohelper to cover the new behavior, verifying that an unrelated repo-scoped session receivesforbidden_repoand that a session scoped to the configured repo is allowed.Testing
npm run test:unit -- test/unit/routes-self-dogfood-registration-pack.test.tsand the added tests passed.tsc --noEmitvianpm run typecheckand typechecking succeeded.Codex Task