fix(api): allow maintainer settings preview sessions - #513
Merged
JSONbored merged 1 commit intoJun 10, 2026
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 0861bee | Commit Preview URL Branch Preview URL |
Jun 10 2026, 08:31 AM |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This was referenced Jun 10, 2026
JSONbored
force-pushed
the
codex/fix-maintainer-preview-endpoint-authorization
branch
from
June 10, 2026 08:30
771d8eb to
0861bee
Compare
JSONbored
deleted the
codex/fix-maintainer-preview-endpoint-authorization
branch
June 10, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/v1/repos/:owner/:repo/settings-previewusing the browser session cookie, but the global session gate only allowed/v1/app/*, causing legitimate maintainer sessions to receive403and the feature to fail.Description
POST /v1/repos/:owner/:repo/settings-previewroute now authenticates the request identity and enforces repository-scoped access for session identities viarequireSessionRepoAccess, while leaving static API-token usage unchanged.canSessionAccessPath) was extended to permit the settings preview path by adding anisRepoSettingsPreviewPathhelper.test/integration/api.test.tsto verify a maintainer/owner session can preview its owned repo and is forbidden from previewing unrelated repos.Testing
npm test -- test/integration/api.test.ts, which completed successfully (33 tests passed).npm run typecheck, which completed without type errors.Codex Task