[CP Staging] Revert "Cleanup platform specifics from hermes build" by mollfpr · Pull Request #80984 · Expensify/App

mollfpr · 2026-01-30T03:17:26Z

addresses:

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

melvin-bot · 2026-01-30T03:24:38Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-30T03:32:48Z

@mollfpr looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mollfpr · 2026-01-30T03:33:21Z

Straight revert, removing the label.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: baf005c024

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-30T03:33:51Z

 };

-const mergedConfig = wrapWithReanimatedMetroConfig(mergeConfig(defaultConfig, config));
+const mergedConfig = wrapWithReanimatedMetroConfig(mergeConfig(defaultConfig, expoConfig, config));


Merge Metro configs sequentially so custom settings apply

mergeConfig from @react-native/metro-config only merges two configs; passing three arguments means the third (config) is ignored, so your custom resolver/transformer settings never apply. That drops .lottie from assetExts, the e2e.* source extensions, and the inlineRequires override, which will cause Metro to fail to resolve Lottie assets and e2e source files in any dev/CI bundle. Chain mergeConfig calls so the custom config is actually merged.

Useful? React with 👍 / 👎.

…m-OS-select-from-the-Hermes-bundle Revert "Cleanup platform specifics from hermes build" (cherry picked from commit 6690357) (cherry-picked to staging by Beamanator)

OSBotify · 2026-01-30T04:36:06Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.3.11-15 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-30T18:05:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-30T22:20:12Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:27:11Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Revert "Cleanup platform specifics from hermes build"

baf005c

melvin-bot Bot assigned mollfpr Jan 30, 2026

mollfpr marked this pull request as ready for review January 30, 2026 03:24

mollfpr requested review from a team as code owners January 30, 2026 03:24

melvin-bot Bot requested review from MariaHCD and trjExpensify and removed request for a team January 30, 2026 03:24

inimaga approved these changes Jan 30, 2026

View reviewed changes

mollfpr mentioned this pull request Jan 30, 2026

Tags - Import multi-level tags to workspace is failed #80844

Closed

7 tasks

Beamanator approved these changes Jan 30, 2026

View reviewed changes

mollfpr merged commit 6690357 into main Jan 30, 2026
39 of 42 checks passed

mollfpr deleted the revert-80110-Cleanup-platform-OS-select-from-the-Hermes-bundle branch January 30, 2026 03:32

melvin-bot Bot added the Emergency label Jan 30, 2026

mollfpr removed the Emergency label Jan 30, 2026

chatgpt-codex-connector Bot reviewed Jan 30, 2026

View reviewed changes

mollfpr changed the title ~~Revert "Cleanup platform specifics from hermes build"~~ [CP Staging] Revert "Cleanup platform specifics from hermes build" Jan 30, 2026

github-actions Bot mentioned this pull request Jan 30, 2026

Investigate workflow job failing on main: test / test (job 2) #80985

Closed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 30, 2026

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

This was referenced Jan 30, 2026

Native share - Unexpected error appears in chat when sharing an image #80838

Closed

Scan-PDF receipt is not displayed when opened for the first time #80864

Closed

OSBotify mentioned this pull request Mar 11, 2026

Android - Tags - Multi level tags file cannot be imported #84969

Closed

7 tasks

MelvinBot mentioned this pull request Mar 12, 2026

Native share - Unable to upload photo when shared from gallery #85018

Closed

7 tasks

OSBotify mentioned this pull request Mar 18, 2026

[Due for payment 2026-03-30] Tags - Unable to import multi-level tags #85708

Closed

7 tasks

Navigation Menu

Uh oh!

[CP Staging] Revert "Cleanup platform specifics from hermes build" - #80984

[CP Staging] Revert "Cleanup platform specifics from hermes build"#80984
mollfpr merged 1 commit into
mainfrom
revert-80110-Cleanup-platform-OS-select-from-the-Hermes-bundle

mollfpr commented Jan 30, 2026 •

edited by grgia

Loading

Uh oh!

melvin-bot Bot commented Jan 30, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented Jan 30, 2026

Uh oh!

mollfpr commented Jan 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jan 30, 2026

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mollfpr commented Jan 30, 2026 • edited by grgia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Author Checklist

Uh oh!

melvin-bot Bot commented Jan 30, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented Jan 30, 2026

Uh oh!

mollfpr commented Jan 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mollfpr commented Jan 30, 2026 •

edited by grgia

Loading