Cleanup platform specifics from hermes build by rinej · Pull Request #80110 · Expensify/App

rinej · 2026-01-21T12:57:56Z

Explanation of Change

In the PR we're enabling platform shaking by aligning Metro and Babel configurations and removing the unnecessary Expo Metro config dependency. This allows Metro to properly eliminate unused, platform-specific code from the final bundle.
The bundle size was reduced from 37.1 MB to 34.2 MB (~2.9 MB, ~8%).
These changes still need to be validated on ad-hoc builds to ensure everything works as expected.

Fixed Issues

$ #80500
PROPOSAL:

Tests

Validate that app doesn't crash when opened

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-01-23T15:31:57Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-01-23T15:42:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 22 files with indirect coverage changes

…undle

melvin-bot · 2026-01-27T11:05:23Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-27T11:05:30Z

@akinwale @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thymikee · 2026-01-27T11:55:43Z


 const metro = {
-    presets: [require('@react-native/babel-preset')],
+    presets: [[require('@react-native/babel-preset'), {disableImportExportTransform: true}]],


how about

Suggested change

presets: [[require('@react-native/babel-preset'), {disableImportExportTransform: true}]],

presets: [[require('@react-native/babel-preset'), {disableImportExportTransform: runningIn !== 'babel-jest'}]],

I thought about if, but for it we will have to wrap metro config into module to get the runningIn variable from api.
If metro is outside the function, it builds once when the module loads. If we move it inside it rebuilds on every Babel call. TBH I am not sure if it will impact the performance, but it might.

thymikee · 2026-01-27T11:56:15Z

@@ -1,4 +1,3 @@
-const {getDefaultConfig: getExpoDefaultConfig} = require('expo/metro-config');


expo/metro-config could potentially be removed from the project deps as well?

We don’t have this package directly added to package.json, so there’s nothing to remove on our side. We still have some expo packages in the project, it can be required indirectly as a transitive dependency though

trjExpensify · 2026-01-28T00:51:42Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

dukenv0307 · 2026-01-28T02:46:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-28.at.09.18.18.mov

Android: mWeb Chrome

Screen.Recording.2026-01-28.at.09.02.45.mov

iOS: HybridApp

Screen.Recording.2026-01-28.at.09.45.51.mov

iOS: mWeb Safari

Screen.Recording.2026-01-28.at.09.01.15.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-28.at.08.59.48.mov

dukenv0307 · 2026-01-28T02:47:23Z

@mountiny Changes look good and work well

OSBotify · 2026-01-28T03:06:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

thymikee · 2026-01-28T09:18:58Z

Curious how this affects TTI metrics, please let me know @roryabraham @rinej

OSBotify · 2026-01-28T23:21:22Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.11-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:19:08Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

cleanup platform specifics from hermes build

9b5297c

melvin-bot Bot assigned rinej Jan 21, 2026

fix jest tests

e9c217b

fabioh8010 approved these changes Jan 21, 2026

View reviewed changes

rinej added 2 commits January 23, 2026 16:30

remove expo config from metro config

4df5ea2

change android entry point to not use expo

4548e4b

rinej added 2 commits January 23, 2026 18:10

cleanup

8feec1c

Merge branch 'main' into Cleanup-platform-OS-select-from-the-Hermes-b…

15799a3

…undle

rinej marked this pull request as ready for review January 27, 2026 11:05

rinej requested review from a team as code owners January 27, 2026 11:05

melvin-bot Bot requested review from jayeshmangwani and trjExpensify January 27, 2026 11:05

melvin-bot Bot requested review from a team, akinwale and roryabraham and removed request for a team January 27, 2026 11:05

rinej changed the title ~~cleanup platform specifics from hermes build~~ Cleanup platform specifics from hermes build Jan 27, 2026

thymikee reviewed Jan 27, 2026

View reviewed changes

trjExpensify removed their request for review January 28, 2026 00:51

dukenv0307 approved these changes Jan 28, 2026

View reviewed changes

roryabraham approved these changes Jan 28, 2026

View reviewed changes

roryabraham merged commit 2cf4850 into Expensify:main Jan 28, 2026
37 of 43 checks passed

OSBotify mentioned this pull request Jan 28, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

rinej mentioned this pull request Jan 29, 2026

Android App Stuck on Loading Splash Screen (Infinite Loading) #79386

Closed

7 tasks

This was referenced Jan 30, 2026

[CP Staging] Revert "Cleanup platform specifics from hermes build" #80984

Merged

Tags - Import multi-level tags to workspace is failed #80844

Closed

MelvinBot mentioned this pull request Feb 20, 2026

[HOLD react/metro#1460][$250] Enable Platform Shaking for React Native Bundle Size Optimization #80500

Open

OSBotify mentioned this pull request Mar 11, 2026

Android - Tags - Multi level tags file cannot be imported #84969

Closed

7 tasks

MelvinBot mentioned this pull request Mar 12, 2026

Native share - Unable to upload photo when shared from gallery #85018

Closed

7 tasks

OSBotify mentioned this pull request Mar 18, 2026

[Due for payment 2026-03-30] Tags - Unable to import multi-level tags #85708

Closed

7 tasks

quinthar added the #quality label Aug 11, 2026

	presets: [[require('@react-native/babel-preset'), {disableImportExportTransform: true}]],
	presets: [[require('@react-native/babel-preset'), {disableImportExportTransform: runningIn !== 'babel-jest'}]],

		@@ -1,4 +1,3 @@
		const {getDefaultConfig: getExpoDefaultConfig} = require('expo/metro-config');

Uh oh!

Conversation

rinej commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jan 23, 2026

Uh oh!

codecov Bot commented Jan 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jan 27, 2026

Uh oh!

melvin-bot Bot commented Jan 27, 2026

Uh oh!

thymikee Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

rinej Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

thymikee Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

thymikee Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

rinej Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Jan 28, 2026

Uh oh!

dukenv0307 commented Jan 28, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

thymikee commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rinej commented Jan 21, 2026 •

edited

Loading

codecov Bot commented Jan 23, 2026 •

edited by github-actions Bot

Loading

dukenv0307 commented Jan 28, 2026 •

edited

Loading